Defect #7329

<code class="javascript"> with long strings may hang server

Added by Etienne Massip almost 7 years ago. Updated almost 7 years ago.

Status:ClosedStart date:2011-01-14
Priority:HighDue date:
Assignee:Etienne Massip% Done:

0%

Category:Core Plugins
Target version:1.1.1
Resolution:Fixed Affected version:1.1.0

Description

It's a CodeRay parser bug, see http://redmine.rubychan.de/issues/264.


Related issues

Related to Redmine - Feature #5344: Update to latest CodeRay 0.9.x Closed 2010-04-19

History

#1 Updated by Etienne Massip almost 7 years ago

0.9.7 release is dedicated to fix this bug.

Supersedes #5344 and related to #4264.

#2 Updated by Etienne Massip almost 7 years ago

0.9.7 is out and is a recommended security upgrade !

#3 Updated by Kornelius Kalnbach almost 7 years ago

Is this solved now, with the update to 0.9.7?

#4 Updated by Jean-Philippe Lang almost 7 years ago

  • Assignee changed from Jean-Philippe Lang to Etienne Massip

Etienne, can you confirm the fix?

#5 Updated by Etienne Massip almost 7 years ago

Should be.

But, err, I just tried to parse http://www.redmine.org/issues/7265#note-2 JavaScript excerpt on http://coderay.rubychan.de and it looks like I killed it a second time ?!

I presume that http://coderay.rubychan.de is up to date ?!

I'll make a try on redmine's trunk.

#6 Updated by Etienne Massip almost 7 years ago

Ok, i confirm that the bug is gone on redmine's trunk with 0.9.7, so it's probably a http://coderay.rubychan.de side problem.

Waiting for an answer from Kornelius to be absolutely sure.

#7 Updated by Etienne Massip almost 7 years ago

Response from Kornelius :

Found the problem: I was using the CodeRay 1.0 development branch, which
still has the bug. It overwrote my manual fix when I deployed it after
the 0.9.7 release :P

So : yes, this issue is fixed by Redmine's trunk !

#8 Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from New to Resolved
  • Target version set to 1.1.1
  • Resolution set to Fixed

Thanks, I'll merge it into 1.1-stable since it can be considered as a severe issue.

#9 Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Resolved to Closed

Merged in 1.1-stable in r4774.

Also available in: Atom PDF