https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292011-01-25T18:44:14ZRedmineRedmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=244712011-01-25T18:44:14ZBrian Lindahl
<ul></ul><p>Please add relations to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: New Permission: Edit own issues (Closed)" href="https://www.redmine.org/issues/1248">#1248</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: add new permission 'edit issue planning' (Closed)" href="https://www.redmine.org/issues/1445">#1445</a>.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=245332011-01-26T21:13:21ZBrian Lindahl
<ul><li><strong>File</strong> <a href="/attachments/5218">issue-permissions-1.1.0.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5218/issue-permissions-1.1.0.patch">issue-permissions-1.1.0.patch</a> added</li><li><strong>% Done</strong> changed from <i>50</i> to <i>80</i></li></ul>Improvements made:
<ul>
<li>migrated to Redmine 1.1.0</li>
<li>added 'edit progress' permission</li>
<li>changed 'edit own issue' permission to separate 'edit authored issue' and 'edit assigned issue' permissions</li>
<li>improved restrictions on subject/description editing (edit authored issue)</li>
<li>improved restrictions on properties editing (the author can now edit properties once the issue is closed - for re-opening purposes)</li>
<li>updated 'safe_attributes' to correlate to new permissions</li>
</ul> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=245382011-01-26T21:24:17ZBrian Lindahl
<ul><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>I've assigned this to you, since I couldn't find a better way to notify you of this patch for improvements to the edit issue permissions. If you wish to include it, this patch seems like a good candidate for 1.2.0, given the other work being done in this area. There might be some minor integration/overlap with <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Allow additional workflow transitions for author and assignee (Closed)" href="https://www.redmine.org/issues/2732">#2732</a>. Let me know if you need help sorting this integration/overlap out.</p>
<p>Also check out <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Found-in-version patch (Closed)" href="https://www.redmine.org/issues/7443">#7443</a>. While not related to the other fixes going on in this area, it solves a MAJOR unsolved problem with Redmine for a large number of your community (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add 'affected version' as a standard field (Closed)" href="https://www.redmine.org/issues/1675">#1675</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: New Custom Field "Found in Version" (Closed)" href="https://www.redmine.org/issues/685">#685</a>).</p>
<p>Thanks!</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=248482011-02-04T18:43:22ZBrian Lindahl
<ul><li><strong>File</strong> <a href="/attachments/5283">issue-permissions-1.1.0.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5283/issue-permissions-1.1.0.patch">issue-permissions-1.1.0.patch</a> added</li></ul><p>Fixed a minor bug in 'lib/redmine/default_data/loader.rb' where the Reporter role was assigned the 'edit_own_issues' permission (which was changed in the 1.1.0 patch). The role was supposed to be assigned the 'edit_authored_issues'.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=249892011-02-09T05:25:44Zhendro utomo
<ul></ul><p>hi brian,.very helpfull patch,. but i can't apply it against my redmine instance, it get "patch: <strong>**</strong> Only garbage was found in the patch input.". i've try it using redmine 1.1 stable. is there something i'm missing out?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=250332011-02-09T17:20:02ZBrian Lindahl
<ul></ul><p>Are you using GNU patch? It works fine for me on a fresh copy of redmine 1.1 stable and the patch file directly downloaded from here. Maybe you copied and pasted the patch file rather than downloading it?</p>
<pre>
C:\redmine-1.1.0-issue-permissions>dir
Volume in drive C has no label.
Volume Serial Number is B0F5-5D37
Directory of C:\redmine-1.1.0-issue-permissions
02/09/2011 10:14 AM <DIR> .
02/09/2011 10:14 AM <DIR> ..
01/09/2011 05:05 PM 322 .gitignore
01/09/2011 05:05 PM 317 .hgignore
02/09/2011 10:15 AM <DIR> app
02/09/2011 10:14 AM <DIR> config
02/09/2011 10:14 AM <DIR> db
02/09/2011 10:14 AM <DIR> doc
02/09/2011 10:14 AM <DIR> extra
02/09/2011 10:14 AM <DIR> files
02/09/2011 10:12 AM 15,061 issue-permissions-1.1.0.patch
02/09/2011 10:14 AM <DIR> lib
02/09/2011 10:14 AM <DIR> log
02/09/2011 10:14 AM <DIR> public
01/09/2011 05:05 PM 307 Rakefile
01/09/2011 05:05 PM 208 README.rdoc
02/09/2011 10:14 AM <DIR> script
02/09/2011 10:14 AM <DIR> test
02/09/2011 10:14 AM <DIR> tmp
02/09/2011 10:14 AM <DIR> vendor
5 File(s) 16,215 bytes
15 Dir(s) 205,845,831,680 bytes free
C:\redmine-1.1.0-issue-permissions>patch -p1 < issue-permissions-1.1.0.patch
patching file app/controllers/issues_controller.rb
patching file app/models/issue.rb
Hunk #2 succeeded at 246 with fuzz 1.
patching file app/models/mail_handler.rb
patching file app/views/issues/_attributes.rhtml
patching file app/views/issues/_edit.rhtml
patching file app/views/issues/_form_update.rhtml
patching file config/locales/en.yml
patching file lib/redmine/default_data/loader.rb
patching file lib/redmine.rb
</pre> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=250352011-02-09T17:38:52ZBrian Lindahl
<ul><li><strong>File</strong> <a href="/attachments/5348">issue-permissions-1.1.0.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5348/issue-permissions-1.1.0.patch">issue-permissions-1.1.0.patch</a> added</li></ul><p>I should probably explain why I did this:<br /><pre>changed 'edit own issue' permission to separate 'edit authored issue' and 'edit assigned issue' permissions</pre></p>
<p>The use case here, is that you may want to assign an issue back to the author for feedback. However, you still want to prevent the author from changing the issue's properties. That said the issue-permissions-1.1.0-bugfix1 didn't enforce this. I've fixed this problem in issue-permissions-1.1.0-bugfix2.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=250582011-02-09T23:20:43ZTerence Mill
<ul></ul><p>+1 to move to trunk</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=250612011-02-10T01:09:39Zhendro utomo
<ul></ul><p><cite>Are you using GNU patch? It works fine for me on a fresh copy of redmine 1.1 stable and the patch file directly downloaded from here. Maybe you copied and pasted the patch file rather than downloading it</cite>?</p>
<p>i'm sory brian, it looks like i've downloaded the wrong file :P, i'm sory, the patch works great, but i had to use <br /><pre>
patch -p1 < your.patch
</pre></p>
<p>thank you very much, this is very useful patch</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=251122011-02-11T13:44:08ZMaxim Antufyev
<ul></ul><p>Should this patch fit redmine 1.1.1 ? Or I have to downgrade to 1.1.0 ?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=251212011-02-11T20:07:51ZBrian Lindahl
<ul></ul><p>I'm only maintaining this patch across stable major versions. It should work, but I have not tested it with 1.1.1.</p>
<p>Also related to <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: edit_own_issues and delete_own_issues permissions (New)" href="https://www.redmine.org/issues/5195">#5195</a></p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=254442011-02-22T05:46:20Zhendro utomo
<ul></ul><p>hello again brian,...i got a litle more problem regarding your patch, not how to patch it :P, but rather it's functionality. Let say user A, user B and User C. User A create an issue and assign it to User B, and before user B got the chance to update this issue, user A add notes first. My problem is, whenever this action happen, assignee always change to User C, which is the default assigne for this project, and User C had to assign it back to User B in order the workflow to proceed. So, is there some thing wrong?</p>
<p>for information,<br />1. i also use <a href="http://www.redmine.org/plugins/auto_assigned_user" class="external">Auto Assigned Issue</a> by Ludovic Gasc. If an user forget to assign the issue, this plugin will auto-assign to the project manager. <br />2. User C as Project Manager<br />3. User A as Consultant<br />4. User B as Developer</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=254802011-02-22T17:37:23ZBrian Lindahl
<ul></ul><p>Which is the problem?</p>
<p>1) when user A adds notes, the assignee changes to user C?<br />or<br />2) user C is required to assign the issue back to user B (user B can't do it himself - no permission)?</p>
<p>If the problem is 1), then problem is in the 'auto assigned issue' plugin.</p>
<p>If the problem is 2), then user B (who only has the 'edit assigned issues' permission) is prohibited from updating the issue, since it's NOT assigned to user B, but assigned to user C. This is expected behavior. By giving user B the 'edit all issues' permission, then user B can edit the issue, even if it's assigned to user C. Note that a user has to have the 'edit issue planning' permission in order to edit the 'assigned to' field.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=254822011-02-22T17:54:23Zhendro utomo
<ul></ul><p>Brian Lindahl wrote:</p>
<blockquote>
<p>Which is the problem?</p>
<p>1) when user A adds notes, the assignee changes to user C?</p>
</blockquote>
<blockquote>
<p>If the problem is 1), then problem is in the 'auto assigned issue' plugin.</p>
</blockquote>
<p>yup, point no 1 is my problem, just to make sure, im going check on this plugin again. thx brian, i'll post about this as soon as i get my answer :)</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=255542011-02-24T01:59:19Zhendro utomo
<ul></ul><p>hi brian,<br />could you look into this script for me?i'm not really a programmer<br /><pre>
module AutoAssignedUser
class Hooks < Redmine::Hook::ViewListener
def controller_issues_new_before_save(context)
autoset_user(context)
end
def controller_issues_edit_before_save(context)
autoset_user(context)
end
def autoset_user(context)
@settings ||= Setting.plugin_redmine_auto_assigned_user
if context[:params][:issue]
if context[:params][:issue][:assigned_to_id].blank?
unless context[:issue].project.members.find(:all, :conditions => ["user_id = ? AND role_id IN (?)", User.current.id, @settings['client_roles'].collect(&:to_i)], :include => [:user, :roles]).first.blank? # If the user is the client, fill the "assigned to" field
users_list = context[:issue].project.users_by_role
manager_role = Role.find(@settings['project_manager_role'].to_i)
context[:issue].assigned_to_id = users_list[manager_role].first.id unless users_list[manager_role].blank?
end
end
end
end
end
end
</pre></p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=261582011-03-09T20:07:11ZBrian Heasley
<ul></ul><p>Great patch, is this for sure going into 1.2? It really is need.</p>
<p>Any word on 1.1.1 compatibility?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=262022011-03-10T20:38:56ZBrian Lindahl
<ul></ul><p>Not sure. It would probably work just fine for 1.1.1, though. As far as I know, this patch is not going into v1.2.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=264502011-03-15T16:35:19ZCarlo Landmeter
<ul></ul><p>Would love to see this included.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=270722011-03-24T17:30:56ZBrian Heasley
<ul></ul><p>Our problem is Reporters assigning issues to developers as mentioned in RM <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Manage permission on issue assigment (Closed)" href="https://www.redmine.org/issues/3461">#3461</a>. Would this patch cover that? I can't tell if Edit Own Issue would give the reporter the ability to also assign it.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=270812011-03-24T19:35:52ZBrian Lindahl
<ul></ul><p>Brian,</p>
<p>The 'Edit Issue Planning' permission would solve your problem.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=270822011-03-24T19:43:43ZBrian Heasley
<ul></ul><p>Brian: Thanks, I see that now, sorry I missed it. I do hope this makes it into the Redmine trunk.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=270882011-03-24T21:58:56ZTerence Mill
<ul></ul><p>+1</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=273272011-03-29T15:14:08ZTerence Mill
<ul></ul><p>Why is percent done only 80%? Are there still tests for this new features?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=274712011-04-01T20:43:53ZBrian Lindahl
<ul></ul><p>Yes, 80% done because there are no tests written for this patch.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=287462011-05-09T12:01:55ZPierre MARC
<ul></ul><p>This functionality is important for our organization. When do you think this would be available in an offical release ?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=287622011-05-09T19:32:46ZTerence Mill
<ul></ul><p>covered by spec <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Mightful workflow field enhancement: visible, read only and mandatory (Closed)" href="https://www.redmine.org/issues/8050">#8050</a></p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=288802011-05-13T05:53:05ZDigital Dude
<ul><li><strong>Assignee</strong> changed from <i>Jean-Philippe Lang</i> to <i>Brian Lindahl</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>50</i></li></ul><p>Redmine should enable setting permissions for issue priority & target version individually.<br />When patching up for this?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=301992011-06-23T15:30:58ZГлюк Красношахтинский
<ul></ul><p>will this patch be included into future versions?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=302032011-06-23T20:13:37ZTerence Mill
<ul></ul><p>The problem with that patch is that it is very special to certain type of project type.<br />It would be better to make it configurable which fields in trackers can be</p>
<ul>
<li>visible (not visible)</li>
<li>read only (writable))</li>
<li>mandatory (optional writable)</li>
</ul>
<p>dependent on role and status.</p>
<p>See <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Mightful workflow field enhancement: visible, read only and mandatory (Closed)" href="https://www.redmine.org/issues/8050">#8050</a> for a brife description. <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Mightful workflow field enhancement: visible, read only and mandatory (Closed)" href="https://www.redmine.org/issues/8050">#8050</a> will also cover this feature.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=350582011-12-29T09:30:32ZGuy Barnhart-Magen
<ul></ul><p>is there a chance to get an update for version 1.3.0?</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=424752012-10-29T16:29:47ZBrian Lindahl
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>Resolved, more or less, in <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Mightful workflow field enhancement: visible, read only and mandatory (Closed)" href="https://www.redmine.org/issues/8050">#8050</a>.</p> Redmine - Patch #7444: Patch for improved issue edit permissionshttps://www.redmine.org/issues/7444?journal_id=441112013-01-12T15:47:46ZEtienne Massip
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>