Redmine

To avoid issues with any special characters in URL I use Tortoise svn and it's " copy url link " option while browing repository. So Redmine gets nice clean proper URLs:

https://server/projects/Project%20Name

However, new Redmine now is munging clean URLs. For example the above URL gets parsed as:

https://server/projects/Project%2520Name

as far as I can guess, the URL is meant to be escaped, however lib\redmine\scm\adapters\subversion_adapter.rb is doing too much of replacing :

        def target(path = '')
          base = path.match(/^\//) ? root_url : url
          uri = "#{base}/#{path}" 
          uri = URI.escape(URI.escape(uri), '[]')
          shell_quote(uri.gsub(/[?<>\*]/, ''))
        end

This code is escaping too much. If URL is properly entered (and it should be) then no need to escape it again.

This is a regression from 0.9 series that worked ok with URLs.