Feature #7747

Add capability to ask\accept\reject review of patches (flag support on attachments)

Added by pasquale [:dedalus] over 6 years ago. Updated over 6 years ago.

Status:NewStart date:2011-03-01
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues workflow
Target version:-
Resolution:

Description

In bugzilla, we can ask for reviewing as patch: generally speaking an attachment can flag as "patch" and in this case the engine enable a flag to ask a review to project owner.
The project owner can reject the patch (review-) or approve the patch (review+).
It's great if redmine could be this in some way: add flag to attachment to make attachment "patch" and enable for "patch" flags to ask\accept\reject reviews

Immagine.png - bugzilla in action (19.3 KB) pasquale [:dedalus], 2011-03-15 08:52


Related issues

Related to Redmine - Patch #2525: Redmine management of Git repositories New 2009-01-18
Related to Redmine - Feature #469: Code Review/Approve workflow? Closed
Related to Redmine - Feature #2048: Code Review Module New 2008-10-18

History

#1 Updated by Etienne Massip over 6 years ago

  • Category set to SCM

A la Gerrit / Gitosis ?

#2 Updated by pasquale [:dedalus] over 6 years ago

Etienne Massip wrote:

A la Gerrit / Gitosis ?

I dont know well git behavior.
Surely my english don't help you( :-) ) : see an example on
https://bugzilla.mozilla.org/show_bug.cgi?id=468808

#3 Updated by Etienne Massip over 6 years ago

  • Subject changed from Add capability to ask\accept\reject review of patches to Add capability to ask\accept\reject review of patches (flag support on attachments)

#4 Updated by pasquale [:dedalus] over 6 years ago

I think that in a production environment this is an essential feature: if I'm the owner of a project and some collegue create a patch, it's very important to comunicate with him with flag: review+, riview- (of patch).

Priority should be High and not Normal

#5 Updated by pasquale [:dedalus] over 6 years ago

xref bug #469 and bug #2048

#6 Updated by pasquale [:dedalus] over 6 years ago

attached example screenshot

#7 Updated by Toshi MARUYAMA over 6 years ago

  • Category changed from SCM to Issues workflow

Also available in: Atom PDF