bigdecimal-segfault-fix.rb must be removed for Oracle
|Assignee:||Jean-Philippe Lang||% Done:|
config/initializers/bigdecimal-segfault-fix.rb was added to take care of the DoS bug in Ruby 1.8.7-p160 and all prior versions. As I am trying to get Redmine working with Oracle 11 I found that this file throws an error when I do the db migrate. Since I am using Ruby 1.8.7-p174 I simply removed bigdecimal-segfault-fix.rb.
Can there be some kind of check put in the file or installation to first check the Ruby version before attempting to apply the bigdecimal fix?
#1 Updated by Kevin O over 5 years ago
Can we just remove this file for current trunk, as it only supports Redmine 1.8.7, from which to my understanding, after a certain patch level, no long is affected by this problem.
#4 Updated by Etienne Massip over 5 years ago
I try to relate every issue created about Oracle to #944 to keep a track of what could be done to support it; those issues are real even if closed as Invalid.
According to forums, people generally succeed to install Redmine with Oracle but this requires a few monkey patches (but not a lot); I specifically remember of issues related to 1 or 2 tables name length too long for an Oracle DB.
Adding support to Oracle (and why not, even if less often evoked, MSSQL) should not be that hard and would help integration/promotion of Redmine in companies tied by global contracts with Oracle (or Microsoft).
Moreover, I guess that setting up a CI with Oracle XE or SQL Server Express is possible.
#6 Updated by Etienne Massip over 5 years ago
From what I've seen when I had a quick look 2 weeks ago, both ActiveRecord adapers are on GitHub and updated frequently and recently; I saw that SQL Server adapter was even already compatible with Rails 3.2.
I would say that supporting both of them is worth it, especially Oracle since it seems to be the most frequently asked for, but that's only my POV.