Patch #7855

English translation

Added by F. W. over 6 years ago. Updated over 6 years ago.

Status:ClosedStart date:2011-03-14
Priority:NormalDue date:
Assignee:-% Done:

90%

Category:Translations
Target version:-

Description

"First name" and "Last name" is misspelled "Firstname" and "Lastname". Forums are twice called "Boards" instead of "Forums".

--- config/locales/en-GB.yml
+++ config/locales/en-GB.yml
@@ -205,8 +205,8 @@ en-GB:
   field_description: Description
   field_summary: Summary
   field_is_required: Required
-  field_firstname: Firstname
-  field_lastname: Lastname
+  field_firstname: First name
+  field_lastname: Last name
   field_mail: Email
   field_filename: File
   field_filesize: Size
@@ -392,7 +392,7 @@ en-GB:
   permission_browse_repository: Browse repository   
   permission_view_changesets: View changesets
   permission_commit_access: Commit access
-  permission_manage_boards: Manage boards
+  permission_manage_boards: Manage forums
   permission_view_messages: View messages
   permission_add_messages: Post messages
   permission_edit_messages: Edit messages
@@ -408,7 +408,7 @@ en-GB:
   project_module_files: Files
   project_module_wiki: Wiki
   project_module_repository: Repository
-  project_module_boards: Boards
+  project_module_boards: Forums

   label_user: User
   label_user_plural: Users
--- config/locales/en.yml
+++ config/locales/en.yml
@@ -210,8 +210,8 @@ en:
   field_description: Description
   field_summary: Summary
   field_is_required: Required
-  field_firstname: Firstname
-  field_lastname: Lastname
+  field_firstname: First name
+  field_lastname: Last name
   field_mail: Email
   field_filename: File
   field_filesize: Size
@@ -410,7 +410,7 @@ en:
   permission_browse_repository: Browse repository
   permission_view_changesets: View changesets
   permission_commit_access: Commit access
-  permission_manage_boards: Manage boards
+  permission_manage_boards: Manage forums
   permission_view_messages: View messages
   permission_add_messages: Post messages
   permission_edit_messages: Edit messages
@@ -427,7 +427,7 @@ en:
   project_module_files: Files
   project_module_wiki: Wiki
   project_module_repository: Repository
-  project_module_boards: Boards
+  project_module_boards: Forums
   project_module_calendar: Calendar
   project_module_gantt: Gantt

en.yml Magnifier (37.8 KB) F. W., 2011-03-14 14:05

en-GB.yml Magnifier (37.9 KB) F. W., 2011-03-14 14:05

Associated revisions

Revision 5261
Added by Jean-Philippe Lang over 6 years ago

Translations updates by joergleis (#7855).

Revision 5262
Added by Jean-Philippe Lang over 6 years ago

Set native eol on en-GB.yml (#7855).

Revision 5263
Added by Jean-Philippe Lang over 6 years ago

Fixes en-GB translation for field_member_of_group and field_assigned_to_role (#7855).

Revision 5268
Added by Toshi MARUYAMA over 6 years ago

scm: git: fix annotate test due to changing en.yml (#8035, #7855).

Revision 5269
Added by Toshi MARUYAMA over 6 years ago

Fix annotate functional roles_controller_test.rb due fails to changing en.yml (#8035, #7855).

Revision 5270
Added by Toshi MARUYAMA over 6 years ago

Fix test/integration/api_test/users_test.rb fails due to changing en.yml (#8035, #7855).

History

#1 Updated by F. W. over 6 years ago

I've now also corrected "can not" to "cannot" and the spaces before question marks. I reordered the British English translation so that a diff shows the differences to the American version (consequently, I also converted the British version to Unix line endings.)

What I didn't change (yet):
  • British contains a "currency" section, American doesn't
  • "field_member_of_group" and "field_assigned_to_role" have totally different translations
  • text_tip_issue_* refer to "task", and not "issue", in British
  • Why are some strings enclosed in quotations marks (either ' or ")?

Since I cannot change the issue's description, note that the diff is now incomplete. I attached the updated files.

#2 Updated by Etienne Massip over 6 years ago

  • Category set to Translations

#3 Updated by F. W. over 6 years ago

Since these changes are very minor, I'd expect them to be merged in trunk. Are there any issues with it?

#4 Updated by Jean-Philippe Lang over 6 years ago

  • Status changed from New to Closed

F. W. wrote:

I've now also corrected "can not" to "cannot" and the spaces before question marks. I reordered the British English translation so that a diff shows the differences to the American version (consequently, I also converted the British version to Unix line endings.)

Your changes are merged in r5261.
Native eol svn property on en-GB.yml was missing, fixed in r5262.

What I didn't change (yet):
  • British contains a "currency" section, American doesn't

Currencies are not actually used in Redmine core but it wouldn't be a bad thing to add it if a plugin needs it.

  • "field_member_of_group" and "field_assigned_to_role" have totally different translations

It looks like it wasn't fixed in r4279 for en-GB.yml. Done in r5263.

  • text_tip_issue_* refer to "task", and not "issue", in British

Maybe we can set it back to "issue" for consistency.

  • Why are some strings enclosed in quotations marks (either ' or ")?

It is sometimes required to make it a valid yaml file.

Also available in: Atom PDF