Feature #8160

Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution

Added by Keidson Freitas over 7 years ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Issues filter
Target version:4.0.0
Resolution:Fixed

Description

When i try to use the watcher in the filter on issues, the list is only showing <<Me>>, so i can only filter issues watched by Me or not watched by Me.

Add_filter_value_of_watcher.patch Magnifier (2.64 KB) Mizuki ISHIKAWA, 2018-06-25 10:12

Add_filter_value_of_watcher_v2.patch Magnifier (2.76 KB) Mizuki ISHIKAWA, 2018-06-26 02:46


Related issues

Duplicated by Redmine - Defect #15347: Issue filter does not allow filtering by any watcher exce... Closed
Duplicated by Redmine - Feature #10912: Add search by watcher Closed
Duplicated by Redmine - Defect #27123: Issue filter "watcher" dosn't show any users Closed

Associated revisions

Revision 17439
Added by Go MAEDA about 1 month ago

Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution (#8160).

Patch by Mizuki ISHIKAWA.

History

#1 Updated by Etienne Massip over 7 years ago

  • Category set to Issues
  • Target version set to Candidate for next minor release

Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.

#2 Updated by Mischa The Evil over 7 years ago

  • Tracker changed from Defect to Feature
  • Subject changed from The watcher filter it's only showing <<Me>> in the list to Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution

Etienne Massip wrote:

Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.

It's a true issue indeed, although it is not a defect looking at the way the "watched_by_me"-filter feature has been implemented in revision r2456 for feature #846; I've changed the tracker and subject accordingly.

#3 Updated by Mischa The Evil over 7 years ago

Added issue-relation to defect #4501. This feature once was available through URL-mangling.

I am not sure if this "hidden-feature" is available any longer in current Redmine source (read: quick test on rm.o didn't produced the described behaviour in defect #4501).

#4 Updated by Jean-Philippe Lang almost 5 years ago

  • Duplicated by Defect #15347: Issue filter does not allow filtering by any watcher except for "me" added

#5 Updated by Benjamin Roberts over 4 years ago

Has this really been a candidate for the next minor release for more than two years? It gets my vote if it makes a difference. =)

#6 Updated by Koen Boone over 4 years ago

We have 9 people here who also give their vote for this... :-/

#7 Updated by Plam Sim about 4 years ago

The same behavior we have in Redmine 2.5.1. Do you plan to fix it? Another watcher, except "me", cannot be added to the filter. In that case the filter "Watcher is" doesn't deliver its functionality.

#8 Updated by Kevin Palm about 4 years ago

+1

#9 Updated by Szabolcs Szasz over 3 years ago

+1

#10 Updated by Quan VN about 3 years ago

It seems that this behavior is intention since even with new update redmine 2.6.6 there is no change.
So if you want to change it here is the manual patch
In app/models/issue_query.rb, find the following lines

    if User.current.logged?
      add_available_filter "watcher_id",
        :type => :list, :values => [["<< #{l(:label_me)} >>", "me"]]
    end

remove them completely and replace with

    watcher_values = []
    watcher_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
    watcher_values += users.collect{|s| [s.name, s.id.to_s] }
    add_available_filter("watcher_id",
      :type => :list, :values => watcher_values
    ) unless watcher_values.empty?

Restart redmine and you have other members in the watcher list

#11 Updated by Go MAEDA over 2 years ago

#12 Updated by Aleksandar Pavic visit redminecookbook.com about 2 years ago

+1 (tested on 2.5.2 and 3.0.6.stable.14912)

#13 Updated by Alessandro Zucchi almost 2 years ago

Is possible have this fix in 3.3.2 version ?
It's a great limits
Thanks
Alessandro

#14 Updated by Immanuel Wilhelmy over 1 year ago

We use extended_watchers plugin to allow watchers restricted issue access. This feature would be extremely helpful to get an overview who can access (=is watching) which issue.
+1

Thanks
Immanuel.

#15 Updated by Go MAEDA 11 months ago

  • Duplicated by Defect #27123: Issue filter "watcher" dosn't show any users added

#16 Updated by Michael Schneider 10 months ago

I think this would be very useful.

+1

#17 Updated by Philippe Ivaldi 10 months ago

Michael Schneider wrote:

I think this would be very useful.

+1

+1 !

#18 Updated by Benjamim Rodrigo 9 months ago

+1

#19 Updated by Go MAEDA about 1 month ago

  • Category changed from Issues to Issues filter

#20 Updated by Mizuki ISHIKAWA about 1 month ago

By applying this patch, only user with :view_issue_watcher permission will be able to search for project members other than yourself.
This feature seems to be needed by many people.

#21 Updated by Alessandro Zucchi about 1 month ago

Come on, move it in 4.0! :-)
It's very usefull
Many thanks
Alessandro

#22 Updated by Go MAEDA about 1 month ago

Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?

  • I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter. :global => true in the User.current.allowed_to? should be removed.
  • In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.

#23 Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next minor release to Candidate for next major release

#24 Updated by Mizuki ISHIKAWA about 1 month ago

Go MAEDA wrote:

Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?

  • I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter. :global => true in the User.current.allowed_to? should be removed.
  • In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.

Fixed points you pointed out.
Thank you for checking.

#26 Updated by Marius BALTEANU about 1 month ago

LGTM, I'm in favour of delivering this feature in the next major version.

#28 Updated by Marius BALTEANU about 1 month ago

  • Related to deleted (Defect #4501: URL-mangling provides data not reachable through UI)

#29 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from Candidate for next major release to 4.0.0
  • Resolution set to Fixed

Committed.
Users who have "View issues list" (:view_issue_watchers) permission can see project members in the "Watchers" filter.

Also available in: Atom PDF