Feature #8160
Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Issues filter | |||
Target version: | 4.0.0 | |||
Resolution: | Fixed |
Description
When i try to use the watcher in the filter on issues, the list is only showing <<Me>>, so i can only filter issues watched by Me or not watched by Me.
Related issues
Associated revisions
Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution (#8160).
Patch by Mizuki ISHIKAWA.
History
#1
Updated by Etienne Massip almost 8 years ago
- Category set to Issues
- Target version set to Candidate for next minor release
Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.
#2
Updated by Mischa The Evil almost 8 years ago
- Tracker changed from Defect to Feature
- Subject changed from The watcher filter it's only showing <<Me>> in the list to Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution
Etienne Massip wrote:
Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.
It's a true issue indeed, although it is not a defect looking at the way the "watched_by_me"-filter feature has been implemented in revision r2456 for feature #846; I've changed the tracker and subject accordingly.
#3
Updated by Mischa The Evil almost 8 years ago
#4
Updated by Jean-Philippe Lang over 5 years ago
- Duplicated by Defect #15347: Issue filter does not allow filtering by any watcher except for "me" added
#5
Updated by Benjamin Roberts about 5 years ago
Has this really been a candidate for the next minor release for more than two years? It gets my vote if it makes a difference. =)
#6
Updated by Koen Boone about 5 years ago
We have 9 people here who also give their vote for this... :-/
#7
Updated by Plam Sim over 4 years ago
The same behavior we have in Redmine 2.5.1. Do you plan to fix it? Another watcher, except "me", cannot be added to the filter. In that case the filter "Watcher is" doesn't deliver its functionality.
#8
Updated by Kevin Palm over 4 years ago
+1
#9
Updated by Szabolcs Szasz almost 4 years ago
+1
#10
Updated by Quan VN over 3 years ago
It seems that this behavior is intention since even with new update redmine 2.6.6 there is no change.
So if you want to change it here is the manual patch
In app/models/issue_query.rb, find the following lines
if User.current.logged?
add_available_filter "watcher_id",
:type => :list, :values => [["<< #{l(:label_me)} >>", "me"]]
end
remove them completely and replace with
watcher_values = []
watcher_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
watcher_values += users.collect{|s| [s.name, s.id.to_s] }
add_available_filter("watcher_id",
:type => :list, :values => watcher_values
) unless watcher_values.empty?
Restart redmine and you have other members in the watcher list
#11
Updated by Go MAEDA about 3 years ago
- Duplicated by Feature #10912: Add search by watcher added
#12
Updated by Aleksandar Pavic visit redminecookbook.com over 2 years ago
+1 (tested on 2.5.2 and 3.0.6.stable.14912)
#13
Updated by Alessandro Zucchi over 2 years ago
Is possible have this fix in 3.3.2 version ?
It's a great limits
Thanks
Alessandro
#14
Updated by Immanuel Wilhelmy about 2 years ago
We use extended_watchers plugin to allow watchers restricted issue access. This feature would be extremely helpful to get an overview who can access (=is watching) which issue.
+1
Thanks
Immanuel.
#15
Updated by Go MAEDA over 1 year ago
- Duplicated by Defect #27123: Issue filter "watcher" dosn't show any users added
#16
Updated by Michael Schneider over 1 year ago
I think this would be very useful.
+1
#17
Updated by Philippe Ivaldi over 1 year ago
Michael Schneider wrote:
I think this would be very useful.
+1
+1 !
#18
Updated by Benjamim Rodrigo about 1 year ago
+1
#20
Updated by Mizuki ISHIKAWA 8 months ago
- File Add_filter_value_of_watcher.patch
added
By applying this patch, only user with :view_issue_watcher permission will be able to search for project members other than yourself.
This feature seems to be needed by many people.
#21
Updated by Alessandro Zucchi 8 months ago
Come on, move it in 4.0! :-)
It's very usefull
Many thanks
Alessandro
#22
Updated by Go MAEDA 8 months ago
Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?
- I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter.
:global => true
in theUser.current.allowed_to?
should be removed. - In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.
#24
Updated by Mizuki ISHIKAWA 8 months ago
- File Add_filter_value_of_watcher_v2.patch
added
Go MAEDA wrote:
Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?
- I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter.
:global => true
in theUser.current.allowed_to?
should be removed.- In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.
Fixed points you pointed out.
Thank you for checking.
#26
Updated by Marius BALTEANU 8 months ago
LGTM, I'm in favour of delivering this feature in the next major version.
#28
Updated by Marius BALTEANU 8 months ago
- Related to deleted (Defect #4501: URL-mangling provides data not reachable through UI)
#29
Updated by Go MAEDA 7 months ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from Candidate for next major release to 4.0.0
- Resolution set to Fixed
Committed.
Users who have "View issues list" (:view_issue_watchers) permission can see project members in the "Watchers" filter.