Defect #8759
closed
Setting issue attributes from mail should be case-insensitive
0%
Description
Currently, when you want to set issue attribute, e.g. Status, from mail you would add (in the mail body):
Status: Closed
The attribute name can be set in either case: status, STATUS, etc., but it fails to recognize the attribute value unless it's set in title-case, i.e. exactly as it appears in web interface.
The attached patch fixes this problem by titleizeing certain attribute values extracted from the mail body.
Files
Updated by Etienne Massip almost 13 years ago
- Target version set to Candidate for next minor release
Updated by Jean-Philippe Lang almost 13 years ago
- Status changed from New to Closed
- Target version changed from Candidate for next minor release to 1.2.1
- Resolution set to Fixed
Fixed in r6199.
This patch assumes that values are titleized in the database which may not be the case. The fix uses a different approach based on reusable scopes and applies to priorities and categories as well.
Updated by Alex Shulgin almost 13 years ago
Jean-Philippe Lang wrote:
Fixed in r6199.
This patch assumes that values are titleized in the database which may not be the case. The fix uses a different approach based on reusable scopes and applies to priorities and categories as well.
Thank you! I've had the feeling that my approach can be improved, but didn't know where to look exactly.
Btw, aren't we making code less DRY with all these named_scope :named, ...? Can be extracted in a module for sure.
Updated by Jean-Philippe Lang almost 13 years ago
Alex Shulgin wrote:
Btw, aren't we making code less DRY with all these
named_scope :named, ...? Can be extracted in a module for sure.
Indeed.