Defect #8825

JRuby + Windows: SCMs do not work on Redmine 1.2

Added by Toshi MARUYAMA over 6 years ago. Updated over 6 years ago.

Status:ClosedStart date:2011-07-15
Priority:NormalDue date:
Assignee:Toshi MARUYAMA% Done:

0%

Category:SCM
Target version:1.2.2
Resolution:Fixed Affected version:1.2.0

Description

SCMs on Redmine 1.1 work fine (some tests fail).
SCMs on Redmine 1.2 on CRuby + Windows work fine, too.

But, SCMs on Redmine 1.2 on JRuby + Windows does not work due to 1.2 new feature #7517.

R:\work\hg-workdir\redmine-all>jruby --version
jruby 1.6.2 (ruby-1.8.7-p330) (2011-05-23 e2ea975)
(Java HotSpot(TM) Client VM 1.6.0_23) [Windows Vista-x86-java]

Mercurial, Git and CVS

All tests fail with following error message.

In Japanese:
ファイル名、ディレクトリ名、またはボリューム ラベルの構文が間違っています。

Translation to English:
Filename, directory name, or volume label syntax is incorrect.

Subversion and Darcs

It seems that feature #7517 does not work on JRuby + Windows.

Bazaar

Same with Subversion and Darcs on 1.2 stable.
But trunk does not work.
Because refactoring has started after r5890.

gem version on Redmine 1.1

R:\work\hg-workdir\redmine-all>gem --version
1.5.1

You need to apply jruby-gem-redmine-1.1.diff

jruby-gem-redmine-1.1.diff Magnifier (675 Bytes) Toshi MARUYAMA, 2011-07-15 13:27


Related issues

Related to Redmine - Feature #7517: Configurable path of executable for scm adapters Closed 2011-02-02
Related to Redmine - Defect #9061: JRuby + Windows: CVS does not work New 2011-08-16
Related to Redmine - Defect #9073: JRuby + Windows: Bazaar does not work New 2011-08-17
Related to Redmine - Feature #12228: JRuby 1.7.2 support Closed

Associated revisions

Revision 6272
Added by Toshi MARUYAMA over 6 years ago

scm: add new method "shell_quote_command" at abstract adapter (#8825).

Revision 6273
Added by Toshi MARUYAMA over 6 years ago

Merge(backport) r6230 from trunk (#8825).

scm: catch all exceptions at adapter shellout() to fork scm command.

If scm command does not exist,
Linux JRuby 1.6.2 (ruby-1.8.7-p330) raises java.io.IOException in production environment.

Revision 6274
Added by Toshi MARUYAMA over 6 years ago

scm: subversion: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).

Revision 6275
Added by Toshi MARUYAMA over 6 years ago

scm: darcs: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).

Revision 6276
Added by Toshi MARUYAMA over 6 years ago

scm: cvs: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).

Revision 6277
Added by Toshi MARUYAMA over 6 years ago

scm: cvs: use self.class.sq_bin for command name at adpter scm_cmd() (#8825).

Revision 6278
Added by Toshi MARUYAMA over 6 years ago

scm: mercurial: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).

Revision 6279
Added by Toshi MARUYAMA over 6 years ago

scm: mercurial: use self.class.sq_bin for command name at adpter scm_cmd() (#8825).

Revision 6280
Added by Toshi MARUYAMA over 6 years ago

scm: git: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).

Revision 6281
Added by Toshi MARUYAMA over 6 years ago

scm: git: use self.class.sq_bin for command name at adpter scm_cmd() (#8825).

Revision 6282
Added by Toshi MARUYAMA over 6 years ago

scm: bazaar: use "shell_quote_command" method at adapter for JRuby + Windows command name (#8825).

Revision 6283
Added by Toshi MARUYAMA over 6 years ago

scm: bazaar: use self.class.sq_bin for command name at adpter scm_cmd() (#8825).

Revision 6284
Added by Toshi MARUYAMA over 6 years ago

scm: bazaar: use self.class.sq_bin for command name at adpter scm_cmd_no_raise() (#8825).

Revision 6447
Added by Toshi MARUYAMA over 6 years ago

scm: add comment that configuration of SCM executable command does not work if contains spaces path to configuration.yml.example (#7517, #8825).

Revision 6453
Added by Toshi MARUYAMA over 6 years ago

Merge r6021 from trunk (#8825).

scm: fix JRuby tests fail in unit changeset following test.

  • test_invalid_utf8_sequences_in_paths_should_be_replaced

Following Subversion functional tests fail on Japanese Windows + JRuby 1.6.2 (ruby-1.8.7-p330).

  • test_directory_diff
  • test_revision_diff

History

#1 Updated by alvis lee over 6 years ago

+1

#2 Updated by Toshi MARUYAMA over 6 years ago

  • Status changed from New to Closed
  • Target version set to 1.2.2
  • Resolution set to Fixed

As I described at r6447 comment and source:trunk/config/configuration.yml.example@6447#L115, scm command path which contains spaces does not work.

CVS and Bazaar do not work.
I created new issues.

Other scms pass tests.

Also available in: Atom PDF