LDAP timeout if an LDAP auth provider is unreachable
|Assignee:||Jean-Philippe Lang||% Done:|
we are using Redmine with a like 3 different LDAP auth sources, and sometimes if one of the goes down, almsot every process involved with Redmine slow down terribly.
It seems that when some use rtry to log in, Redmien try to contact the server that's not responding, waiting indefinitely for the action to be completed, making everything slow. There should be a (configurable perhaps?) timeout (I think that a sane default could be 30 seconds), and then the LDAP source should be considered dead (at least for that request).
i'm using Redmine 1.1.2.stable.5317
#2 Updated by Brett Patterson over 6 years ago
I can confirm this happens in 2.0.3 as well. We used to use LDAP to authenticate and when we took our LDAP system offline I forgot some users were still configured and instead of seeing a message about unable to log in or LDAP authentication server unreachable, it gave a 500 error.
#3 Updated by Brett Patterson over 6 years ago
- File ldap_timeout-v2.0.3.patch added
Here's a quick patch I made against 2.0.3. This will catch a timeout error after 30 seconds and redirect the user with a proper error message. This is english only and really is a proof-of-concept. Ideally the timeout would default to 30 seconds but could be modified via the administration settings (or per-LDAP definition).
Perhaps the Timeout class is not the best solution in this case; however, from my testing it works.
#5 Updated by Brett Patterson over 6 years ago
- File ldap_timeout_v2-redmine2.0.3.patch added
Worked on it some more and now the timeout is configurable on a per-connection basis in the LDAP settings. If no timeout value is set, the default of 20 is set.
In order to use this, the following SQL must be run:
ALTER TABLE `auth_sources` ADD COLUMN `timeout` int(11) DEFAULT NULL AFTER `port`;