Patch #9037

Setting labels should be connected to their fields

Added by Alex Shulgin over 6 years ago. Updated about 3 years ago.

Status:ClosedStart date:2011-08-11
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

Attached patches fix two problems:

1. In Admin > Settings, labels were not connected to their fields.
2. The checkbox label didn't work because of the hidden helper field was having the same id as the checkbox.

There're also a couple of checkboxes under Settings > Repositories, which do not have labels at all (only text): you have to click at the checkbox itself to (un)mark it. I've tried to use labels there, but the CSS appears to be too messy to make this work: the labels get rendered behind the left edge of the screen...

0001-Fixed-setting_label-use-for-HTML-attribute.patch Magnifier (973 Bytes) Alex Shulgin, 2011-08-11 09:56

0002-Fixed-clickable-checkbox-labels-clear-id-attr-on-the.patch Magnifier (4.16 KB) Alex Shulgin, 2011-08-11 09:56


Related issues

Related to Redmine - Patch #11496: Make labels clickable in Adminstration/Settings Closed

History

#1 Updated by Go MAEDA about 3 years ago

Duplicated by #11496 and the improvements have been done in Redmine 2.1.
This issue can be closed.

#2 Updated by Go MAEDA about 3 years ago

  • Related to Patch #11496: Make labels clickable in Adminstration/Settings added

#3 Updated by Go MAEDA about 3 years ago

  • Status changed from New to Closed

Also available in: Atom PDF