Issue view does not show spent time if hours are zero
If I add a time entry of 0 hours and nothing else has been logged on an issue spent time is shown as "Spent time: -".
It would be more natural if it showed 0 hours and had the normal link for showing logged time on the issue.
#1 Updated by Marius BALTEANU 11 months ago
- File do_not_allow_spent_time_with_0_hours.patch added
Currently, you can add a spent time with 0 hours which is shown in time_entries#index, but not in the issue page (the defect reported in this ticket).
Because I don't see any real reason to allows spent time with 0 hours, I made a patch that restricts this.
#3 Updated by Jean-Philippe Lang 11 months ago
- Target version deleted (
Go MAEDA wrote:
The existing code source:tags/3.3.3/app/models/time_entry.rb#L120 obviously intends not to accept 0. Setting target version to 3.4.0.
No, this code intends not to accept negative values. Some people might use time entries with 0 hours for specific purpose, I'm not really in favor of removing this possibility. We need more feedback before doing this change.