Defect #1436

Bad rendering on projects/add

Added by Pierre Paysant-Le Roux 116 days ago. Updated 115 days ago.

Status:Closed Start:2008-06-12
Priority:Normal Due date:
Assigned to:- % Done:

0%
Category:UI
Target version:0.7.2
Affected version:

 Resolution:

Fixed

Description

  • Go to /projects/add (must be admin) (note that the page has no title)
  • Enter only in the form
  • Click save button

Error are reported and the page is scrambled. Observed on Firefox 2 and 3.

A workaround is to replace this line of app/views/layouts/base.rhtml
<h1><%= h(@project ? @project.name : Setting.app_title) %></h1>
by this one
<h1><%= h((@project and !@project.name.blank?) ? @project.name : Setting.app_title) %></h1>

Associated revisions

Revision 1526
Added by jplang 115 days ago

Fixed: page has no title when adding a project (#1436).

History

2008-06-12 17:15 - Pierre Paysant-Le Roux

  • Enter only in the form
    is
  • Enter only a name in the form

2008-06-14 13:14 - Jean-Philippe Lang

I couldn't reproduce the problem. But the page has no title indeed, when adding a new project.
I've applied a different fix in r1526 (display the project name only after it was saved).
Can you confirm it's OK ?

2008-06-14 15:23 - Pierre Paysant-Le Roux

  • Status changed from New to Resolved

r1526 solved this issue.

2008-06-14 16:07 - Jean-Philippe Lang

  • Status changed from Resolved to Closed
  • Target version set to 0.7.2
  • Resolution set to Fixed

Thanks.

Also available in: Atom PDF