<?xml version="1.0" encoding="UTF-8"?>
<issue>
  <id>2025</id>
  <project name="Redmine" id="1"/>
  <tracker name="Patch" id="3"/>
  <status name="Closed" id="5"/>
  <priority name="Normal" id="4"/>
  <author name="Yuki Sonoda" id="1249"/>
  <category name="Wiki" id="1"/>
  <fixed_version name="0.8" id="2"/>
  <subject>Pluggable wiki formatter</subject>
  <description>This patch makes wiki formatting pluggable.

You can add a new wiki formatting as a plugin. For example, I wrote "RD plugin":http://github.com/yugui/remine_rd_formatter. This provides redmine with "Ruby Document Format":http://en.wikipedia.org/wiki/Ruby_Document_format, which is the format "Ruby Issue Tracking System":http://redmine.ruby-lang.org uses.

h2. textile plugin

In the patch [[attachment:make-wiki-formatters-pluggable.patch]], textile formatter is still embedded in Redmine.
But it is possible to extract the embedded textile formatting from redmine. [[attachment:extract-textile-formatting-as-a-plugin.patch]] does this. Perhaps, this patch needs git-am(1) because it renames some files.</description>
  <start_date>2008-10-12</start_date>
  <due_date></due_date>
  <done_ratio>0</done_ratio>
  <estimated_hours></estimated_hours>
  <created_on>Sun Oct 12 05:19:55 +0200 2008</created_on>
  <updated_on>Sun Nov 09 13:18:01 +0100 2008</updated_on>
  <changesets>
    <changeset revision="1955">
      <user name="Jean-Philippe Lang" id="1"/>
      <comments>Makes wiki text formatter pluggable.
Original patch #2025 by Yuki Sonoda slightly edited.</comments>
      <committed_on>Mon Oct 27 12:08:29 +0100 2008</committed_on>
    </changeset>
  </changesets>
  <journals>
    <journal id="5116">
      <user name="Yuki Sonoda" id="1249"/>
      <notes>Oops, URL for my RD plugin was wrong. It is http://github.com/yugui/redmine_rd_formatter.</notes>
      <details>
      </details>
    </journal>
    <journal id="5156">
      <user name="James Turnbull" id="851"/>
      <notes>+1.</notes>
      <details>
      </details>
    </journal>
    <journal id="5309">
      <user name="Jean-Philippe Lang" id="1"/>
      <notes>This nice feature which is committed in r1955 with minor changes.

One thing concerning your RD plugin:
I removed the jstoolbar stylesheet include tag from the base layout so that plugins can use other libraries to render the toolbar. So, you'll have to add it in @#heads_for_wiki_formatter@. It would look like this:

&lt;pre&gt;
def heads_for_wiki_formatter
  stylesheet_link_tag('jstoolbar') +
  stylesheet_link_tag('rd', :plugin =&gt; 'redmine_rd_formatter')
end
&lt;/pre&gt;

Your plugin was tested OK with this change.

Concerning your second patch, I prefer to keep the Textile formatter bundled in the app because I don't want to rely on Engines' mirror files mechanism for such a core functionality.

Thanks.</notes>
      <details>
        <detail old="1" name="status_id" property="attr" new="5"/>
        <detail old="" name="fixed_version_id" property="attr" new="2"/>
      </details>
    </journal>
    <journal id="5465">
      <user name="Yuki Sonoda" id="1249"/>
      <notes>Thank you, Jean-Phillipe. I committed the change you suggested into http://github.com/yugui/redmine_rd_formatter/tree/master.

And I think this plugin can show the best example of wiki formatter implementation for plugin developers. Could you add the plugin to http://www.redmine.org/wiki/redmine/Plugins ? </notes>
      <details>
      </details>
    </journal>
    <journal id="5468">
      <user name="Jean-Philippe Lang" id="1"/>
      <notes>Indeed, a link to your plugin was added to the plugin list.</notes>
      <details>
      </details>
    </journal>
  </journals>
</issue>
