Redmine

I see 2 solutions:
- change the 2 database columns to 'text' (instead
of varchar255)
- truncate the values (as you did in your patch)

Do you need to have the full length value in the history ?

I would go for the truncation, don't think has a real value having
a very long
decription in the history and also depending on the database
implementation
having text field rather than varchar(255) could increase
drammatically the size
of the journal table.

Thanks,
Amedeo

I agree with you. I'll fix this way.
Thanks.

I've just tested this. I get no errors and text is automaticaly
truncated and correctly saved.

Could tell me what version of rails and database you're using ?

Rails 1.2.2 and PostgreSQL 8.1.4

The error I get is something like:

RuntimeError: ERROR C22001 Mvalue too long for type character
varying(255) Fvarchar.c L539 Rvarchar: INSERT INTO journal_details
("old_value", "property", "value",
"journal_id", "prop_key") VALUES('', 'cf',
'Lorem ipsum dolor sit amet

This problem doesn't occur with mysql. But I could reproduce
it after swithing to Postgresql.

Fixed in rev 477.

Thanks for the prompt action :)