Patch #26130

Updated by Go MAEDA about 1 year ago

Hi,

In the "IssuesHelper#details_to_strings":/projects/redmine/repository/entry/trunk/app/helpers/issues_helper.rb method (source:trunk/app/helpers/issues_helper.rb@16387#L373) (issues_helper.rb:373) a new class (Struct) is created each time the method is called:

multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)

Although classes are garbage collected in recent Ruby versions, it might be better to use a constant definition outside the method, like:

MultipleValuesDetail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)

Regards,
Thomas

Back