Patch #26130

Updated by Toshi MARUYAMA about 1 year ago

Hi,

In the "IssuesHelper#details_to_strings":/projects/redmine/repository/entry/trunk/app/helpers/issues_helper.rb method (source:trunk/app/helpers/issues_helper.rb@16387#L373) a new class (Struct) is created each time the method is called:

<pre><code class="ruby">


multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
</code></pre>


Although classes are garbage collected in recent Ruby versions, it might be better to use a constant definition outside the method, like:

<pre><code class="ruby">


MultipleValuesDetail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
</code></pre>


Regards,
Thomas

Back