diff --git app/controllers/journals_controller.rb app/controllers/journals_controller.rb index a0905ae..4885f47 100644 --- app/controllers/journals_controller.rb +++ app/controllers/journals_controller.rb @@ -90,7 +90,10 @@ class JournalsController < ApplicationController def update (render_403; return false) unless @journal.editable_by?(User.current) - @journal.update_attributes(:notes => params[:notes]) if params[:notes] + @journal.notes = params[:notes] if params[:notes] + @journal.private_notes = params[:private_notes] if params[:private_notes] + (render_403; return false) if @journal.private_notes_changed? && User.current.allowed_to?(:set_notes_private, @journal.issue.project) == false + @journal.save if @journal.changed? @journal.destroy if @journal.details.empty? && @journal.notes.blank? call_hook(:controller_journals_edit_post, { :journal => @journal, :params => params}) respond_to do |format| diff --git app/helpers/journals_helper.rb app/helpers/journals_helper.rb index f9dc7c9..e31ad25 100644 --- app/helpers/journals_helper.rb +++ app/helpers/journals_helper.rb @@ -58,4 +58,10 @@ module JournalsHelper css_classes << " editable" if editable content_tag('div', content.html_safe, :id => "journal-#{journal.id}-notes", :class => css_classes) end + + def render_private_notes(journal) + content = journal.private_notes? ? l(:field_is_private) : '' + css_classes = journal.private_notes? ? 'private' : '' + content_tag('span', content.html_safe, :id => "journal-#{journal.id}-private_notes", :class => css_classes) + end end diff --git app/views/issues/_history.html.erb app/views/issues/_history.html.erb index 993dfee..b184e01 100644 --- app/views/issues/_history.html.erb +++ app/views/issues/_history.html.erb @@ -5,7 +5,7 @@

#<%= journal.indice %> <%= avatar(journal.user, :size => "24") %> <%= authoring journal.created_on, journal.user, :label => :label_updated_time_by %> - <%= content_tag('span', l(:field_is_private), :class => 'private') if journal.private_notes? %>

+ <%= render_private_notes(journal) %> <% if journal.details.any? %>