diff --git a/app/helpers/timelog_helper.rb b/app/helpers/timelog_helper.rb old mode 100644 new mode 100755 diff --git a/app/views/timelog/_form.html.erb b/app/views/timelog/_form.html.erb old mode 100644 new mode 100755 index ebd9d39..5409ee9 --- a/app/views/timelog/_form.html.erb +++ b/app/views/timelog/_form.html.erb @@ -13,9 +13,9 @@ <% end %>

<%= f.text_field :issue_id, :size => 6 %> - <% if @time_entry.issue.try(:visible?) %> - <%= "#{@time_entry.issue.tracker.name} ##{@time_entry.issue.id}: #{@time_entry.issue.subject}" %> - <% end %> + + <%= link_to_issue(@time_entry.issue) if @time_entry.issue.try(:visible?) %> +

<%= f.date_field :spent_on, :size => 10, :required => true %><%= calendar_for('time_entry_spent_on') %>

<%= f.text_field :hours, :size => 6, :required => true %>

diff --git a/app/views/timelog/new.js.erb b/app/views/timelog/new.js.erb old mode 100644 new mode 100755 index f76cbb8..4cba8cf --- a/app/views/timelog/new.js.erb +++ b/app/views/timelog/new.js.erb @@ -1 +1,2 @@ $('#time_entry_activity_id').html('<%= escape_javascript options_for_select(activity_collection_for_select_options(@time_entry), @time_entry.activity_id) %>'); +$('#time_entry_issue').html('<%= escape_javascript link_to_issue(@time_entry.issue) if @time_entry.issue.try(:visible?) %>'); diff --git a/test/functional/timelog_controller_test.rb b/test/functional/timelog_controller_test.rb old mode 100644 new mode 100755 index b392a13..6af8301 --- a/test/functional/timelog_controller_test.rb +++ b/test/functional/timelog_controller_test.rb @@ -35,6 +35,7 @@ class TimelogControllerTest < Redmine::ControllerTest assert_select 'input[name=?][type=hidden]', 'project_id', 0 assert_select 'input[name=?][type=hidden]', 'issue_id', 0 + assert_select 'span[id=?]', 'time_entry_issue' assert_select 'select[name=?]', 'time_entry[project_id]' do # blank option for project assert_select 'option[value=""]' @@ -58,6 +59,7 @@ class TimelogControllerTest < Redmine::ControllerTest assert_select 'input[name=?][type=hidden]', 'project_id', 0 assert_select 'input[name=?][type=hidden]', 'issue_id' + assert_select 'a[href=?]', '/issues/2', :text => /Feature request #2/ assert_select 'select[name=?]', 'time_entry[project_id]', 0 end @@ -249,7 +251,7 @@ class TimelogControllerTest < Redmine::ControllerTest end assert_select_error /Issue is invalid/ assert_select "input[name=?][value=?]", "time_entry[issue_id]", issue.id.to_s - assert_select "#time_entry_issue", 0 + assert_select "#time_entry_issue a", 0 assert !response.body.include?('issue_that_is_not_visible') end @@ -501,7 +503,7 @@ class TimelogControllerTest < Redmine::ControllerTest assert_select 'form#bulk_edit_form[action=?]', '/time_entries/bulk_update' do # System wide custom field assert_select 'select[name=?]', 'time_entry[custom_field_values][10]' - + # Activities assert_select 'select[name=?]', 'time_entry[activity_id]' do assert_select 'option[value=""]', :text => '(No change)' @@ -549,7 +551,7 @@ class TimelogControllerTest < Redmine::ControllerTest @request.session[:user_id] = 2 # makes user a manager on the other project Member.create!(:user_id => 2, :project_id => 3, :role_ids => [1]) - + # update time entry activity post :bulk_update, :params => {:ids => [1, 2, 4], :time_entry => { :activity_id => 9 }} @@ -677,9 +679,9 @@ class TimelogControllerTest < Redmine::ControllerTest def test_index_at_project_level get :index, :params => {:project_id => 'ecookbook', :c => ['project']} assert_response :success - + assert_select 'tr.time-entry', 4 - + # project and subproject projects = css_select('table.time-entries tbody td.project').map(&:text).uniq.sort assert_equal ["eCookbook", "eCookbook Subproject 1"], projects @@ -959,7 +961,7 @@ class TimelogControllerTest < Redmine::ControllerTest def test_index_at_project_level_should_include_csv_export_dialog get :index, :params => { - :project_id => 'ecookbook', + :project_id => 'ecookbook', :f => ['spent_on'], :op => {'spent_on' => '>='}, :v => {'spent_on' => ['2007-04-01']},