From 6827ec655ec296eeb7b6a1e6f9d24a9ee17d823f Mon Sep 17 00:00:00 2001 From: Jens Kraemer Date: Tue, 16 May 2017 07:12:54 +0800 Subject: [PATCH 1/2] adds failing test case for import with wrong encoding (UndefinedConversionError) --- test/fixtures/files/invalid-Shift_JIS.csv | 1 + test/functional/imports_controller_test.rb | 11 +++++++++++ 2 files changed, 12 insertions(+) create mode 100644 test/fixtures/files/invalid-Shift_JIS.csv diff --git a/test/fixtures/files/invalid-Shift_JIS.csv b/test/fixtures/files/invalid-Shift_JIS.csv new file mode 100644 index 0000000..bc54989 --- /dev/null +++ b/test/fixtures/files/invalid-Shift_JIS.csv @@ -0,0 +1 @@ +‡@ \ No newline at end of file diff --git a/test/functional/imports_controller_test.rb b/test/functional/imports_controller_test.rb index 3b271b0..28ce703 100644 --- a/test/functional/imports_controller_test.rb +++ b/test/functional/imports_controller_test.rb @@ -102,6 +102,17 @@ class ImportsControllerTest < Redmine::ControllerTest assert_select 'div#flash_error', /not a valid UTF-8 encoded file/ end + def test_post_settings_with_invalid_encoding_should_display_error + import = generate_import('invalid-Shift_JIS.csv') + + post :settings, :id => import.to_param, + :import_settings => {:separator => ";", :wrapper => '"', :encoding => "Shift_JIS"} + assert_response 200 + import.reload + assert_nil import.total_items + assert_select 'div#flash_error', /not a valid Shift_JIS encoded file/ + end + def test_get_mapping_should_display_mapping_form import = generate_import('import_iso8859-1.csv') import.settings = {'separator' => ";", 'wrapper' => '"', 'encoding' => "ISO-8859-1"} -- 2.1.4