From d0c0bcf805fb67dfa10c4db5255908eee657f305 Mon Sep 17 00:00:00 2001
From: Jens Kraemer <jk@jkraemer.net>
Date: Fri, 27 Jul 2018 15:58:34 +0800
Subject: [PATCH 1/3] attachments prev/next navigation

---
 app/controllers/attachments_controller.rb      |  8 ++++++++
 app/helpers/attachments_helper.rb              |  8 ++++++++
 app/views/layouts/_file.html.erb               |  4 ++++
 public/stylesheets/application.css             |  4 ++++
 test/functional/attachments_controller_test.rb | 10 ++++++++++
 5 files changed, 34 insertions(+)

diff --git a/app/controllers/attachments_controller.rb b/app/controllers/attachments_controller.rb
index 1b18662ad..9c0bf15ba 100644
--- a/app/controllers/attachments_controller.rb
+++ b/app/controllers/attachments_controller.rb
@@ -32,6 +32,14 @@ class AttachmentsController < ApplicationController
   def show
     respond_to do |format|
       format.html {
+        if @attachment.container.respond_to?(:attachments)
+          @attachments = @attachment.container.attachments.to_a
+          if index = @attachments.index(@attachment)
+            @paginator = Redmine::Pagination::Paginator.new(
+              @attachments.size, 1, index+1
+            )
+          end
+        end
         if @attachment.is_diff?
           @diff = File.read(@attachment.diskfile, :mode => "rb")
           @diff_type = params[:type] || User.current.pref[:diff_type] || 'inline'
diff --git a/app/helpers/attachments_helper.rb b/app/helpers/attachments_helper.rb
index 36cf0d4fe..385f3b8a4 100644
--- a/app/helpers/attachments_helper.rb
+++ b/app/helpers/attachments_helper.rb
@@ -56,6 +56,14 @@ module AttachmentsHelper
     end
   end
 
+  def render_pagination
+    pagination_links_each @paginator do |text, parameters, options|
+      if att = @attachments[parameters[:page] - 1]
+        link_to text, named_attachment_path(att, att.filename)
+      end
+    end if @paginator
+  end
+
   def render_api_attachment(attachment, api, options={})
     api.attachment do
       render_api_attachment_attributes(attachment, api)
diff --git a/app/views/layouts/_file.html.erb b/app/views/layouts/_file.html.erb
index 3b225508b..8ffadf703 100644
--- a/app/views/layouts/_file.html.erb
+++ b/app/views/layouts/_file.html.erb
@@ -12,6 +12,10 @@
 </div>
 <%= yield %>
 
+<span class="pagination">
+  <%= render_pagination %>
+</span>
+
 <% html_title @attachment.filename %>
 
 <% content_for :header_tags do -%>
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index 6abf7788c..4df53686c 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -668,6 +668,10 @@ span.pagination {margin-left:3px; color:#888; display:block;}
   font-weight: bold;
 }
 span.pagination>span {white-space:nowrap;}
+.controller-attachments.action-show span.pagination{
+  display: block;
+  margin-top: 1.2em;
+}
 
 #search-form fieldset p {margin:0.2em 0;}
 
diff --git a/test/functional/attachments_controller_test.rb b/test/functional/attachments_controller_test.rb
index 016ed28fa..a5d4c1705 100644
--- a/test/functional/attachments_controller_test.rb
+++ b/test/functional/attachments_controller_test.rb
@@ -287,6 +287,16 @@ class AttachmentsControllerTest < Redmine::ControllerTest
     assert_response 404
   end
 
+  def test_show_renders_pagination
+    get :show, :params => { :id => 5, :type => 'inline' }
+    assert_response :success
+
+    assert_select 'ul.pages li.next', :text => /next/i
+    assert_select 'ul.pages li.previous', :text => /previous/i
+
+    set_tmp_attachments_directory
+  end
+
   def test_download_text_file
     get :download, :params => {
         :id => 4
-- 
2.11.0