From 3be81b344e163f6a1a9d7540bf160c538c31e3f3 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Sun, 11 Oct 2020 12:58:03 +0000 Subject: add more assert_equal to IssuesSystemTest#test_bulk_copy git-svn-id: http://svn.redmine.org/redmine/trunk@20145 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- test/system/issues_test.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/system/issues_test.rb b/test/system/issues_test.rb index e78a610c0..046088751 100644 --- a/test/system/issues_test.rb +++ b/test/system/issues_test.rb @@ -441,6 +441,8 @@ class IssuesSystemTest < ApplicationSystemTestCase click_link 'Copy' end assert_current_path '/issues/bulk_edit', :ignore_query => true + submit_buttons = page.all('input[type=submit]') + assert_equal 'Copy', submit_buttons[0].value page.find('#issue_project_id').select('OnlineStore') # wait for ajax response -- 2.17.1 From e038a1af8917ea0f3aadc66e4aa3c777b11291cf Mon Sep 17 00:00:00 2001 From: Paolo Granada Lim Date: Tue, 13 Oct 2020 16:14:18 +0800 Subject: Fix migration rubocop offenses --- db/migrate/20190510070108_add_unique_id_to_import_items.rb | 2 +- db/migrate/20200826153402_add_totp_to_user.rb | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/db/migrate/20190510070108_add_unique_id_to_import_items.rb b/db/migrate/20190510070108_add_unique_id_to_import_items.rb index d1b423692..e15861b89 100644 --- a/db/migrate/20190510070108_add_unique_id_to_import_items.rb +++ b/db/migrate/20190510070108_add_unique_id_to_import_items.rb @@ -1,6 +1,6 @@ class AddUniqueIdToImportItems < ActiveRecord::Migration[5.2] def change - change_table :import_items do |t| + change_table :import_items, bulk: true do |t| t.string "unique_id" t.index ["import_id", "unique_id"] end diff --git a/db/migrate/20200826153402_add_totp_to_user.rb b/db/migrate/20200826153402_add_totp_to_user.rb index 6842878e3..c284818a1 100644 --- a/db/migrate/20200826153402_add_totp_to_user.rb +++ b/db/migrate/20200826153402_add_totp_to_user.rb @@ -1,6 +1,8 @@ class AddTotpToUser < ActiveRecord::Migration[5.2] def change - add_column :users, :twofa_totp_key, :string - add_column :users, :twofa_totp_last_used_at, :integer + change_table :users, bulk: true do |t| + t.string :twofa_totp_key + t.integer :twofa_totp_last_used_at + end end end -- 2.17.1