From 82baf9c074664d6d15fb404309b0307c3965852c Mon Sep 17 00:00:00 2001 From: Frederico Camara Date: Sat, 20 Feb 2021 00:28:10 -0300 Subject: [PATCH] Subject is safe for new issue - bug: can't change tracker_id when leaving status where you can't change tracker_id --- app/models/issue.rb | 3 ++- app/views/issues/_form.html.erb | 5 ++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/issue.rb b/app/models/issue.rb index 3730e2931..0485cfde6 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -560,8 +560,9 @@ class Issue < ActiveRecord::Base names -= disabled_core_fields names -= read_only_attribute_names(user) if new_record? - # Make sure that project_id can always be set for new issues + # Make sure that project_id and subject can always be set for new issues names |= %w(project_id) + names |= %w(subject) end if dates_derived? names -= %w(start_date due_date) diff --git a/app/views/issues/_form.html.erb b/app/views/issues/_form.html.erb index fdf729140..11bd91804 100644 --- a/app/views/issues/_form.html.erb +++ b/app/views/issues/_form.html.erb @@ -15,7 +15,7 @@ :onchange => "updateIssueFrom('#{escape_javascript update_issue_form_path(@project, @issue)}', this)" %>

<% end %> -<% if @issue.safe_attribute?('tracker_id') || (@issue.persisted? && @issue.tracker_id_changed?) %> +<% if @issue.safe_attribute?('tracker_id') || (@issue.persisted? && @issue.tracker_id_changed?) || @issue.new_record? %>

<%= f.select :tracker_id, trackers_options_for_select(@issue), {:required => true}, :onchange => "updateIssueFrom('#{escape_javascript update_issue_form_path(@project, @issue)}', this)", @@ -24,8 +24,7 @@

<%= render partial: 'issues/trackers_description', locals: {trackers: trackers_for_select(@issue)} %> <% end %> - -<% if @issue.safe_attribute? 'subject' %> +<% if @issue.safe_attribute?('subject') || @issue.new_record? %>

<%= f.text_field :subject, :size => 80, :maxlength => 255, :required => true %>

<% end %> -- 2.25.1