From 33feaa6c980b9ceec151dd2fb760ff54f9b2cec1 Mon Sep 17 00:00:00 2001
From: Marius BALTEANU <marius.balteanu@zitec.com>
Date: Sun, 1 Aug 2021 17:25:33 +0300
Subject: [PATCH] Fixes that duplicated follows relation fails with 500
 internal error

---
 app/controllers/issue_relations_controller.rb |  9 ++++---
 .../issue_relations_controller_test.rb        | 25 +++++++++++++++++++
 2 files changed, 31 insertions(+), 3 deletions(-)

diff --git a/app/controllers/issue_relations_controller.rb b/app/controllers/issue_relations_controller.rb
index 52be512f1..8143f4f4a 100644
--- a/app/controllers/issue_relations_controller.rb
+++ b/app/controllers/issue_relations_controller.rb
@@ -56,10 +56,13 @@ class IssueRelationsController < ApplicationController
       @relation.safe_attributes = params_relation
       @relation.init_journals(User.current)
 
-      unless saved = @relation.save
-        saved = false
-        unsaved_relations << @relation
+      begin
+        saved = @relation.save
+      rescue ActiveRecord::RecordNotUnique
+        @relation.errors.add :base, :taken
       end
+
+      unsaved_relations << @relation unless saved
     end
 
     respond_to do |format|
diff --git a/test/functional/issue_relations_controller_test.rb b/test/functional/issue_relations_controller_test.rb
index b5ea6cb93..099254979 100644
--- a/test/functional/issue_relations_controller_test.rb
+++ b/test/functional/issue_relations_controller_test.rb
@@ -216,6 +216,31 @@ class IssueRelationsControllerTest < Redmine::ControllerTest
     assert_include 'Related issue cannot be blank', response.body
   end
 
+  def test_create_duplicated_follows_relations_should_not_raise_exception
+    IssueRelation.create(
+      :issue_from => Issue.find(1), :issue_to => Issue.find(2),
+      :relation_type => IssueRelation::TYPE_PRECEDES
+    )
+
+    assert_no_difference 'IssueRelation.count' do
+      post(
+        :create,
+        :params => {
+          :issue_id => 2,
+          :relation => {
+            :issue_to_id => 1,
+            :relation_type => 'follows',
+            :delay => ''
+          }
+        },
+        :xhr => true
+      )
+    end
+
+    assert_response :success
+    assert_include 'has already been taken', response.body
+  end
+
   def test_bulk_create_with_multiple_issue_to_id_issues
     assert_difference 'IssueRelation.count', +3 do
       post :create, :params => {
-- 
GitLab