From e5a4575f90c6797e84d8e890f48aa64cef77c289 Mon Sep 17 00:00:00 2001 From: MAEDA Go Date: Mon, 2 Jan 2023 16:27:32 +0900 Subject: [PATCH 1/9] Fix RuboCop offense Performance/AncestorsInclude --- .rubocop_todo.yml | 7 ------- test/unit/document_category_test.rb | 2 +- test/unit/issue_priority_test.rb | 2 +- test/unit/time_entry_activity_test.rb | 2 +- 4 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 6e7c678bf..332cb9abe 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -486,13 +486,6 @@ Naming/VariableNumber: - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' - 'test/unit/project_test.rb' -# This cop supports unsafe autocorrection (--autocorrect-all). -Performance/AncestorsInclude: - Exclude: - - 'test/unit/document_category_test.rb' - - 'test/unit/issue_priority_test.rb' - - 'test/unit/time_entry_activity_test.rb' - # This cop supports safe autocorrection (--autocorrect). Performance/BlockGivenWithExplicitBlock: Exclude: diff --git a/test/unit/document_category_test.rb b/test/unit/document_category_test.rb index 125c199ba..7ae3962ee 100644 --- a/test/unit/document_category_test.rb +++ b/test/unit/document_category_test.rb @@ -27,7 +27,7 @@ class DocumentCategoryTest < ActiveSupport::TestCase end def test_should_be_an_enumeration - assert DocumentCategory.ancestors.include?(Enumeration) + assert DocumentCategory <= Enumeration end def test_objects_count diff --git a/test/unit/issue_priority_test.rb b/test/unit/issue_priority_test.rb index efd58b718..ff192e317 100644 --- a/test/unit/issue_priority_test.rb +++ b/test/unit/issue_priority_test.rb @@ -49,7 +49,7 @@ class IssuePriorityTest < ActiveSupport::TestCase end def test_should_be_an_enumeration - assert IssuePriority.ancestors.include?(Enumeration) + assert IssuePriority <= Enumeration end def test_objects_count diff --git a/test/unit/time_entry_activity_test.rb b/test/unit/time_entry_activity_test.rb index bfbf534ab..09c984f28 100644 --- a/test/unit/time_entry_activity_test.rb +++ b/test/unit/time_entry_activity_test.rb @@ -37,7 +37,7 @@ class TimeEntryActivityTest < ActiveSupport::TestCase end def test_should_be_an_enumeration - assert TimeEntryActivity.ancestors.include?(Enumeration) + assert TimeEntryActivity <= Enumeration end def test_objects_count -- 2.39.0