From 41a9c7cd37fd3d1fcd04f176e6a58895e78384e0 Mon Sep 17 00:00:00 2001 From: MAEDA Go Date: Tue, 3 Jan 2023 14:47:30 +0900 Subject: [PATCH 8/9] Fix RuboCop offense Performance/RedundantSplitRegexpArgument --- .rubocop_todo.yml | 5 ----- lib/redmine/wiki_formatting/textile/redcloth3.rb | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b794a7124..9ff640eb4 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -486,11 +486,6 @@ Naming/VariableNumber: - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' - 'test/unit/project_test.rb' -# This cop supports safe autocorrection (--autocorrect). -Performance/RedundantSplitRegexpArgument: - Exclude: - - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: OnlySumOrWithInitialValue. Performance/Sum: diff --git a/lib/redmine/wiki_formatting/textile/redcloth3.rb b/lib/redmine/wiki_formatting/textile/redcloth3.rb index 77bfa0ab6..406fca08d 100644 --- a/lib/redmine/wiki_formatting/textile/redcloth3.rb +++ b/lib/redmine/wiki_formatting/textile/redcloth3.rb @@ -558,7 +558,7 @@ class RedCloth3 < String # Parses Textile lists and generates HTML def block_textile_lists( text ) text.gsub!( LISTS_RE ) do |match| - lines = match.split( /\n/ ) + lines = match.split( "\n" ) last_line = -1 depth = [] lines.each_with_index do |line, line_id| @@ -603,7 +603,7 @@ class RedCloth3 < String def block_textile_quotes( text ) text.gsub!( QUOTES_RE ) do |match| - lines = match.split( /\n/ ) + lines = match.split( "\n" ) quotes = +'' indent = 0 lines.each do |line| -- 2.39.0