From be73a946b73beedcf253c0e2d310e31840f0f838 Mon Sep 17 00:00:00 2001 From: asakura Date: Fri, 16 Jun 2023 03:12:02 +0000 Subject: Patch for 71642-fix-migration-file-name --- .../redmine_plugin_migration_generator.rb | 2 +- test/generators/migration_generator_test.rb | 50 +++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 test/generators/migration_generator_test.rb diff --git a/lib/generators/redmine_plugin_migration/redmine_plugin_migration_generator.rb b/lib/generators/redmine_plugin_migration/redmine_plugin_migration_generator.rb index 83f9b5e69..c0cd32676 100644 --- a/lib/generators/redmine_plugin_migration/redmine_plugin_migration_generator.rb +++ b/lib/generators/redmine_plugin_migration/redmine_plugin_migration_generator.rb @@ -34,6 +34,6 @@ class RedminePluginMigrationGenerator < Rails::Generators::NamedBase plugin_name = file_name.underscore plugin_path = File.join(Redmine::Plugin.directory, plugin_name) migration_template "migration.rb", - "#{plugin_path}/db/migrate/#{@migration}.rb" + "#{plugin_path}/db/migrate/#{@migration.underscore}.rb" end end diff --git a/test/generators/migration_generator_test.rb b/test/generators/migration_generator_test.rb new file mode 100644 index 000000000..101077cfa --- /dev/null +++ b/test/generators/migration_generator_test.rb @@ -0,0 +1,50 @@ +# frozen_string_literal: true + +# Redmine - project management software +# Copyright (C) 2006-2023 Jean-Philippe Lang +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + +require_relative '../test_helper' +require_relative '../../lib/generators/redmine_plugin_migration/redmine_plugin_migration_generator' + +class MigrationGeneratorTest < Rails::Generators::TestCase + TMP_DIR = Rails.root / 'tmp/test/generators' + + tests RedminePluginMigrationGenerator + destination TMP_DIR + setup :prepare_destination + + def test_migration_file_name_is_snake_case + g = generator ['MigrationDemo', 'AddMigrationTable'] + Redmine::Plugin.directory = TMP_DIR + + assert_name g, 'AddMigrationTable', :migration + + capture(:stdout) do + g.create_migration_file + end + + path_names = (Redmine::Plugin.directory / 'migration_demo/db/migrate') + .glob('*_add_migration_table.rb') + + assert_equal 1, path_names.count + end + + private + def assert_name(generator, value, method) + assert_equal value, generator.send(method) + end +end -- 2.40.1