commit bbdd134f6aec3cf19af87304137cecabd9778780 Author: MAEDA Go Date: Thu Nov 20 17:46:42 2025 +0900 Set DIR attribute for the HTML element diff --git a/app/views/layouts/base.html.erb b/app/views/layouts/base.html.erb index 62e23abd1..d99b38be5 100644 --- a/app/views/layouts/base.html.erb +++ b/app/views/layouts/base.html.erb @@ -1,5 +1,5 @@ - + <%= html_title %> diff --git a/test/integration/application_test.rb b/test/integration/application_test.rb index bbdedd6d8..0861c1833 100644 --- a/test/integration/application_test.rb +++ b/test/integration/application_test.rb @@ -31,6 +31,7 @@ class ApplicationTest < Redmine::IntegrationTest assert_select 'h2', :text => 'Projets' assert_equal :fr, current_language assert_select "html[lang=?]", "fr" + assert_select "html[dir=?]", "ltr" # then an italien user get '/projects', :headers => {'HTTP_ACCEPT_LANGUAGE' => 'it;q=0.8,en-us;q=0.5,en;q=0.3'} @@ -38,12 +39,19 @@ class ApplicationTest < Redmine::IntegrationTest assert_select 'h2', :text => 'Progetti' assert_equal :it, current_language assert_select "html[lang=?]", "it" + assert_select "html[dir=?]", "ltr" + + # html[dir] should be "rtl" for right-to-left scripts + get '/projects', :headers => {'HTTP_ACCEPT_LANGUAGE' => 'ar'} + assert_response :success + assert_select "html[dir=?]", "rtl" # not a supported language: default language should be used get '/projects', :headers => {'HTTP_ACCEPT_LANGUAGE' => 'zz'} assert_response :success assert_select 'h2', :text => 'Projects' assert_select "html[lang=?]", "en" + assert_select "html[dir=?]", "ltr" end def test_token_based_access_should_not_start_session