From ffb00af34f7de5ab653a2f0ebbf962204865a553 Mon Sep 17 00:00:00 2001 From: MAEDA Go Date: Fri, 16 Oct 2026 18:14:11 +0900 Subject: [PATCH] Remove the deprecated _is_pdf parameter from Redmine::Thumbnail.generate -- app/models/attachment.rb | 3 +-- lib/redmine/thumbnail.rb | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/models/attachment.rb b/app/models/attachment.rb index eeeb16910..855527ca4 100644 --- a/app/models/attachment.rb +++ b/app/models/attachment.rb @@ -277,8 +277,7 @@ class Attachment < ApplicationRecord target = thumbnail_path(size) begin - # TODO: Stop passing the deprecated is_pdf flag in Redmine 7.0 - Redmine::Thumbnail.generate(self.diskfile, target, size, is_pdf?) + Redmine::Thumbnail.generate(self.diskfile, target, size) rescue => e if logger logger.error( diff --git a/lib/redmine/thumbnail.rb b/lib/redmine/thumbnail.rb index d6f354aff..674f04dfb 100644 --- a/lib/redmine/thumbnail.rb +++ b/lib/redmine/thumbnail.rb @@ -33,8 +33,7 @@ module Redmine ALLOWED_TYPES = %w(image/avif image/bmp image/gif image/jpeg image/png image/webp application/pdf) # Generates a thumbnail for the source image to target - # TODO: Remove the deprecated _is_pdf parameter in Redmine 7.0 - def self.generate(source, target, size, _is_pdf = nil) + def self.generate(source, target, size) return nil unless convert_available? unless File.exist?(target) -- 2.55.0