From 26af79ccc3175e53f85231e11dc4d7adf9e859ca Mon Sep 17 00:00:00 2001 From: MAEDA Go Date: Tue, 3 Nov 2026 11:30:21 +0900 Subject: [PATCH 5/5] Fix JavaScript error on wiki toolbar shortcuts when the toolbar has no textarea When the deprecated wikitoolbar_for helper was called with the id of a textarea that is not on the page, every Ctrl/Cmd+Shift+P press raised a "Missing target element" error from its hidden toolbar. Co-Authored-By: Claude Opus 5.5 --- app/javascript/controllers/wiki_toolbar_controller.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/javascript/controllers/wiki_toolbar_controller.js b/app/javascript/controllers/wiki_toolbar_controller.js index c0ff10886..1f72fcdea 100644 --- a/app/javascript/controllers/wiki_toolbar_controller.js +++ b/app/javascript/controllers/wiki_toolbar_controller.js @@ -72,6 +72,7 @@ export default class extends Controller { } shortcut(event) { + if (!this.hasFieldTarget) return if (event.target !== this.field || event.shiftKey || event.altKey) return if (!(isMac ? event.metaKey : event.ctrlKey)) return @@ -113,6 +114,7 @@ export default class extends Controller { // Ctrl/Cmd+Shift+P previews the focused textarea, or switches the last // previewed one back to edit mode togglePreview(event) { + if (!this.hasFieldTarget) return if (event.target === this.field) { event.preventDefault() this.preview() -- 2.55.0