diff --git a/app/models/mail_handler.rb b/app/models/mail_handler.rb index 03044eee99..61d474d82f 100644 --- a/app/models/mail_handler.rb +++ b/app/models/mail_handler.rb @@ -488,7 +488,7 @@ class MailHandler < ActionMailer::Base 'done_ratio' => get_keyword(:done_ratio, :format => '(\d|10)?0'), 'is_private' => get_keyword_bool(:is_private), 'parent_issue_id' => get_keyword(:parent_issue) - }.delete_if {|k, v| v.blank?} + }.delete_if {|k, v| v.blank? && v != false} attrs end diff --git a/test/unit/mail_handler_test.rb b/test/unit/mail_handler_test.rb index 88913acd65..5687ef84e1 100644 --- a/test/unit/mail_handler_test.rb +++ b/test/unit/mail_handler_test.rb @@ -992,6 +992,16 @@ class MailHandlerTest < ActiveSupport::TestCase assert !journal.notes.match(/^Start Date:/i) end + def test_update_issue_with_private_keyword_no + Role.find(1).add_permission! :set_issues_private + Issue.find(2).update_columns(:is_private => true) + journal = submit_email('ticket_reply_with_status.eml', :allow_override => 'is_private') do |email| + email.gsub!('Status: Resolved', 'Private: No') + end + assert journal.is_a?(Journal) + assert_equal false, Issue.find(2).is_private + end + def test_update_issue_with_attachment assert_difference 'Journal.count' do assert_difference 'JournalDetail.count' do