Redmine: Issueshttps://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292024-02-28T11:59:45ZRedmine
Redmine Redmine - Patch #40325 (New): Redmine Email Notification Issue - Help Needed for Modern Authentic...https://www.redmine.org/issues/403252024-02-28T11:59:45ZDarshan Faldu
<p>Hi,</p>
<p>We've recently configured Redmine for our organization, and while everything seems to be working smoothly, we're encountering an issue with email notifications.</p>
<p>We have configured the email delivery method to use SMTP, as shown below:</p>
<pre><code class="ruby syntaxhl"><span class="ss">email_delivery:
delivery_method: :smtp</span>
<span class="ss">smtp_settings:
address: </span><span class="n">smtp</span><span class="p">.</span><span class="nf">office365</span><span class="p">.</span><span class="nf">com</span>
<span class="ss">port: </span><span class="mi">587</span>
<span class="ss">domain: </span><span class="n">smtp</span><span class="p">.</span><span class="nf">office365</span><span class="p">.</span><span class="nf">com</span>
<span class="ss">authentication: :login</span>
<span class="ss">user_name: </span><span class="s2">"noreply@myorg.com"</span>
<span class="ss">password: </span><span class="s2">"my~p@ssw0rd"</span>
<span class="ss">enable_starttls_auto: </span><span class="kp">true</span>
</code></pre>
<p>However, when attempting to send a test email, we receive the following error:</p>
<blockquote>
<p>An error occurred while sending mail (535 5.7.139 Authentication unsuccessful, basic authentication is disabled. [BM1PR01CA0164.INDPRD01.PROD.OUTLOOK.COM 2024-02-28T11:48:49.884Z 08DC38275E4F25C6])</p>
</blockquote>
<p>Our research suggests that Redmine may not fully support modern authentication methods by default, and Microsoft's deprecation of basic authentication for Office 365 further complicates this situation.</p>
<p>We would greatly appreciate your guidance on how to address this issue and ensure successful email notifications from Redmine.</p>
<p>Below are the Redmine installation information.</p>
<pre><code class="yaml syntaxhl"><span class="na">Environment</span><span class="pi">:</span>
<span class="s">Redmine version 5.0.3.stable</span>
<span class="s">Ruby version 2.6.10-p210 (2022-04-12) [x64-mingw32]</span>
<span class="s">Rails version 6.1.7</span>
<span class="s">Environment production</span>
<span class="s">Database adapter Mysql2</span>
<span class="s">Mailer queue ActiveJob::QueueAdapters::AsyncAdapter</span>
<span class="s">Mailer delivery smtp</span>
<span class="na">Redmine settings</span><span class="pi">:</span>
<span class="s">Redmine theme Default</span>
<span class="na">SCM</span><span class="pi">:</span>
<span class="s">Git 2.41.0</span>
<span class="s">Filesystem</span>
<span class="na">Redmine plugins</span><span class="pi">:</span>
<span class="s">no plugin installed</span>
</code></pre>
<p>Thank you for your time and assistance.</p> Redmine - Patch #40221 (New): Update wiki content related to how to create a custom themehttps://www.redmine.org/issues/402212024-02-10T10:31:36ZMarius BĂLTEANU
<p>After we finish the migration to Asset Pipeline, we need to update Wiki pages related to custom themese, for example: <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/HowTo_create_a_custom_Redmine_theme">HowTo_create_a_custom_Redmine_theme</a></p> Redmine - Patch #40202 (New): Add LICENSE.txt in the root directoryhttps://www.redmine.org/issues/402022024-02-07T02:35:13ZGo MAEDA
<p>Currently, the COPYING file which describes the license of Redmine is placed under the doc directory. This placement might not be immediately obvious to people.</p>
<p>I propose the addition of a short license file, named LICENSE.txt, to the root directory. This file briefly states that Redmine is licensed under the GNU General Public License version 2 (GPLv2) and the full license text can be found in the doc directory.</p>
<p>This approach has several benefits:</p>
<ol>
<li>It makes it easier for people to find and understand the licensing information at a glance</li>
<li>GitHub will automatically detect the presence of the LICENSE.txt file and display a link to it in the repository's sidebar</li>
<li>It aligns with the common practice among open-source projects to include licensing information in the root directory</li>
</ol> Redmine - Patch #40194 (New): Fix error in clear_disabled_fields method when IssuePriority is mis...https://www.redmine.org/issues/401942024-02-05T15:57:18ZYazan Al aeddin
<p>Hello</p>
<p>The clear_disabled_fields method in the Redmine codebase raises a NoMethodError exception when called,<br /> and the IssuePriority model is missing. This occurs due to an attempt to access the id attribute of IssuePriority without verifying its presence. The proposed fix ensures that the method gracefully handles the case where IssuePriority is missing by checking for its presence before accessing its attributes.<br />I propose this patch</p> Redmine - Patch #39385 (New): Install Redmine on cPanel hostinghttps://www.redmine.org/issues/393852023-10-27T14:06:51ZAndre Men
<a name="Install-Redmine-on-cPanel-hosting"></a>
<h1 >Install Redmine on cPanel hosting<a href="#Install-Redmine-on-cPanel-hosting" class="wiki-anchor">¶</a></h1>
<p>Any one can install it for me over cPanel hosting?</p>
<p>I need a fresh install.</p>
<p>Regards, Andre</p> Redmine - Patch #39050 (New): New design for the calendar viewhttps://www.redmine.org/issues/390502023-09-09T08:22:03ZYasu Saku
<p>I propose a new design for the calendar.<br />I have made it possible to visualize not only the start and end dates but also valid events.</p>
<a name="Current-designsourcetrunk22293"></a>
<h3 >Current design<br />(<a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/22293/entry/trunk">source:trunk@22293</a>)<br /><img src="https://www.redmine.org/attachments/download/30927/current.png" style="width:300px;" alt="" /><a href="#Current-designsourcetrunk22293" class="wiki-anchor">¶</a></h3>
<a name="New-design"></a>
<h3 >New design<br /><img src="https://www.redmine.org/attachments/download/30928/new.png" style="width:300px;" alt="" /><a href="#New-design" class="wiki-anchor">¶</a></h3> Redmine - Patch #38796 (New): Improved display of tracker selection area in custom field settingshttps://www.redmine.org/issues/387962023-06-30T20:20:02Zryo ito
<p>The items in the tracker selection area of the custom field setting screen are not properly aligned, <br />making it difficult to see and easy to operate when a large number of trackers are created.</p>
<p>Therefore, we have modified it to be properly aligned like the issue tracking tab in the project settings, <br />so that it can be easily viewed even when many trackers are displayed.</p>
<ul>
<li>before<br /><img src="https://www.redmine.org/attachments/download/30705/trackers_selection_before.png" alt="" /></li>
</ul>
<ul>
<li>after<br /><img src="https://www.redmine.org/attachments/download/30706/trackers_selection_after.png" alt="" /></li>
</ul> Redmine - Patch #38614 (New): add email handling by subjecthttps://www.redmine.org/issues/386142023-05-26T14:55:47ZAisha Tammy
<p>This change allows the email handler to find issues by subject and adds an option for this to be enabled (disabled by default as SQL full text search might be more expensive than needed).</p>
<p>I needed this as I am trying to use redmine for the openbsd project mailing lists, so I made redmine subscribe to that list and now redmine will add/update issues by looking at mails on this mailing list.</p> Redmine - Patch #38505 (New): Add an index into table custom_values on value columnhttps://www.redmine.org/issues/385052023-04-30T12:43:35Zsalman mp
<p>In my case (due to some custom fields on issues) querying issues was very time consuming.<br />This problem is almost solved by adding some index to the <code>custom_values</code> table on column <code>value</code>.</p> Redmine - Patch #38432 (New): Journal diff without Issuehttps://www.redmine.org/issues/384322023-04-11T08:28:29ZBrice Beaumesnil
<p>Hello,</p>
<p>If a plugin use journal (like redmine_risks), find_journal and diff methods need to link with an issue, if journal is create on another class 404 error is send.</p>
<p>I make a little patch to display generic diff without issue link.</p> Redmine - Patch #37994 (New): Unify link to user/group in application helperhttps://www.redmine.org/issues/379942022-12-05T16:12:13ZDmitry Makurin
After <a class="changeset" title="Add link from group name to group page on project overview page (#12795). Patch by Go MAEDA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21073">r21073</a> was introduced application helper has multiple methods to render user/group links:
<ul>
<li>link_to_user</li>
<li>link_to_principal</li>
<li>link_to_group</li>
</ul>
<p>The <code>link_to_principal</code> method combines the functionality of the other two. They don't have much use right now. I propose to unify all 3 methods in one.</p>
<p>An attached patch removes <code>link_to_user</code> and <code>link_to_group</code> methods and adds two aliases to <code>link_to_principal</code> (user and group respectively).</p>
<p><code>link_to_group</code> was used to redirect admin user to edit group page which is obsolete since all users have access to show group page and there is an edit link for admin.</p>
<p>Patch also adds a new test to confirm edit link presence for admins.</p> Redmine - Patch #37748 (New): Favicon takes a long time to loadhttps://www.redmine.org/issues/377482022-10-04T10:56:01ZGasper C
<p>I'm using passenger standalone and nginx as proxy webserver. Redmine is v5.0.2.</p>
<p>I've noticed that favicon isn't cached, and takes a ridiculous amount to load (~30ms).</p>
<p>While caching should be configured at webserver level, I've noticed that when I remove versioning from the favicon, it only takes about 4ms to load it.</p>
<p>This is a simple patch, maybe it would be better to remove some more of the code related to favicon, but I'm not familiar with ruby.</p>
<p>Before:<br /><img src="https://www.redmine.org/attachments/download/29750/before.png" alt="" /></p>
<p>After:<br /><img src="https://www.redmine.org/attachments/download/29749/after.png" alt="" /></p> Redmine - Patch #37559 (New): Use meta element instead of javascript objecthttps://www.redmine.org/issues/375592022-08-07T02:16:15ZTakashi Kato
<p>Modify autocomplete paths to be held in meta elements instead of JSON.<br />It reduces coupling compared to writing javascript in ruby code.</p>
<p>The patch can be applied to <a class="changeset" title="Replace JQuery `.focus()` method with HTML `autofocus` attribute (#37482). Patch by Go MAEDA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21762">r21762</a></p> Redmine - Patch #37486 (New): Add JavaScript unit tests.https://www.redmine.org/issues/374862022-07-23T01:49:55ZTakashi Kato
<p>Currently, Redmine does not have JavaScript unit tests; I propose to add lightweight unit tests in a Node.js environment.</p>
<p>Prerequisite environment: Node.js 16 or later, yarn 1.22</p>
<p>Tools to deploy for unit testing: mocha, chai, jsdom</p>
<p>This patch does not require all Redmine developers, including plugins and themes, to install Node.js. This patch uses Node.js only for JavaScript unit tests (like when adding stylelint).</p>
<p>Applying this patch and running yarn install will install the necessary tools for testing.</p>
<p>As a first example of adding tests, I added tests to context_menu.js and refactored them.</p>
<p>As a prerequisite for testing, I convert JavaScript to ES modules. (<a class="external" href="https://javascript.info/modules-intro">https://javascript.info/modules-intro</a>)</p>
<ul>
<li>ES modules do not use global namespaces by default. There is no longer a need to fear duplicate function names; context_menu.js prefixed all functions "ContextMenu" to avoid function names conflict, but that practice is no longer necessary.</li>
<li>Modularizing the scripts will delay processing, waiting until the HTML document is fully ready, which should speed up HTML processing as we move forward.</li>
<li>It would be impractical to es-modularize all of application.js at once, as there is a lot of JavaScript tightly coupled to html (using onclick, link_to_function, etc.). We need to consider other ways to improve.</li>
</ul>
<p>This patch also contains fix <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Fix the unintentional selection of rows with the context menu (Closed)" href="https://www.redmine.org/issues/37481">#37481</a>.</p>
<p>The patch can be applied to <a class="changeset" title="Open Help in a separate tab (#1069). Contributed by Vijay Kiran." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21737">r21737</a></p> Redmine - Patch #36438 (New): Support nulls first/last option for sorting order of custom querieshttps://www.redmine.org/issues/364382022-01-17T12:41:18ZDmitry Makurin
<p>A lot of RDBMS has support for placement of null values at the start or end using options nulls first/last.</p>
<p>Atached patch adds two more order options to the saved query:</p>
<ul>
<li>Ascending nulls last.</li>
<li>Descending nulls first.</li>
</ul>
<p><img src="https://www.redmine.org/attachments/download/28682/ksnip_20220117-150142.png" title="order options" alt="order options" /></p>
<p>And the result of issues sorted by <code>due date ascending nulls last</code>:</p>
<p><img src="https://www.redmine.org/attachments/download/28683/ksnip_20220117-150213.png" title="sported issues" alt="sported issues" /></p>
<p>Patch probably broken when using MySql since it doesn't have a straightforward syntax for order predicate but it's fine using SQLite3 or Postgres.</p> Redmine - Patch #36265 (New): More flexible options for issue notificationshttps://www.redmine.org/issues/362652021-12-01T09:27:24ZDmitry Makurin
<p>Currently issue notifications are limited to few options. If you want to exclude particular event redmine only allows settings for note, status, assignee, priority and target versions updates.<br />So there is no way to disable e.g. notifications for relation update.<br />Attached patch extends possible options for notifications. To existing ones added next events:</p>
<ul>
<li>Start date updated</li>
<li>Due date updated</li>
<li>Estimated hours updated</li>
<li>Category updated</li>
<li>Description updated</li>
<li>Done ratio updated</li>
<li>Parent issue updated</li>
<li>Project updated</li>
<li>Tracker updated</li>
<li>Subject updated</li>
<li>Attachment updated</li>
<li>Relation updated</li>
<li>Custom value updated</li>
</ul> Redmine - Patch #36182 (New): Show notifications for all Redmine usershttps://www.redmine.org/issues/361822021-11-11T04:54:59ZMizuki ISHIKAWA
<p>This patch adds the feature to display text throughout the site once it has been set in Settings > Administration.</p>
<p><img src="https://www.redmine.org/attachments/download/28407/screenshot-2021-11-11-10.41.31.png" style="width: 500px;border: 1px solid #ccc;" alt="" /><br /><img src="https://www.redmine.org/attachments/download/28408/screenshot-2021-11-11-10.41.49.png" style="width: 500px;border: 1px solid #ccc;" alt="" /></p>
<p>There is already a famous plugin called Redmine banner that is used by many people. <a class="external" href="https://www.redmine.org/plugins/redmine_banner">https://www.redmine.org/plugins/redmine_banner</a><br />This patch only provides very simple functionality, so I think you will need the Redmine banner plugin to change the notification destination and design.</p> Redmine - Patch #35816 (New): Patch to add Postgis adapter supporthttps://www.redmine.org/issues/358162021-08-25T15:51:21ZMarcel B
<p>I've been running Redmine with postgis adapter for while to support a plugin for spatial data.</p>
<p>The proposed patch is necessary to eliminate annoying waning messages from Gemfile and to allow Query with case insentive (ILIKE), since postgis only adds spatial functions on top of the postgresql adapter.</p>
<p>It was tested for several months on FreeBSD 12 and CentOS 7.</p> Redmine - Patch #35648 (New): Changelog generator should allow merging two or more versionshttps://www.redmine.org/issues/356482021-08-01T08:15:59ZMarius BĂLTEANU
<p>The script used to generate the changelog for releases should allow merging two or more versions.</p>
For example, for the latest releases, we generated the changelog for two versions:
<ul>
<li>4.1.4</li>
<li>4.2.2</li>
</ul>
<p>The changelog for 4.2.2 should contain also the changes for 4.1.4, but the script doesn't do this and we need to manually merge the changelogs which is very error-prone.</p>
<p>Also, the script should allow authorised requests in order to pull the security issues which are private at the time of the releases. The authorization should use environment variables.</p> Redmine - Patch #35536 (New): Use webpack to improve javascripts and stylesheets managementhttps://www.redmine.org/issues/355362021-07-06T10:00:04ZTakashi Kato
<p>I propose the use of webpack as a library management tool for javascript. I also suggest the use of <a href="https://github.com/hokaccha/simpacker" class="external">simpacker</a> as a tool for linking rails and webpack.</p>
<p>The docker environment can be found here.</p>
<p><a class="external" href="https://github.com/tohosaku/redmine-docker-wsl2">https://github.com/tohosaku/redmine-docker-wsl2</a></p>
<a name="Motivation"></a>
<h2 >Motivation<a href="#Motivation" class="wiki-anchor">¶</a></h2>
<ul>
<li>To deal with the problem that <a class="issue tracker-1 status-1 priority-4 priority-default" title="Defect: JavaScript is not minified for production use (New)" href="https://www.redmine.org/issues/6662">#6662</a> "js files are not compressed" </li>
<li>To be a foundation for future npm package usage.</li>
</ul> Redmine - Patch #35268 (New): Issue.acts_as_searchable columns option cleanuphttps://www.redmine.org/issues/352682021-05-20T14:29:36ZThomas Löber
<p>Hi,</p>
<p>Just for the sake of completeness, in <code>Issue.acts_as_searchable</code> the <code>columns</code> option should specify the table name for both columns.</p>
<p>A patch is attached.</p>
<p>Best regards,<br />Thomas</p> Redmine - Patch #35217 (New): Replace use of Digest::MD5 / Digest::SHA1 with ActiveSupport::Digesthttps://www.redmine.org/issues/352172021-05-07T03:02:16ZJens Krämerjk@jkraemer.net
<p>Rails introduced <code>ActiveSupport::Digest</code> to allow central configuration of the actual digest implementation that is used throughout Rails. This is helpful in environments where certain digest implementations (most notably, MD5) are not available, i.e. to be <a href="https://www.nist.gov/itl/fips-general-information" class="external">FIPS</a> compliant.</p>
<p>The attached patch replaces all uses of <code>Digest::SHA1</code> and <code>Digest::MD5</code> with <code>ActiveSupport::Digest</code>. Without further configuration, this will result in <code>Digest::SHA1</code> being used in all these instances since that's the current Rails default. This can be changed by users via the <a href="https://github.com/rails/rails/pull/40213" class="external">config.active_support.hash_digest_class setting</a> , i.e.:</p>
<pre>
Rails.application.config.active_support.hash_digest_class = OpenSSL::Digest::SHA256
</pre> Redmine - Patch #34218 (New): Increase size of value field in settingshttps://www.redmine.org/issues/342182020-11-03T10:21:58ZAleksandar Pavic
<p>Size of value is text field which is around ~64kb.</p>
<p>In some cases like using some of plugins, errors like this might arise:</p>
<p><code>Mysql2::Error: Data too long for column 'value' at row 1: UPDATE settings SET value = '---\nprojects:\n 45:\n helpdesk_answer_from:</code></p>
<p>This patch increases size of text field to larger format.</p> Redmine - Patch #34146 (New): Implementationhttps://www.redmine.org/issues/341462020-10-20T20:35:55ZCarlos Miguel
<p>For creating the lists and making it even better. It would be important to create a relationship between the contents of the lists by viewing the codes of the values created. So that I have the possibility to have a personalized list that share values from the list. The value of a list must be in several lists. In this case, when passing the values of a list, I can select the values in the list fields, showing the duplicity and the need to create new values for several lists.</p> Redmine - Patch #33938 (New): Add missing fixtures to IssueNestedSetTesthttps://www.redmine.org/issues/339382020-09-01T03:04:56ZYuichi HARADA
<p>Sometimes IssueNestedSetTest fails.</p>
<pre>
$ RAILS_ENV=test bundle exec rake db:migrate:reset
$ RAILS_ENV=test bundle exec rake test
Run options: --seed 43474
# Running:
............F
Failure:
IssueNestedSetTest#test_destroy_should_destroy_children [./test/unit/issue_nested_set_test.rb:225]:
"JournalDetail.count" didn't change by -1.
Expected: 7
Actual: 6
bin/rails test test/unit/issue_nested_set_test.rb:216
.........F
Failure:
IssueNestedSetTest#test_destroy_child_issue_with_children [./test/unit/issue_nested_set_test.rb:270]:
"JournalDetail.count" didn't change by -1.
Expected: 7
Actual: 6
bin/rails test test/unit/issue_nested_set_test.rb:262
........
Finished in 410.935528s, 12.2404 runs/s, 56.5588 assertions/s.
5030 runs, 23242 assertions, 2 failures, 0 errors, 3 skips
You have skipped tests. Run with --verbose for details.
$
<pre></pre> Redmine - Patch #33211 (New): Include block columns (ex: Description, Last notes) in CSV export w...https://www.redmine.org/issues/332112020-03-29T13:24:01ZMarius BĂLTEANURedmine - Patch #33118 (New): Detect plain diffs in e-mail submitted issues and map to attachmentshttps://www.redmine.org/issues/331182020-03-10T10:21:26ZAnthony Mallet
<p>Diffs sent as plain/text message (as with git format-patch + git send-email) in<br />issues tend to be textilized, which messes up the display. Also, the original<br />patch file is not easily downloadable for processing.</p>
<p>With this patch, when a diff file is detected in a plain text message without<br />attachment, the whole e-mail message is converted into a proper attachment<br />(that is suitable for git am) and only the diff comment is stored in the<br />issue description.</p>
<p>The diff detection is based on the following heuristics:<br />- body contains three consecutive lines starting with "---", "+++" and "@@" <br />- and body contains a line starting with "---", "diff -" or "Index: "</p>
<p>The message body is split before this detected separator.</p> Redmine - Patch #33117 (New): Redirect to users_path instead of edit_user_path in order to avoid ...https://www.redmine.org/issues/331172020-03-10T10:01:07ZGo MAEDA
<p>Currently, a user is redirected to <code>edit_user_path</code> (/users/*/edit) after creating a user. However, I think it is better to be redirected to <code>user_path</code> (/users) for the following reasons:</p>
<ul>
<li>Inconsistent. There are some exceptions but most forms in Admin page shows index page after an object is created</li>
<li>Confusing. Today I observed that an admin mistakenly rewrote the user that has just created. It is because they misunderstood that the form is /users/new, but it was actually /users/*/edit</li>
<li>I cannot find any use cases that showing <code>edit_user_path</code> is better than <code>users_path</code></li>
</ul>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 2fb297874..d3e853b43 100644
</span><span class="gd">--- a/app/controllers/users_controller.rb
</span><span class="gi">+++ b/app/controllers/users_controller.rb
</span><span class="p">@@ -122,7 +122,7 @@</span> class UsersController < ApplicationController
attrs = {:generate_password => @user.generate_password }
redirect_to new_user_path(:user => attrs)
else
<span class="gd">- redirect_to edit_user_path(@user)
</span><span class="gi">+ redirect_to users_path
</span> end
}
format.api { render :action => 'show', :status => :created, :location => user_url(@user) }
</code></pre> Redmine - Patch #32961 (New): Make group names clickable in permissions reporthttps://www.redmine.org/issues/329612020-02-06T17:05:36ZBernhard Rohloff
<p>At the moment only the caret next to the group name is clickable which makes it difficult to collapse/expand the groups.<br />It would be better to make also the group text clickable like for the filters.</p> Redmine - Patch #32951 (New): Issue Statuses sortable by name and positionhttps://www.redmine.org/issues/329512020-02-04T20:14:30ZAnas Al Salah
<p>Allow admin to sort statuses by name and position in /issue_statuses</p> Redmine - Patch #32522 (New): Add Project.find_by_name to target_projecthttps://www.redmine.org/issues/325222019-11-27T12:35:23ZKeks Keksov
<p>Consider issue <a class="issue tracker-1 status-5 priority-5 priority-high2 closed" title="Defect: Bug in project name when create issue by email (Closed)" href="https://www.redmine.org/issues/6694">#6694</a>, fix is trivial. Think about all those reporters who struggle to memorizing all that ID stuff.</p>
<p>File app/models/mail_handler.rb<br />Line 410</p>
<p>target = get_project_from_receiver_addresses<br />target ||= Project.find_by_identifier(get_keyword(:project))<br />target ||= Project.find_by_name(get_keyword(:project)) # just one new line</p> Redmine - Patch #32296 (New): Ignore rubocop offensehttps://www.redmine.org/issues/322962019-10-18T06:42:08ZMasahiro IUCHI
<p>I found a rubocop offense is remaining.</p>
<pre>
$ rubocop db/migrate/20190510070108_add_unique_id_to_import_items.rb
Inspecting 1 file
C
Offenses:
db/migrate/20190510070108_add_unique_id_to_import_items.rb:3:5: C: Rails/BulkChangeTable: You can combine alter queries using bulk: true options.
change_table :import_items do |t|
^^^^^^^^^^^^^^^^^^^^^^^^^^
1 file inspected, 1 offense detected
</pre>
<p>Environment information:</p>
<pre>
$ RAILS_ENV=test bin/about
Environment:
Redmine version 4.0.4.devel.18732
Ruby version 2.5.5-p157 (2019-03-15) [x86_64-darwin19]
Rails version 5.2.3
Environment test
Database adapter Mysql2
Mailer queue ActiveJob::QueueAdapters::InlineAdapter
Mailer delivery test
SCM:
Subversion 1.10.4
Git 2.21.0
Filesystem
Redmine plugins:
no plugin installed
</pre>
<p>I have created a patch to ignore it like other migration files.</p> Redmine - Patch #32142 (New): Send notification when a user is created via LDAP on-the-fly user c...https://www.redmine.org/issues/321422019-09-26T00:39:21ZGo MAEDA
<p>Redmine has LDAP on the fly user creation feature (see <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineLDAP#On-the-fly-user-creation">RedmineLDAP</a>). After the on-the-fly creation, admins have to perform some tasks such as checking if the creation is OK and adding the user to groups or projects.</p>
<p>Currently, however, no notification is sent to admins after a user is automatically created, so admins have no chance to notice that the user was created.</p>
<p>I think some notification should be sent to admins when a user is created via LDAP on-the-fly user creation feature.</p> Redmine - Patch #31283 (New): Assign ticket comment by subaddresshttps://www.redmine.org/issues/312832019-04-30T15:36:17ZRoland Tapken
<p>I've created a patch that allows to not only create new tickets by subaddressing (like project_from_subaddress) but also to append comments to a ticket by using the ticket id as subaddress. The patch applies to Redmine 3.4.</p>
<p>This allows to forward related mails to '<a class="email" href="mailto:foobar+1234@example.org">foobar+1234@example.org</a>' without having to change the mail's subject or message id.</p>
<p>Additionally, I added a new configuration option that let Redmine add a 'Reply-To: <a class="email" href="mailto:foobar+1234@example.org">foobar+1234@example.org</a>' header field, if enabled. Of course, the server need to have support for subaddressing, otherwise those mails would be rejected. Maybe this could be clarified with an additional description.</p>
<p>The patch doesn't include test cases since I currently don't have the time to setup a complete build environment but changed the code directly in the live system.</p> Redmine - Patch #31151 (New): Add AppServer to Technical Information pagehttps://www.redmine.org/issues/311512019-04-05T12:49:52ZVincent Robert
<p>Hello</p>
<p>The Information page shows some useful data about the current environment. But one important information is missing: the app server.<br />So here is a patch which adds this information to the list.</p>
<p>Thank you</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/controllers/admin_controller.rb b/app/controllers/admin_controller.rb
</span><span class="gd">--- a/app/controllers/admin_controller.rb
</span><span class="gi">+++ b/app/controllers/admin_controller.rb
</span><span class="p">@@ -77,5 +77,6 @@</span> class AdminController < ApplicationController
[:text_rmagick_available, Object.const_defined?(:Magick)],
[:text_convert_available, Redmine::Thumbnail.convert_available?]
]
<span class="gi">+ @request = request
</span> end
end
diff --git a/app/views/admin/info.html.erb b/app/views/admin/info.html.erb
<span class="gd">--- a/app/views/admin/info.html.erb
</span><span class="gi">+++ b/app/views/admin/info.html.erb
</span><span class="p">@@ -12,7 +12,7 @@</span>
</table>
<br />
<div class="box">
<span class="gd">-&lt;pre&gt;&lt;%= Redmine::Info.environment %&gt;&lt;/pre&gt;
</span><span class="gi">+&lt;pre&gt;&lt;%= Redmine::Info.environment(@request) %&gt;&lt;/pre&gt;
</span> &lt;/div&gt;
&lt;% html_title(l(:label_information_plural)) -%&gt;
diff --git a/lib/redmine/info.rb b/lib/redmine/info.rb
<span class="gd">--- a/lib/redmine/info.rb
</span><span class="gi">+++ b/lib/redmine/info.rb
</span><span class="p">@@ -6,17 +6,17 @@</span> module Redmine
def help_url; 'https://www.redmine.org/guide' end
def versioned_name; "#{app_name} #{Redmine::VERSION}" end
- def environment
<span class="gi">+ def environment(request = nil)
</span> s = "Environment:\n"
<span class="gd">- s &lt;&lt; [
- ["Redmine version", Redmine::VERSION],
- ["Ruby version", "#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL} (#{RUBY_RELEASE_DATE}) [#{RUBY_PLATFORM}]"],
- ["Rails version", Rails::VERSION::STRING],
- ["Environment", Rails.env],
- ["Database adapter", ActiveRecord::Base.connection.adapter_name],
- ["Mailer queue", ActionMailer::DeliveryJob.queue_adapter.class.name],
- ["Mailer delivery", ActionMailer::Base.delivery_method]
- ].map {|info| " %-30s %s" % info}.join("\n") + "\n"
</span><span class="gi">+ environment_data = [["Redmine version", Redmine::VERSION],
+ ["Ruby version", "#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL} (#{RUBY_RELEASE_DATE}) [#{RUBY_PLATFORM}]"],
+ ["Rails version", Rails::VERSION::STRING],
+ ["Environment", Rails.env],
+ ["Database adapter", ActiveRecord::Base.connection.adapter_name],
+ ["Mailer queue", ActionMailer::DeliveryJob.queue_adapter.class.name],
+ ["Mailer delivery", ActionMailer::Base.delivery_method]]
+ environment_data &lt;&lt; ["App server", request.get_header("SERVER_SOFTWARE")] if request.present?
+ s &lt;&lt; environment_data.map {|info| " %-30s %s" % info}.join("\n") + "\n"
</span>
s &lt;&lt; "SCM:\n"
Redmine::Scm::Base.all.each do |scm|
</code></pre> Redmine - Patch #30757 (New): LDAP Contextless login in Active Directoryhttps://www.redmine.org/issues/307572019-02-06T15:07:58ZGuilherme Chehab
<p>I created a very quick and dirty 4-line patch to allow contextless login authentication in Active Directory on LDAP module. I.e. without the need to have a search specific user nor allowing anonymous search in the directory server.</p>
<p>It uses the same login and password entered in the login screen and computes domain from a regex sub from the base_dn to avoid the need to create additional configuration fields (binds samaccountname=login@domain).</p>
<p>I know that it might not be needed for most AD ldap scenarios, when you should be able to create a specific user just to bind and search on your Active Directory, but I thought it might come in handy for other people.</p> Redmine - Patch #30739 (New): Project Custom Fields configuration : split by trackerhttps://www.redmine.org/issues/307392019-02-04T14:28:16ZJérôme BATAILLE
This patch splits Custom Fields Fieldset in Sub-Blocks :
<ul>
<li>Custom Fields for All trackers</li>
<li>Custom Fields for Multiple trackers</li>
<li>Custom Fields for a specific tracker</li>
</ul>
<p>This is quite more clear to show Custom Fiels Configuration by tracker.<br />The <strong>check/uncheck all</strong> Javascript link has been removed for Custom Fields configured for all trackers.</p>
<p><img src="https://www.redmine.org/attachments/download/24437/custom_fields_configuration_by_tracker.png" style="border: 1px solid;" alt="" /></p> Redmine - Patch #29424 (New): Convert migration file from 4.2 to 5.2https://www.redmine.org/issues/294242018-08-22T11:42:53ZEnziin System
<p>I recently saw Redmine use Rails 5.2.1, which is a good thing.</p>
<p>However, upgrading to Rails 5.2.1 does not simply add it to the Gemfile.</p>
<p>I have migrated the migration files from 4.2 to 5.2, please consider the patch.</p>
<p>The reason for the change: The default id of Rails 3-4 is int, which allows for a maximum of 4.2 billion items.</p>
<p>This is not a big number when using Redmine in large-scale applications.</p>
<p>Need to replace with bigint(20) in id and foreign key.</p>
<p>I tested the patch and confirmed that Redmine works normally after the upgrade.</p> Redmine - Patch #28618 (New): Datepicker is called incorrectlyhttps://www.redmine.org/issues/286182018-04-24T12:12:46ZElena Krasnopolskaya
<p>When calling Datepicker an array of objects was passed incorrectly: at the time of the call <code>$(input).datepickerFallback("option", "defaultDate", default_date);</code> [application.js:689] in array is passed 3 arguments, but in [application.js:216-217] one argument is passed to the function. Function is declared <code>$.fn.datepickerFallback = function( options )</code> [application.js:836] with one argument. Therefore when calling the "real" Datepicker only one argument is passed instead of three.</p>
<p>The attached patch fixes this.</p> Redmine - Patch #26685 (New): Check of child classes of all levels is added for Redmine::Subclass...https://www.redmine.org/issues/266852017-08-14T15:01:11ZVladimir Litov
<p>SubQuery < Query</p>
<p>NewSubQuery < SubQuery</p>
<p>And I will see "Undefined method new for nil class"</p> Redmine - Patch #25570 (New): unchecked use of params[:query]https://www.redmine.org/issues/255702017-04-11T04:54:30ZJens Krämerjk@jkraemer.net
<p>Requests to URLs like <code>/issues?query=12</code> result in an application error because <code>query.rb</code> expects <code>params[:query]</code> to be a hash, which it isn't in this case.</p>
<p>I know that there are a more instances in the code base where we assume <code>params[:foo]</code> to be a hash without explicit type checking. This patch does not attempt to address this problem on a global level. For whatever reason it happens to us quite often in this particular place, causing false alerts in server monitoring.</p>
<p>This patch adds an explicit type check to resolve this <code>params[:query]</code> case. As a bonus it makes the following 4 lines where values are taken out of the hash a bit nicer.</p>
<p>In general I think it would be preferably to raise an error of the 4xx class in such cases. Are there any plans to make use of Rails' Strong Parameters feature in the future? I think using these permit / require calls on parameters in controllers would catch such wrong types early and would lead to responses with a more appropriate error code automatically.</p> Redmine - Patch #24623 (New): Implements CRUD permissions and restrictions to issue attachmentshttps://www.redmine.org/issues/246232016-12-15T18:29:44ZFrederico Camara
<p>If anyone could help implement the test cases, I think this would be a great feature to Redmine.</p>
<p>Test applying the patch from Redmine directory:</p>
<pre>
patch --dry-run -p1 < atta.version
</pre>
<p>Then apply:</p>
<pre>
patch -p1 < atta.version
</pre>
<p>Patches added to redmine 3.1/3.2, 3.3 and current master.</p>
<a name="Patch-details"></a>
<h2 >Patch details:<a href="#Patch-details" class="wiki-anchor">¶</a></h2>
Permissions:
<ul>
<li>lib/redmine.rb</li>
</ul>
Permission to view/delete:
<ul>
<li>app/models/issue.rb</li>
<li>app/models/journal.rb</li>
<li>app/views/issues/show.api.rsb</li>
<li>app/views/issues/show.html.erb</li>
<li>lib/redmine/export/pdf/issues_pdf_helper.rb</li>
<li>lib/plugins/acts_as_searchable/lib/acts_as_searchable.rb</li>
</ul>
Permission to edit (add):
<ul>
<li>app/views/issues/new.html.erb</li>
<li>app/views/issues/_edit.html.erb</li>
</ul>
Permission to copy (view from, edit to):
<ul>
<li>app/controllers/issues_controller.rb</li>
<li>app/models/issue.rb</li>
</ul>
Mailer restrictions:
<ul>
<li>app/models/mailer.rb</li>
<li>app/views/mailer/_issue.html.erb</li>
<li>app/views/mailer/_issue.text.erb</li>
</ul>
Translation:
<ul>
<li>config/locales/en.yml</li>
<li>config/locales/pt-BR.yml</li>
</ul>
Migration:
<ul>
<li>db/migrate/20161215142110_add_attachments_permissions.rb</li>
</ul> Redmine - Patch #24072 (New): Added formatting for email notificationshttps://www.redmine.org/issues/240722016-10-14T19:10:49ZBryan Settles
<p>This is meant to allow email notifications to show due date, and separate the issues that are past due from the ones that are due in the next (custom amount) of days</p> Redmine - Patch #21550 (Needs feedback): New option in html redmine link parsing - attachmentshttps://www.redmine.org/issues/215502015-12-16T21:32:09ZOndřej Ezr
<p>Option for parsing to choose if attachment link should be download link or not.</p> Redmine - Patch #21101 (New): Add go-to action schemahttps://www.redmine.org/issues/211012015-10-29T15:33:02ZAn Phan
<p>This is to add a <a href="https://developers.google.com/gmail/markup/reference/go-to-action" class="external">go-to action schema</a> that should enable a "View issue" button in Gmail (similar to that in Github emails).</p> Redmine - Patch #21057 (New): Update and extend Gantt module wiki documentationhttps://www.redmine.org/issues/210572015-10-24T04:52:41ZMischa The Evil
I think it's time for <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineGantt">RedmineGantt</a> wiki page to be updated and - mostly - extended. Info has been requested repeatedly, eg.:
<ul>
<li><a class="message" href="https://www.redmine.org/boards/2/topics/25352">Gantt chart (color explanation)</a></li>
<li><a class="message" href="https://www.redmine.org/boards/2/topics/37445">Gantt, color explanation</a></li>
<li><a class="message" href="https://www.redmine.org/boards/2/topics/45192">Help understanding the Gantt chart</a></li>
</ul>
<p>I'll take care of it this weekend; I create and self-assign this issue to prevent this slips out of my sight again.</p> Redmine - Patch #20287 (New): Administration: Using grids instead of tableshttps://www.redmine.org/issues/202872015-07-10T20:09:37ZFrederico Camara
<p>We are a brazillian government agency and we've been using Redmine to control ExpressoBr (groupware) tickets.</p>
<p>Some time ago, it became difficult to manage the workflow status transitions. In a complex workflow, the table becomes so large it would scroll horizontally and vertically away from the first line and column. Zooming out and filters helped somehow, mainly if the status transition would be nearer the top left. The most recently created statuses would be too far right and down for zoom to help.</p>
<p>This patch transforms the administration tables into grids, so the first row and first column are always visible, like in a worksheet. Also, I got rid of the button that selected the whole line or column, because it became completely useless in a large grid, but I think it is easy to put it back.</p>
Redmine has 5 pages with tables in administration:
<ul>
<li>Roles and Permissions > Permission Report</li>
<li>Trackers > Summary</li>
<li>Workflow > Summary</li>
<li>Workflow > Status transitions</li>
<li>Workflow > Field permissions</li>
</ul>
<p>The grid itself is something like a table, it has four parts: A floating first cell, a first line stuck to the top of the grid, a first row stuck to the left, a body that on scroll, repositions the first row and first line using javascript. The other javascript resizes the width of columns in the grid.</p> Redmine - Patch #20124 (New): Query option, The sql for field to allow groups option.https://www.redmine.org/issues/201242015-06-18T07:25:13ZRupesh J
<p>The simple commit help abundantly and allow us to grouping the custom queries.<br />When the available filters is added with the field name, the check already exists for sql field statement.<br />Another check is added when the field is added with grouping.</p>
<p>Please update this patch in the core.</p>
<p>Thanks.</p> Redmine - Patch #20121 (New): Respect working days configuration when sending reminder emailshttps://www.redmine.org/issues/201212015-06-17T16:24:14ZAlexander Stehlik
<p>Currently the reminder rake task will search for issues that are due in x days in the future without checking the working days configuration of redmine</p>
<p>The attached patch introduces a new argument for the rake task: <code>respect_nonworking_days</code>. When this argument is TRUE, the working days setting will be respected when calculating the days in the future. E.g. when 7 days are requested and in this period are 2 non working days, the query will search for issues that are due within 9 days.</p> Redmine - Patch #18209 (New): Add e-mail notification option: Tracker updatedhttps://www.redmine.org/issues/182092014-10-27T14:24:16ZMartin Cizek
<p>The "global" email notifications settings (Administration -> Settings -> Email notifications) currently allow to specify the following issue updates to be watched by users who have chosen to watch "any events on...":<br /><pre>
[ ] Issue updated
[x] Note added
[x] Status updated
[x] Assignee updated
[x] Priority updated
</pre><br />We suggest to add "Tracker updated", as we consider it a substantial event for certain people (e.g. a customer willing to know whenever a Bug is changed to a Feature, but don't want to be spammed by issue reassignments). The new 'Issue updated' action notifications would be:<br /><pre>
[ ] Issue updated
[x] Note added
[x] Status updated
[x] Assignee updated
[x] Priority updated
[x] Tracker updated
</pre></p>
<p>This update would be especially beneficial for <a href="http://www.redmine.org/plugins/event_notifications" class="external">Event notifications</a> plugin users, who are able to set these standard notification options also per-user and per-project.</p>
<p>The patch against current trunk (<a class="changeset" title="Latvian translation updated by Jānis Elmeris (#18182)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13520">r13520</a>) is attached; if there is anything we should improve, please let us know.</p>
<p>P.S. I've noticed this feature is similar to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Option to send email on "Assignee updated" (Closed)" href="https://www.redmine.org/issues/16362">#16362</a>, where assignee change was added.</p>
<p>(thanks to Sandra Tatarevicova, sponsored by Orchitech Solutions)</p> Redmine - Patch #18134 (New): Issues with svn:mergeinfo property values and r13443 rails-4.1 rebase.https://www.redmine.org/issues/181342014-10-20T04:05:20ZMischa The Evil
After some Redmine core SCM log reviewing I noticed several issues:
<ol>
<li>related to svn:mergeinfo properties:
<ol>
<li>[rails-4.1 branch] <a class="changeset" title="Rebase from trunk at r13439." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13443">r13443</a> rebase of rails-4.1 branch included rails-4.1 backport commits to trunk<sup><a href="#fn1">1</a></sup> (in svn:mergeinfo only obviously): need to reverse-merge them for svn:mergeinfo</li>
<li>[rails-4.1 branch] contains four commits merged from trunk<sup><a href="#fn2">2</a></sup>: this is not reflected in the respective svn:mergeinfo property</li>
<li>[trunk] three commits were backported from rails-4.1 branch to trunk<sup><a href="#fn3">3</a></sup>: this is not reflected in the respective svn:mergeinfo property</li>
<li>[2.6-stable branch] contains one commit merged from trunk (<a class="changeset" title="Japanese translation updated by Go MAEDA (#18069)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13439">r13439</a>): this is not reflected in the respective svn:mergeinfo property</li>
</ol>
</li>
<li>related to the <a class="changeset" title="Rebase from trunk at r13439." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13443">r13443</a> rails-4.1 rebase:
<ol>
<li>[rails-4.1 branch] <a class="changeset" title="Rebase from trunk at r13439." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13443">r13443</a> rebase is missing commits from trunk<sup><a href="#fn4">4</a></sup> ((start rails-4.1)..(start rebase)): still needs to be <em>merged</em></li>
</ol></li>
</ol>
<p>So I checked out Redmine svn source and started fixing them one after another.</p>
The first four are changes to the svn:mergeinfo values only (<code>svn merge ... --record-only</code>) and the last is a complete merge (thus with svn:mergeinfo property update) of fourteen commits where two files<sup><a href="#fn5">5</a></sup> had some simple conflicts to be solved manually:
<ul>
<li>1. reverse-merge-backport-commits-on-trunk_against_rails-4.1_at_r13451.patch:
<a href="#" onclick="$('#collapse-8b0018b0-show, #collapse-8b0018b0-hide').toggle(); $('#collapse-8b0018b0').fadeToggle(150);; return false;" id="collapse-8b0018b0-show" class="icon icon-collapsed collapsible">view details...</a><a href="#" onclick="$('#collapse-8b0018b0-show, #collapse-8b0018b0-hide').toggle(); $('#collapse-8b0018b0').fadeToggle(150);; return false;" id="collapse-8b0018b0-hide" class="icon icon-expended collapsible" style="display:none;">view details...</a><div id="collapse-8b0018b0" class="collapsed-text" style="display:none;"><pre><code class="diff syntaxhl"><span class="gh">Index: .
===================================================================
</span><span class="gd">--- . (revision 13451)
</span><span class="gi">+++ . (working copy)
</span>
Property changes on: .
<span class="p">___________________________________________________________________
Modified: svn:mergeinfo
</span> Reverse-merged /trunk:r13405-13408
</code></pre>
<p>Before this change, the svn:mergeinfo value for rails-4.1 branch was:<br /><pre>/trunk:13333-13439</pre><br />after it, it looks like:<br /><pre>/trunk:13333-13404,13409-13439</pre></p></div></li>
<li>2. merge-merged-in-41-from-trunk_to_rails-4.1_at_r13451.patch:
<a href="#" onclick="$('#collapse-66200d60-show, #collapse-66200d60-hide').toggle(); $('#collapse-66200d60').fadeToggle(150);; return false;" id="collapse-66200d60-show" class="icon icon-collapsed collapsible">view details...</a><a href="#" onclick="$('#collapse-66200d60-show, #collapse-66200d60-hide').toggle(); $('#collapse-66200d60').fadeToggle(150);; return false;" id="collapse-66200d60-hide" class="icon icon-expended collapsible" style="display:none;">view details...</a><div id="collapse-66200d60" class="collapsed-text" style="display:none;"><pre><code class="diff syntaxhl"><span class="gh">Index: .
===================================================================
</span><span class="gd">--- . (revision 13451)
</span><span class="gi">+++ . (working copy)
</span>
Property changes on: .
<span class="p">___________________________________________________________________
Modified: svn:mergeinfo
</span> Merged /trunk:r13302,13306,13311,13332
</code></pre>
<p>Before this change, the svn:mergeinfo value for rails-4.1 branch was:<br /><pre>/trunk:13333-13404,13409-13439</pre><br />after it, it looks like:<br /><pre>/trunk:13302,13306,13311,13332-13404,13409-13439</pre></p></div></li>
<li>3. merge-backported-in-trunk-from-41_to_trunk_at_r13451.patch:
<a href="#" onclick="$('#collapse-a81c0b40-show, #collapse-a81c0b40-hide').toggle(); $('#collapse-a81c0b40').fadeToggle(150);; return false;" id="collapse-a81c0b40-show" class="icon icon-collapsed collapsible">view details...</a><a href="#" onclick="$('#collapse-a81c0b40-show, #collapse-a81c0b40-hide').toggle(); $('#collapse-a81c0b40').fadeToggle(150);; return false;" id="collapse-a81c0b40-hide" class="icon icon-expended collapsible" style="display:none;">view details...</a><div id="collapse-a81c0b40" class="collapsed-text" style="display:none;"><pre><code class="diff syntaxhl"><span class="gh">Index: .
===================================================================
</span><span class="gd">--- . (revision 13451)
</span><span class="gi">+++ . (working copy)
</span>
Property changes on: .
<span class="p">___________________________________________________________________
Modified: svn:mergeinfo
</span> Merged /sandbox/rails-4.1:r13296,13313,13315
</code></pre>
<p>Before this change, the svn:mergeinfo value for trunk was:<br /><pre>n/a for rails-4.1</pre><br />after it, it looks like:<br /><pre>/sandbox/rails-4.1:13296,13313,13315</pre></p></div></li>
<li>4. merge-merged-in-2.6-stable-from-trunk_to_2.6-stable_at_r13451.patch:
<a href="#" onclick="$('#collapse-82993943-show, #collapse-82993943-hide').toggle(); $('#collapse-82993943').fadeToggle(150);; return false;" id="collapse-82993943-show" class="icon icon-collapsed collapsible">view details...</a><a href="#" onclick="$('#collapse-82993943-show, #collapse-82993943-hide').toggle(); $('#collapse-82993943').fadeToggle(150);; return false;" id="collapse-82993943-hide" class="icon icon-expended collapsible" style="display:none;">view details...</a><div id="collapse-82993943" class="collapsed-text" style="display:none;"><pre><code class="diff syntaxhl"><span class="gh">Index: .
===================================================================
</span><span class="gd">--- . (revision 13451)
</span><span class="gi">+++ . (working copy)
</span>
Property changes on: .
<span class="p">___________________________________________________________________
Modified: svn:mergeinfo
</span> Merged /trunk:r13439
</code></pre>
<p>Before this change, the svn:mergeinfo value for 2.6-stable branch was:<br /><pre>n/a for 2.6-stable</pre><br />after it, it looks like:<br /><pre>/trunk:13439</pre></p></div></li>
<li>5. merge-missing-in-41-from-trunk_to_rails-4.1_at_r13451.patch:
<a href="#" onclick="$('#collapse-abb804ee-show, #collapse-abb804ee-hide').toggle(); $('#collapse-abb804ee').fadeToggle(150);; return false;" id="collapse-abb804ee-show" class="icon icon-collapsed collapsible">view details...</a><a href="#" onclick="$('#collapse-abb804ee-show, #collapse-abb804ee-hide').toggle(); $('#collapse-abb804ee').fadeToggle(150);; return false;" id="collapse-abb804ee-hide" class="icon icon-expended collapsible" style="display:none;">view details...</a><div id="collapse-abb804ee" class="collapsed-text" style="display:none;"><p>This only shows the merge tracking property changes; code changes are omitted to save some space... <br /><pre><code class="diff syntaxhl"><span class="gh">Index: .
===================================================================
</span><span class="gd">--- . (revision 13451)
</span><span class="gi">+++ . (working copy)
</span>
Property changes on: .
<span class="p">___________________________________________________________________
Modified: svn:mergeinfo
</span> Merged /trunk:r13284-13285,13287,13299,13303,13322-13327,13329-13331
<span class="gh">Index: ...
</span><span class="err">...</span>
...
</code></pre></p>
<p>Before this change, the svn:mergeinfo value for rails-4.1 branch was:<br /><pre>/trunk:13302,13306,13311,13332-13404,13409-13439</pre><br />after it, it looks like:<br /><pre>/trunk:13284-13285,13287,13299,13302-13303,13306,13311,13322-13327,13329-13404,13409-13439</pre></p></div></li>
</ul>
If these changes are applied then:
<ul>
<li>rails-4.1 branch contains <em>all</em> commits on trunk between the creation of the branch upto <a class="changeset" title="Japanese translation updated by Go MAEDA (#18069)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13439">r13439</a> (fully rebased)</li>
<li>svn:merginfo property was already introduced around 2.4-stable and custom_fields branch</li>
<li>svn:merginfo property is started being reliably used with 2.6-stable (last 2.x?)</li>
<li>svn:merginfo property is having full history of rails-4.1 and current trunk</li>
<li>svn:merginfo property is having full history of and is reliably used with new major 3.0-stable and up</li>
</ul>
<p>All the patches are taken against a checkout of the respective branches at <a class="changeset" title="Use relative URL for thumbnails according to :only_path option (#18119)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13451">r13451</a>. If more information is need, please let me know. I have a bunch of notes taken during the inspection, which I could attach if needed as well.<br />I hope this is of any use...</p>
<p>Regards,</p>
<p>Mischa.</p>
<p id="fn1" class="footnote"><sup>1</sup> <a class="changeset" title="Backport r13315 from rails-4.1 to trunk. Use .on() instead of .live()." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13407">r13407</a> and <a class="changeset" title="Backport r13313 from rails-4.1 to trunk. Upgrade to JQuery 1.11.1" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13408">r13408</a></p>
<p id="fn2" class="footnote"><sup>2</sup> <a class="changeset" title="add missing fixtures to test/unit/journal_test.rb" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13302">r13302</a>, <a class="changeset" title="add missing fixtures to SearchControllerTest" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13306">r13306</a>, <a class="changeset" title="add missing fixtures to SettingsControllerTest" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13311">r13311</a> and <a class="changeset" title="add missing fixtures to ChangesetTest" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13332">r13332</a></p>
<p id="fn3" class="footnote"><sup>3</sup> <a class="changeset" title="Add missing fixtures." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13296">r13296</a>, <a class="changeset" title="Upgrade to JQuery 1.11.1" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13313">r13313</a> and <a class="changeset" title="Use .on() instead of .live()." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13315">r13315</a></p>
<p id="fn4" class="footnote"><sup>4</sup> <a class="changeset" title="German translation updated by Daniel Felix (#17399)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13284">r13284</a>, <a class="changeset" title="Traditional Chinese translation updated by ChunChang Lo (#17421)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13285">r13285</a>, <a class="changeset" title="remove trailing white-spaces from app/models/user.rb" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13287">r13287</a>, <a class="changeset" title="Bulgarian translation updated by Ivan Cenov (#17451)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13299">r13299</a>, <a class="changeset" title="remove unneeded statement from Issue#parent_issue_id=" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13303">r13303</a>, <a class="changeset" title="Moved #link_to_version to ApplicationHelper (#17431)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13322">r13322</a>, <a class="changeset" title="Class mismatch when reloading in development mode (#17431)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13323">r13323</a>, <a class="changeset" title="Adds version date as title in #link_to_version (#17431)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13324">r13324</a>, <a class="changeset" title="Don't prepend project name if the version is not shared." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13325">r13325</a>, <a class="changeset" title="Use type="button" instead of return false; (#17401). Patch by Daniel Felix." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13326">r13326</a>, <a class="changeset" title="Typo (#17400). Patch by Daniel Felix." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13327">r13327</a>, <a class="changeset" title="Fixed that query roles are not copied when copying a project (#17202)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13329">r13329</a>, <a class="changeset" title="WARNING: Can't mass-assign protected attributes: user_id, type." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13330">r13330</a> and <a class="changeset" title="Japanese translation changed (custom fields) by Go MAEDA (#17456)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13331">r13331</a></p>
<p id="fn5" class="footnote"><sup>5</sup> config/locales/de.yml and Gemfile</p> Redmine - Patch #18059 (Resolved): Activity when issue change assigned to.https://www.redmine.org/issues/180592014-10-10T11:59:15ZMarcin Świątkiewicz
<p>Hi. There is patch to change activity for project. It's will shows you when issue status was changed, assigned_to was changed, and when status and assigned_to was changed together.</p>
<p>I wrote test for this and everything works fine.</p>
<p>See files.</p> Redmine - Patch #16314 (New): Redirect back is overheatedhttps://www.redmine.org/issues/163142014-03-11T13:09:40ZAnton Orel
<p>Take a look at these code lines:</p>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13036/entry/trunk/app/controllers/application_controller.rb#L368">source:trunk/app/controllers/application_controller.rb@13036#L368</a><br />It is not used at all.</p>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13036/entry/trunk/app/controllers/application_controller.rb#L399">source:trunk/app/controllers/application_controller.rb@13036#L399</a><br />It uses same functionality that method above (relies on HTTP_REFERER).</p>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13036/entry/trunk/app/helpers/application_helper.rb#L1100">source:trunk/app/helpers/application_helper.rb@13036#L1100</a><br />It could be replaced with `helper_method :back_url`.</p>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13036/entry/trunk/app/controllers/application_controller.rb#L390">source:trunk/app/controllers/application_controller.rb@13036#L390</a><br />This condition is never satisfied. I did not find an usage.</p> Redmine - Patch #15565 (New): Sidebar csshttps://www.redmine.org/issues/155652013-11-28T12:53:37ZKsenia Altbregen
<p>Related to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Use <li> tags for lists (Closed)" href="https://www.redmine.org/issues/13242">#13242</a>.</p>
<p>CSS for <ul> and <li> tags in #sidebar spoils our plugin.<br />I suggest to add a special class for <ul> and <li> elements that need zero margins.</p> Redmine - Patch #15390 (New): Simple Redmine Sub-directory Supporthttps://www.redmine.org/issues/153902013-11-19T03:44:00ZYehuda Katz
<p>This patch brings <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/HowTo_Install_Redmine_in_a_sub-URI">HowTo_Install_Redmine_in_a_sub-URI</a> up to Rails 3.<br />It seems that the routes are loaded before <code>config/environment.rb</code>, so putting the <code>Redmine::Utils::relative_url_root</code> there does not work because the scope of the routes has already been set. Each plugin needs to be modified with just the <code>scope</code>.</p>
<p>Tested on:<br /><pre>
Environment:
Redmine version 2.3.3.stable.12244
Ruby version 2.0.0-p247 (2013-06-27) [i686-linux]
Rails version 3.2.13
Environment production
Database adapter Mysql2
Redmine plugins:
redmine_inline_attach_screenshot 0.4.6
redmine_stealth 0.6.0
</pre><br />For the record, both plugins work fine with almost no modification.</p> Redmine - Patch #15234 (New): A popup message after session timeouthttps://www.redmine.org/issues/152342013-10-31T16:30:12ZKarel Pičman
<p>When the session timeout is set and a user leaves an unsaved form for a while so their session expires and clicks on the <em>Save</em> button, they is redirected to the login page and all unsaved data from the form just being edited are lost.</p>
<p>The same frustrating situation can happend when you write a long wiki page.</p>
<p>The flash message on the login page does't help to recover lost data.</p>
<p>I thing that the user should be warn before data are lost.</p>
<p>Please take into account the attached simple patch that add a Javascript popup message with the warning text about session expiration.</p> Redmine - Patch #14862 (New): Documents get paging and export functions https://www.redmine.org/issues/148622013-09-08T19:25:27ZHans-Georg von Detten
<p>Hi there,</p>
<p>this patch adds for documents</p>
<ul>
<li>paging on top and bottom
<ul>
<li>ordering changed to title alphabetical in category</li>
</ul>
</li>
<li>export functions like wiki</li>
</ul>
<p>works an version 2.3-stable</p>
<p>Who likes to test it or support me to setup the trunk version on Windows? So can I do it myself.</p>
<p>Thanks for Redmine<br />Best regards<br />Hans-Georg</p> Redmine - Patch #13413 (New): Let users choose how many days in advance they want to receive issu...https://www.redmine.org/issues/134132013-03-09T17:15:40ZJan from Planio www.plan.io
<p>Here at <a href="http://plan.io/redmine-hosting" class="external">Planio Hosted Redmine</a>, we've recently activated our version of the issue due date reminders that can be triggered via the <code>redmine:send_reminders</code> rake task.</p>
<p>Our users told us that they'd like to set the number of days before such reminders themselves individually rather than obeying the default set by the admin. Here's a patch for this against Redmine 1.4.7 that should be easily portable to current trunk. It doesn't contain tests in itself, just fixes the fixtures to keep current tests running.</p> Redmine - Patch #13359 (New): Better List-Id to help aid Gmail filteringhttps://www.redmine.org/issues/133592013-03-05T15:12:49ZJimmy Engelbrecht
<p>This gives the possibility to filer mail-updates from different project into different folders.</p>
<pre>
--- ./redmine-2.1.6/app/models/mailer.rb 2013-01-09 17:34:07.000000000 +0100
+++ /opt/redmine-2.1.6/app/models/mailer.rb 2013-03-05 15:33:38.438398984 +0100
@@ -386,7 +386,7 @@
'X-Auto-Response-Suppress' => 'OOF',
'Auto-Submitted' => 'auto-generated',
'From' => Setting.mail_from,
- 'List-Id' => "<#{Setting.mail_from.to_s.gsub('@', '.')}>"
+ 'List-Id' => "<#{@issue.project.identifier}.#{Setting.host_name}>"
# Removes the author from the recipients and cc
# if he doesn't want to receive notifications about what he does
</pre>
<p>The resulting List-Id could look like this:</p>
<pre>
List-Id: <cantemo-ab.vvv.cantemo.com>
</pre> Redmine - Patch #13068 (New): Allow plugins to generate test coverage reports on MRI 1.9https://www.redmine.org/issues/130682013-02-03T16:12:15ZHarry Garrood
<p>The attached patch adds a rake task redmine:plugins:coverage, which uses SimpleCov to generate plugin test coverage reports.</p> Redmine - Patch #12983 (New): "Only for things I watch or I'm involved in" sends notifications on...https://www.redmine.org/issues/129832013-01-25T14:05:20ZFelix Schäfer
<p>The e-mail notifications setting "Only for things I watch or I'm involved in" currently only sends notifications for issue updates. This has confused some of our (Plan.io) users because they didn't receive notifications for other things than issues they'd watch.</p>
<p>Patch is upcoming.</p> Redmine - Patch #12813 (New): Allow replies to original issue e-mail to add issue noteshttps://www.redmine.org/issues/128132013-01-11T15:04:13Zmark burdett
<p>When an issue is submitted to Redmine via e-mail, and a carbon-copied recipient replies to the original e-mail, the subject will not include the issue number. This reply (and future replies) result in the creation of additional new issues.</p>
<p>This patch allows the mail handler to lookup the issue by subject, and add the reply as a note on the original issue. If no matching issue is found, it falls back to adding a new issue.</p> Redmine - Patch #12338 (New): Allow MailHandler to submit to a specific issuehttps://www.redmine.org/issues/123382012-11-09T18:15:30ZChris Wilson
<p>We modified our mail server and Redmine so that we could send email to <a class="email" href="mailto:redmine-issue-NNNN@example.com">redmine-issue-NNNN@example.com</a> and it would be appended to that ticket number.</p>
<p>I'd like to see this feature rolled into Redmine so that it doesn't get broken by future upgrades. I think it's minor and easy and has no security implications.</p>
<p>On our mail server, we modified <code>rdm_mailhandler.rb</code> to add a <code>--number</code> option, that would be added to the <code>issue_attributes</code>:</p>
<pre>
chris@one-mail(exim)$ sudo diff -u /etc/exim/redmine/rdm-mailhandler.rb{.orig,}
--- /etc/exim/redmine/rdm-mailhandler.rb.orig 2012-11-09 18:09:58.000000000 +0000
+++ /etc/exim/redmine/rdm-mailhandler.rb 2012-11-09 17:33:51.000000000 +0000
@@ -87,6 +87,7 @@
[ '--project', '-p', GetoptLong::REQUIRED_ARGUMENT ],
[ '--status', '-s', GetoptLong::REQUIRED_ARGUMENT ],
[ '--tracker', '-t', GetoptLong::REQUIRED_ARGUMENT ],
+ [ '--number', '-n', GetoptLong::REQUIRED_ARGUMENT ],
[ '--category', GetoptLong::REQUIRED_ARGUMENT ],
[ '--priority', GetoptLong::REQUIRED_ARGUMENT ],
[ '--allow-override', '-o', GetoptLong::REQUIRED_ARGUMENT ],
@@ -106,7 +107,7 @@
self.verbose = true
when '--version'
puts VERSION; exit
- when '--project', '--status', '--tracker', '--category', '--priority'
+ when '--project', '--status', '--tracker', '--category', '--priority', '--number'
self.issue_attributes[opt.gsub(%r{^\-\-}, '')] = arg.dup
when '--allow-override'
self.allow_override = arg.dup
</pre>
<p>And on the Redmine server, we added some code to allow this flag to set the issue number to append to, in preference to the headers of the message itself:</p>
<pre>
chris@lap-x201:~/Dropbox/patches$ cat redmine_mail_handler.patch
--- app/models/mail_handler.rb.orig 2012-11-09 18:11:43.000000000 +0000
+++ app/models/mail_handler.rb 2012-11-09 17:56:48.000000000 +0000
@@ -86,7 +86,9 @@
def dispatch
headers = [email.in_reply_to, email.references].flatten.compact
- if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
+ if @@handler_options[:issue].has_key?(:number)
+ receive_issue_reply(@@handler_options[:issue][:number])
+ elsif headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
klass, object_id = $1, $2.to_i
method_name = "receive_#{klass}_reply"
if self.class.private_instance_methods.collect(&:to_s).include?(method_name)
</pre>
<p>Patches attached. I hope you will accept them.</p> Redmine - Patch #11500 (New): Add --unknown-user=register to create inactive usershttps://www.redmine.org/issues/115002012-07-24T12:54:54ZAlex Shulgin
<p>This patch adds a new value for the <code>--unknown-user</code> option of the mail handler script.</p>
<p>When given, it will behave similar to <code>--unknown-user=create</code>, but the user account will not be automatically activated. Depending on the site configuration, either token activation or manual activation by administrator will be required. The purpose is to help keep spam level low on public projects.</p>
<p>The change is a bit involved as it required moving the registration logic from accounts controller to the User model.</p> Redmine - Patch #11493 (New): Show URL to attached file in plain text issue emailhttps://www.redmine.org/issues/114932012-07-24T11:53:25ZAlex Shulgin
<p>Currently, only HTML issue updates contain full URLs to the attached files. This patch adds the attachment URLs to plain text email notifications.</p> Redmine - Patch #11057 (New): Confirm admin flag change on a separate pagehttps://www.redmine.org/issues/110572012-05-30T14:44:34ZAlex Shulgin
<p>Having admin flag on the general tab in user's profile makes it<br />way too easy to flip the flag accidentally.</p>
<p>Attached patch adds a separate page to flip the flag.</p> Redmine - Patch #9563 (New): PATCH: Add per-tracker global cc for issue creation and update notif...https://www.redmine.org/issues/95632011-11-13T23:12:04ZAlex Hornung
<p>Hi,</p>
<p>at DragonFly BSD we are migrating the bug tracker from roundup to redmine. We have a setup where the bugtracker is deeply integrated with two mailing lists, bugs@ and submit@. As such, we like updates on issues going to their respective mailing list.</p>
<p>The attached patch adds a per-tracker CC email address to which all updates to that tracker (both new issues and updates/edits) will be sent to.</p>
<p>Cheers,<br />Alex</p> Redmine - Patch #9319 (New): Prevent passing :label option to HTML tag in TabularFormBuilderhttps://www.redmine.org/issues/93192011-09-26T10:00:20ZAlex Shulgin
<p>See attached.</p> Redmine - Patch #9281 (New): easy logging of usernames in apache access logs via custom response ...https://www.redmine.org/issues/92812011-09-20T05:20:31ZRobert HaileyRedmine - Patch #8109 (New): Support for global permissions in acts_as_attachablehttps://www.redmine.org/issues/81092011-04-08T21:09:39ZAndriy Lesyuk
<p>If an attachment is to be shown (e.g. an image) outside a project, <code>view_permission</code> option does not work:<br /><pre><code class="ruby syntaxhl"><span class="n">acts_as_attachable</span> <span class="ss">:view_permission</span> <span class="o">=></span> <span class="ss">:view_attachments</span>
</code></pre></p>
<p>This happens because <code>acts_as_attachable</code> supports only project permissions. The attached patch adds support for global permissions as well...</p> Redmine - Patch #7770 (New): use unless in control structures where it improves readabilityhttps://www.redmine.org/issues/77702011-03-04T00:43:23ZAnonymous
<p>Use <strong>unless</strong> or <strong>until</strong> in control structures instead of <strong>if !</strong> or <strong>while !</strong> where it improves readability.</p> Redmine - Patch #7570 (New): Change test_helper requirement in testshttps://www.redmine.org/issues/75702011-02-07T16:57:36ZJean-Baptiste Barth
<p>In <a class="changeset" title="Use absolute paths in test/**/* requires for Ruby 1.9.2 compatibility. #4050" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4509">r4509</a> I changed the way test_helper was required in all our tests, so that tests could run on ruby 1.9.2 (ftr, ruby 1.9.2 no longer includes "." in $LOAD_PATH by default). This change was also made to ease test runs from command line (e.g. <code>ruby /path/to/one/test.rb</code>).</p>
<p>Gregor <a href="https://github.com/edavis10/redmine/commit/17f86d964fe05e677714baa35ec319abe13ae8bf#commitcomment-263250" class="external">said on github</a> that a simple <code>require 'test_helper'</code> would be good enough with ruby's <code>-I</code> flag.</p>
<p>Any thought about that ? If not, I'll replace them with simplers <code>require 'test_helper'</code>.</p> Redmine - Patch #7204 (New): Caching of public pages, requested from anonymous users (10x - 20x s...https://www.redmine.org/issues/72042010-12-31T02:47:32ZMassimo Zaniboni
<p>I need a quicker access for public pages, requested from anonymous users.</p>
<p>I can not use a caching reverse proxy because the web proxy does not know when a page is requested from a registered user, or when the page is requested from an anonymous user.</p>
<p>In this patch the Ruby/Redmine application controller returns a page from the cache with ~ 10x - 20x speedup respecting normal pages. The caching is applied only if the user is anonymous (not logged) and only if the page does not contains forms with an authenticity token.</p>
<p>The cached page is different according the locale of user, so different pages for different locales are returned correctly.</p>
<p>The Redmine administrator can configure the cache refresh rate using the main Settings form.</p>
<p>The caching is performed using the caching method specified in the config/additional_environment.rb file. I added something like</p>
<pre>
config.action_controller.perform_caching = true
config.action_controller.cache_store = :file_store, File.join(File.dirname(__FILE__), '../tmp/cache')
</pre>
<p>I tested the patch on version 1.0.5, but it is not yet on a server in production.</p>
<p>The patch can be applied to <a class="changeset" title="Fixes wrong Polish translation of "blocks" and "duplicates" (#6895)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4595">r4595</a> or Git commit:6659c630b264325</p>
Warnings / sorry in advance :-)
<ul>
<li>this is my first ruby code</li>
<li>this is my first ruby on rails code</li>
<li>I'm not a native english speaker, and probably my labels/texts is not completely correct</li>
</ul>
<p>Many thanks for the good product that is Redmine!</p> Redmine - Patch #6864 (New): Support of mail notification for changesetshttps://www.redmine.org/issues/68642010-11-11T00:35:30ZXiwen Cheng
<p>This patch closely resembles the traditional subversion hooks. The main difference is the recipients list is integrated with redmine: author exclusion and permissions. And maybe other SCM's also (tested with SVN).</p>
<p>I have tested it with plain text only, the html template needs improvements (render difference for instance).</p>
<p>TODO: ability to turn this off in project settings.</p> Redmine - Patch #6807 (New): internal hostname included in back_urlhttps://www.redmine.org/issues/68072010-11-02T18:17:33ZAlbert Rosenfield
<p>Hi</p>
<p>The documentation recommends that Redmine run behind a reverse proxy such as nginx for doing SSL and caching.</p>
<p>Is it on purpose that the internal URL ("localhost" in my case) rather than the external URL from Administration --> Settings --> General --> Host_name is exposed in this configuration?</p>
<p>Every time a user hits a page and is redirected to the login page, the back_url parameter in the query string contains the host "localhost".</p>
<p>Attached is a patch to fix this, in case it is not intentional.</p> Redmine - Patch #6450 (New): Allow localized date input and correctly transform for custom date f...https://www.redmine.org/issues/64502010-09-21T01:13:39ZStuart Cianos
<p>Patch allows users to manipulate custom date fields using their local format.</p>
<ul>
<li>Adds a library routine to the I18n extensions. The routine provides for the parsing of a user entered date into a Date object.</li>
<li>The custom value model has been upated to correctly account for the user's date setting (if available). If not, defaults to YYYY-MM-DD.</li>
</ul>
<p>This allows users to enter their dates in their localized format (as defined by setting.date_format), and have it correctly transformed to YYYY-MM-DD. If the localized setting is not available, falls back to YYYY-MM-DD for input.</p>
<p>This partially fixes defect <a class="issue tracker-1 status-1 priority-4 priority-default" title="Defect: Date input fields don't respect date format settings (New)" href="https://www.redmine.org/issues/668">#668</a> as it applies to custom fields. This was a major pain point for our users, so hopefully will solve a lot of problems experienced elsewhere.</p> Redmine - Patch #5722 (New): Custom Boolean Fields cannot be set to truehttps://www.redmine.org/issues/57222010-06-22T10:41:50ZVolker Gersabeck
<p>ruby 1.8.7<br />Rails 2.2.3<br />Redmine 0.9.3.stable (MySQL)</p>
<p>When having a custom boolean field for my issues, I was not able to set it to true since the hidden input value was used when updating the values instead of the checkbox value. Changing the order of the hidden input and the checkbox solved this issue. Just replace in /usr/share/redmine/app/helpers/custom_fields_helper.rb around line 47:</p>
<p>hidden_field_tag(field_name, '0') + check_box_tag(field_name, '1', custom_value.true?, :id => field_id)</p>
<p>by</p>
<p>check_box_tag(field_name, '1', custom_value.true?, :id => field_id) + hidden_field_tag(field_name, '0')</p> Redmine - Patch #5554 (New): Make links to various redmine objects more consistenthttps://www.redmine.org/issues/55542010-05-19T12:47:28ZHolger Just
Currently, there are at least two places where links to the different objects are generated:
<ul>
<li>the <code>link_to_OBJECT</code> methods in <code>application_helper.rb</code></li>
<li>the huge case statement in <code>parse_redmine_links</code> in <code>application_helper.rb</code></li>
</ul>
<p>Both of these places use independent code. This code should be merged into a consistent view. Today, both link types differ at least in its class attributes which makes themeing harder.</p>
<p>The attached patch fixes this for the <code>link_to_attachment</code> and the <code>link_to_revision</code> methods.</p> Redmine - Patch #5447 (New): User status can not be changed with javascript disabledhttps://www.redmine.org/issues/54472010-05-05T15:39:05ZHolger Just
<p>If an admin-user has javascript disabled, she can not update the status of a user.</p>
<p>The generated links (by <code>change_status_link</code>) require some javascript to turn the request into a POST. <code>/users/:id/edit</code> does not allow changing the state with a GET, which leaves the admin-user without further options.</p>
<p>The attached patch adds a status select box to the user edit form. This however does still not resolve the non-functioning of the change_status_link, but at least provides a workaround.</p> Redmine - Patch #5389 (New): Option redirect_to in UsersController#edit when a params :back is de...https://www.redmine.org/issues/53892010-04-27T16:03:39ZThales Ferreira
<p>Actually, in controller Users when a request of type post is send the last line in this method (line: 112 redirect_to :back) for me doesnt make sense.</p>
<p>It will usable if it wasnt redirect_to params[:back]. ???</p>
<p>I found this when i needed to redirect to last location in a user edit. <br />For example, im forcing the user to fill another custom fields from your user data, but i want to back to previous url when the user complete the remainder custom fields edit.</p> Redmine - Patch #5119 (New): "User group" custom fieldhttps://www.redmine.org/issues/51192010-03-18T16:19:41ZFri Flaj
<p>This patch adds a "user group" custom field that will allow selecting one the the existing user groups tied to the active project.</p> Redmine - Patch #4964 (New): Change sorting order globallyhttps://www.redmine.org/issues/49642010-03-02T13:27:07ZAaron Fischer
<p>Refactor the sorting order to change it globally on one place.<br />Patch included.</p> Redmine - Patch #4277 (New): Add "hide prefixed projectname from issuesubject on issuelist" settinghttps://www.redmine.org/issues/42772009-11-24T00:54:39ZMischa The Evil
<p>This issue is extracted from <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Better display of subprojects activiry and tickets. (Closed)" href="https://www.redmine.org/issues/3100">#3100</a> and it's relatives. The patch adds a new system-wide, issue-tracking setting (<code>hide_prefixed_projectname_from_issuesubject_on_issuelist</code>) which provides the administrator an option to hide the subproject name (which is prefixed in front of the issue descriptions on mainproject issue lists) completely.<br />Such a setting can be useful if the site is configured to display the <code>project</code>-column be default.</p>
<p>The default setting is equal to as it is currently(the projectnames are shown prefixed to the descriptions).</p> Redmine - Patch #4071 (New): Accept more input when replying to a ticket using e-mailhttps://www.redmine.org/issues/40712009-10-21T14:18:43ZOxan -
<p>Currently, you can only set the status field when you reply at a ticket using e-mail. This patch adds the possibility to change the priority, category, tracker, target version, done ratio, project and custom fields, with respecting the allow_override setting.</p>
<p>You can delete the target version field with setting it to 'none'. The target version is named Target and the done ratio is named Done.</p>
<p>Example mail:<br /><pre>Here your comment
Target: 0.9
Done: 50
Tracker: Defect
Priority: Low</pre></p>
<p>Diff is made against 0.8.6, but should work for trunk too.</p> Redmine - Patch #3901 (New): Make length of short project description customizablehttps://www.redmine.org/issues/39012009-09-22T12:10:26ZBernhard Furtmueller
<p>Introducing a configurable length of the short project description.</p>
<p>If you have many project with long descriptions some overview pages<br />get to long otherwise.</p>
<p>Thanks for feedback,<br />bernhard</p> Redmine - Patch #3754 (New): add some additional URL paths to robots.txthttps://www.redmine.org/issues/37542009-08-18T17:40:50Zmark burdett
<p>My apache logs show that some redmine URLs are being heavily indexed by robots, and it seems like it would be best to have them blocked by robots.txt:<br />/issues<br />/projects/*/time_entries<br />/projects/N/wiki/* (where N is the numeric project id)<br />/repositories/annotate/*<br />/repositories/browse/*<br />/repositories/changes/*<br />/repositories/diff/*<br />/repositories/entry/*</p> Redmine - Patch #3123 (Needs feedback): Check additional mail headers when creating issues via emailhttps://www.redmine.org/issues/31232009-04-05T15:54:45ZDuncan Harris
<p>We have a setup with Redmine where users often send mail using different from addresses in the email. We use Google Apps for email, but this would apply to other mail systems where users can set up multiple from addresses in their email.</p>
<p>If users send email with a different from address than their registered one then Redmine ignores the incoming email.</p>
<p>To fix this issue I created the attached modification which checks the mail headers "Return-Path", "Sender" and finally "From" (as before) for a match to a user account.</p>
<p>The "Return-Path" header relies on getting mail server to set this to the envelope sender address. I use the preline program with qmail to get this set.</p>
<p>This works because Google Apps email (and GMail) always set the Sender and envelope sender addresses to the users main or canonical email address even if they choose a different "From" address.</p> Redmine - Patch #2576 (New): Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/25762009-01-24T22:17:36ZBrad Beattie
<p>The application_helper.rb directly accesses the Gravatar function by email. I would argue that it would be better to instead use vendor/plugins/gravatar/lib/gravatar.rb's gravatar_for function with the user object.</p>
<p>The situation I have here is that my local instance has modified the Gravatar plugin to use locally stored avatars linked by email address (as dictated by application_helper.rb). Occasionally, users change their email addresses, which requires renaming their avatar files. If the change I proposed was implemented, this local avatar plugin would be doable. Without it, the avatar system is intrinsically tied to email addresses.</p>
<p>I'm not sure what patch formats you prefer, so here's the proposed change:</p>
<pre><code class="ruby syntaxhl"><span class="k">def</span> <span class="nf">avatar</span><span class="p">(</span><span class="n">user</span><span class="p">,</span> <span class="n">options</span> <span class="o">=</span> <span class="p">{</span> <span class="p">})</span>
<span class="k">if</span> <span class="no">Setting</span><span class="p">.</span><span class="nf">gravatar_enabled?</span>
<span class="k">return</span> <span class="n">gravatar_for</span><span class="p">(</span><span class="n">user</span><span class="p">)</span> <span class="k">unless</span> <span class="n">user</span><span class="p">.</span><span class="nf">mail</span><span class="p">.</span><span class="nf">blank?</span> <span class="k">rescue</span> <span class="kp">nil</span>
<span class="k">end</span>
<span class="k">end</span>
</code></pre>
<p>Apologies if my syntax is wrong. I'm so very, very new to Ruby.</p> Redmine - Patch #2195 (New): wiki marco to link to fileshttps://www.redmine.org/issues/21952008-11-15T16:34:35ZAnh Kỳ Huỳnh
<p>I create an wiki macro so I can link to attachment file easier:<br /><pre>
{{file(id:Title)}}
{{file(id/filename:Title)}}
</pre></p>
<p>I don't know how to get the filename from the file's identity. I hope the someone may help me:)</p>
<p>Hope this is usefull :)</p> Redmine - Patch #2016 (New): Tracker Moves of an Issue should create an entry in the activityhttps://www.redmine.org/issues/20162008-10-09T18:27:31ZKarl Heinz Marbaise
<p>During a test with Redmine (dev) i have moved an entry from being an Feature to a Bug (Tracker), but there has no entry in the activity log appeared. My opinion is to have an entry for this kind of change.</p> Redmine - Patch #2013 (New): Skip notification of issue's updating.https://www.redmine.org/issues/20132008-10-09T05:32:09ZYuki Shida
<p>This patch add checkbox into issue's edit form.</p>
<pre>
[] skip notification
</pre>
<p>If you update issue with checking this checkbox,<br />notification is skipped.</p> Redmine - Patch #1764 (New): Add session_config option-stubs to environment-confighttps://www.redmine.org/issues/17642008-08-11T01:56:41ZMischa The Evil
<p>This is a multi-branch (trunk and stable-0.7.3) patch which simply adds two session-related configuration-directive stubs to <em>./config/environment.rb</em>.</p>
The given stubs are for:
<ul>
<li><code>session_key</code></li>
<li><code>session_path</code></li>
</ul>
<p>I created (and provide) this patch due to the fact that one of both directives is required to run multiple Redmine (or other apps which use the same session-names as Redmine) deployments on the <strong>same domain</strong> (though <strong>seperate installs</strong> under several <strong>different sub-URI's</strong>) without suffering from <em>session-mangling</em>.<br />Both directives aren't documented (sufficiently) imho at the Redmine website or the Redmine Code-base. That is the reason why I'd propose to add something like provided with this patch. If it is not taken into the project I would propose to add an entry to the Redmine FAQ about these issues. I am volunteering already... :-)</p>
I already found some related issues and threads:
<ul>
<li><a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Append suffix to cookie name (Closed)" href="https://www.redmine.org/issues/540">#540</a></li>
<li><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: login problem with 2 redmine installation on the same server (Closed)" href="https://www.redmine.org/issues/1041">#1041</a></li>
<li><a class="external" href="http://www.redmine.org/boards/2/topics/show/150#message-163">http://www.redmine.org/boards/2/topics/show/150#message-163</a></li>
</ul>
<p>Both issues contain comments which faulty "documents" the session_key directive. This faultyness is due to the fact that rake will crash if the session_key directive is used in <em>./config/enviroment.rb</em> as commented in both issues probably caused by the rake-scripts which aren't accepting Rails 2.1 syntaxis.<br />The mentioned forum-thread gives to correct syntaxis though it is mixed with another config-directive in some another case.</p>
<p><strong>Beware</strong>: This patch only adds config-stubs which solves the session-mangling behaviour in the given environment. It does not fix any related problems with the so-called autologin-cookie. I created a sepereate specific issue for that (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Autologin-cookie should be configurable (Closed)" href="https://www.redmine.org/issues/1763">#1763</a>).<br />See also <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Append suffix to cookie name (Closed)" href="https://www.redmine.org/issues/540">#540</a> and partly <a class="issue tracker-2 status-1 priority-3 priority-lowest" title="Feature: option to set secure flag on session and autologin cookie (New)" href="https://www.redmine.org/issues/982">#982</a> regarding the problems with the autologin-cookie.</p> Redmine - Patch #1616 (New): Allow email to create and reply to forum messageshttps://www.redmine.org/issues/16162008-07-10T00:37:03ZJoshua Hoover
<a name="Summary"></a>
<h2 >Summary<a href="#Summary" class="wiki-anchor">¶</a></h2>
<p>This is a patch for <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Add mailing lists (New)" href="https://www.redmine.org/issues/277">#277</a> that provides the ability to send messages to forums via email. This gives Redmine a mailing list like capability by utilizing the work done in <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Allow email to create issue or add comment (Closed)" href="https://www.redmine.org/issues/1110">#1110</a> (Allow email to create issue or add comment), which has been available since <a class="changeset" title="IMAP: fetch unseen messages only." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1572">r1572</a>. By enabling this functionality users can create new and reply to existing forum messages that will be sent out via email to all those who are <em>watching</em> that forum.</p>
<a name="Configuration"></a>
<h2 >Configuration<a href="#Configuration" class="wiki-anchor">¶</a></h2>
<p>There are two areas of configuration for this feature. One is how you get emails into Redmine and the other is an optional configuration to set a different <em>emission email address</em> specifically for forum emails.</p>
<a name="Receiving-Forum-Message-Emails-for-Redmine-Processing"></a>
<h3 >Receiving Forum Message Emails for Redmine Processing<a href="#Receiving-Forum-Message-Emails-for-Redmine-Processing" class="wiki-anchor">¶</a></h3>
<p>In order to receive emails into Redmine the documentation found <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails">here</a> should be used. This documentation covers specific settings for creating issues within Redmine. The only issue attribute that applies to this patch is the project attribute. If you set the project attribute. I have done my functional testing using the IMAP setup. The rake command looks something like this:</p>
<pre>
rake redmine:email:receive_imap host=imap.domain.com port=XXX ssl=true username=username@domain.com password=password_here RAILS_ENV=_production_
</pre>
<p>Using the IMAP setup, you must schedule the rake command to run on a regular basis using cron or another job scheduling mechanism.</p>
<a name="Forum-Emission-Email-Address"></a>
<h3 >Forum Emission Email Address<a href="#Forum-Emission-Email-Address" class="wiki-anchor">¶</a></h3>
<p>If you want to use a different <em>reply-to</em> email address for forum messages than you use for other emails sent from Redmine, then you'll need to do the following:</p>
<ol>
<li>Login to your Redmine instance as an Administrator</li>
<li>Click the <em>Administration</em> link at the top of the page</li>
<li>Click on the <em>Settings</em> link</li>
<li>Click on the <em>Email Notifications</em> tab</li>
<li>Enter the email address for forum emails in the <em>Forum emission email address</em> field
<ul>
<li>This email address should go to the email account receiving forum emails (configured above in the <em>Receiving Forum Message Emails for Redmine Processing</em> section)</li>
</ul>
</li>
<li>Click the <em>Save</em> button</li>
</ol>
<a name="User-Documentation"></a>
<h2 >User Documentation<a href="#User-Documentation" class="wiki-anchor">¶</a></h2>
<p>The following describes how to make use of the email to forum functionality.</p>
<a name="How-to-Create-a-New-Forum-Message-via-Email"></a>
<h3 >How to Create a New Forum Message via Email<a href="#How-to-Create-a-New-Forum-Message-via-Email" class="wiki-anchor">¶</a></h3>
<p>In order to create a new forum message, you simply address an email to the email address specified in either the Adminitration->Settings->Email Notifications <em>Forum emission email address</em> field (if populated) or the <em>Emission email address</em> (if the the <em>Forum emission email address</em> field is not populated). The subject of the email should be in the format of:</p>
<p>[Project Name - Forum Name] Forum message subject goes here</p>
<p>The format of the email body is not important. The script that processes the forum emails is setup to determine the project and forum names based on the email subject.</p>
<a name="How-to-Reply-to-a-Forum-Message-via-Email"></a>
<h3 >How to Reply to a Forum Message via Email<a href="#How-to-Reply-to-a-Forum-Message-via-Email" class="wiki-anchor">¶</a></h3>
<p>This is pretty simple. When you receive an email of a forum message you simply reply to the message and write your reply in the body of the email. One important thing to note is that you <strong>SHOULD NOT</strong> change the subject line if you want the email to be recognized as a reply to an existing forum message. The script that processes the forum emails is setup to determine the original forum message being replied to by the portion of the subject that follows the square brackets.</p>
<a name="Receive-Forum-Message-Emails-in-Your-Email-Inbox"></a>
<h3 >Receive Forum Message Emails in Your Email Inbox<a href="#Receive-Forum-Message-Emails-in-Your-Email-Inbox" class="wiki-anchor">¶</a></h3>
<p>In case it's not clear how you receive forum messages, I'm adding that info here. The best way to subscribe to receive emails for a particular forum is to:</p>
<ol>
<li>Click on the <em>Forums</em> tab in Redmine</li>
<li>Click on the name of the forum you want to subscribe to</li>
<li>Click on the <em>Watch</em> link so that the star icon turns yellow</li>
</ol>
<p>You can also subscribe to all forums (and all other Redmine email notifications) by clicking on the <em>My account</em> link in the upper right hand of the page and then select <em>For any event on all my projects</em> from the drop down menu under the <em>Email notifications</em> section.</p> Redmine - Patch #1587 (New): Simple Phone Number and Address List for Usershttps://www.redmine.org/issues/15872008-07-05T21:30:10ZJamie Hardt
<p>This patch adds a "Contact" tab to the normal user edit page, and within this provides a mailing address list and phone number list; many addresses and numbers may be added to a user based on locations such as "home," "work" etc. I'm not sure if this is completely within the scope of the project, and, but I provide it as is with the hope that it's useful.</p>
The changes from <a class="issue tracker-1 status-8 priority-4 priority-default" title="Defect: redmine sends http on forms on https server (Reopened)" href="https://www.redmine.org/issues/1628">#1628</a> are roughly as follows
<ul>
<li>A migration adding a table to hold address and phone number data.</li>
<li>Several model classes to represent extended contact data:"Address", "PhoneNumber", "ImAccount" and "ContactUrl". These inherit from an "AddressMultiValue" base ActiveRecord class and all use the single table added by the migration.</li>
<li>A tab is added to the user view helper code, along with a partial for viewing the contacts</li>
<li>Simple views for adding new contacts and addresses</li>
<li>Unit and functional tests for these, with some fixtures</li>
</ul>
Some things that could be done to improve this further include:
<ul>
<li>Allow editing of addresses and phone numbers; at this time you may only add new or delete existing.</li>
<li>Import from CSV or vCard</li>
<li>Export to PDF/CSV/vCard</li>
<li>Provide a list of default location values thru a combobox</li>
</ul> Redmine - Patch #1568 (New): Added Support for htpasswd authenticationhttps://www.redmine.org/issues/15682008-07-03T12:32:24ZRobert Shell
<p>In moving from trac wanted to keep same htpasswd based authorization so passwords in sync with subversion. To do this have added new AuthSource and forms to support this.</p>
Key Changes
<ul>
<li>Added AuthSourceFile</li>
<li>Modified User to pass password to auth_source for update</li>
<li>Added passwd and passwd? methods to add/update users and passwords in auth_source</li>
<li>Change auth_sources views to support multiple subtypes</li>
</ul> Redmine - Patch #1382 (New): Add a global notification cc https://www.redmine.org/issues/13822008-06-05T07:27:21ZJames Turnbull
<p>We cc'ed all notifications to a mailing list when we were using Trac and I wanted to add the same functionality to Redmine. Attached is a patch that adds a global cc to all notifications and adds a setting, mail_cc, to the Email Notifications settings panel.</p> Redmine - Patch #1333 (New): Patch for membership activity (#1195)https://www.redmine.org/issues/13332008-05-30T19:26:51ZMateo Murphy
<p>Here is a patch for implementing a log of membership activity; people added and removed from projects, and having their roles changed. This information will show up in the activity log of the project page if you have the "View Membership Activity" permission.</p>
<p>The diff was created against <a class="changeset" title="Additional test for r1481." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1482">r1482</a>.</p> Redmine - Patch #811 (New): Username validation - allow spaces...https://www.redmine.org/issues/8112008-03-08T00:57:34ZJason Milkins
<p>I've tested a very simple patch with a test installation of RedMine to allow usernames with spaces.</p>
<p>I have modified the RegEx in app/models/user.rb ...<br /><pre>
validates_format_of :login, :with => /^[a-z0-9_\-@\.]*$/i
</pre></p>
<p>to</p>
<pre>
validates_format_of :login, :with => /^[a-z0-9 _\-@\.]*$/i
</pre>
<p>After running a number of simple tests (as follows)</p>
<ul>
<li>Login</li>
<li>LDAP autogenerate user</li>
<li>Add Issue </li>
<li>List Issues</li>
<li>Filter Issues</li>
<li>View Activity</li>
<li>View Homepage</li>
<li>Add Member to Project</li>
<li>Assign Issue To</li>
</ul>
<p>I have experienced no problems with this patch.</p>
<p>After a reviewing a reasonable amount of code it appears that db:user/id is used for the username xref'ing and the visible login name is only used for display and initial login.</p>
<p>Is there any further rationale for disallowing spaces in usernames?</p>
<a name="Here-is-my-rationale-for-usernames-which-include-spaces"></a>
<h3 >Here is my rationale for usernames which include spaces.<a href="#Here-is-my-rationale-for-usernames-which-include-spaces" class="wiki-anchor">¶</a></h3>
<p>My need for spaced usernames is linked to deployment, esp. with auto generating accounts with LDAP. Our Windows AD was setup with <strong>First Last</strong> style logins... and so we have to go through the process of user education if we are going to use an alternative LDAP property, in our case MailNickname, to login.</p>
<p>As you can appreciate logging in with their accustomed username would be a far easier solution, in terms of human engineering.</p>
<p>I think this would be helpful to a number of possible enterprise users too.</p> Redmine - Patch #251 (New): Patch for Feature Request #9785 (Default issues due date == assigned ...https://www.redmine.org/issues/2512008-01-18T11:54:00ZElliot Winkler
<p>This patch makes it so that if a new issue is assigned to a version, but the end date isn't specified, the end date<br />is automatically filled in with the end date of the version.</p>
<p>(I hope the diff is in the right format, I've never really done this before)</p> Redmine - Patch #247 (New): Notification mail sender is the author and includes project information.https://www.redmine.org/issues/2472008-01-08T04:34:00ZHans Yoon
<p>(1) Like TRAC,<br />each mail notification has its own header, so it helps mail client filter mails easier.<br />The mail header is "X-redmine-project".</p>
<p>(2) When mail is notificated, default mail sender is fixed as administrator has defined. With this patch, most of mail<br />message is sent from event generating user.</p>