https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292012-04-11T12:57:13ZRedmineRedmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=373392012-04-11T12:57:13ZEtienne Massip
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul><p>Even lost the end of the text.</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374042012-04-13T17:13:33ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>File</strong> <a href="/attachments/7461">projects.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/7461/projects.png">projects.png</a> added</li></ul><p>Can't reproduce with current trunk. Tested with default and classic themes, using FF11.0, Chrome 18 or IE9.</p>
<p><img src="https://www.redmine.org/attachments/download/7461/projects.png" alt="" /></p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374052012-04-14T00:06:17ZHansen Ler
<ul></ul><p>Maybe there's some fix in between? Let me test when there's new release...<br />that's super fast response from jean! Cheers!</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374172012-04-14T07:30:51ZEtienne Massip
<ul></ul><p>No, I reproduced with trunk but with only a part of the text you posted.</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374202012-04-14T07:38:35ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>No, I reproduced with trunk but with only a part of the text you posted.</p>
</blockquote>
<p>Which part exactly?</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374212012-04-14T07:40:29ZEtienne Massip
<ul></ul><p>Well, the last part I think but I'll check again.</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374222012-04-14T07:43:24ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/37422/diff?detail_id=27504">diff</a>)</li></ul><p>Got it.</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374232012-04-14T08:01:57ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>This is a textile issue. This text generates invalid html (closing tags at the end are in reverse order).</p>
<p>Here is a patch that fixes it:</p>
<pre>
Index: lib/redcloth3.rb
===================================================================
--- lib/redcloth3.rb (revision 9405)
+++ lib/redcloth3.rb (working copy)
@@ -585,9 +585,10 @@
last_line = line_id
end
if line_id - last_line > 1 or line_id == lines.length - 1
- depth.delete_if do |v|
+ depth.reverse.each do |v|
lines[last_line] << "</li>\n\t</#{ lT( v ) }l>"
end
+ depth = []
end
end
lines.join( "\n" )
</pre> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=374242012-04-14T08:05:17ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>1.4.1</i></li></ul> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=375172012-04-18T12:01:55ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>If your Project Description uses bullets, viewing Projects page will cause the next project in list to Break</i> to <i>Nested textile ol/ul lists genrate invalid HTML</i></li><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fixed in <a class="changeset" title="Fixed that textile nested lists are not properly closed in output (#10642)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/9430">r9430</a>.</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=375282012-04-18T17:03:44ZEtienne Massip
<ul><li><strong>Subject</strong> changed from <i>Nested textile ol/ul lists genrate invalid HTML</i> to <i>Nested textile ol/ul lists generate invalid HTML</i></li></ul><p>Typo.</p> Redmine - Defect #10642: Nested textile ol/ul lists generate invalid HTMLhttps://www.redmine.org/issues/10642?journal_id=375302012-04-18T17:41:39ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged.</p>