https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-05-07T11:34:48ZRedmineRedmine - Patch #1202: Feature to view whole the file from /repositories/revision pagehttps://www.redmine.org/issues/1202?journal_id=26622008-05-07T11:34:48ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/513">view_the_whole_file_patch.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/513/view_the_whole_file_patch.txt">view_the_whole_file_patch.txt</a> added</li></ul><p>Sorry, I forgot to attach the patch.</p> Redmine - Patch #1202: Feature to view whole the file from /repositories/revision pagehttps://www.redmine.org/issues/1202?journal_id=26732008-05-08T00:22:33ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/519">view_the_whole_file_patch_0508.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/519/view_the_whole_file_patch_0508.txt">view_the_whole_file_patch_0508.txt</a> added</li></ul><p>Updated my patch.<br />I found that link to /repositories/annotate/ is more usuful for code review.</p> Redmine - Patch #1202: Feature to view whole the file from /repositories/revision pagehttps://www.redmine.org/issues/1202?journal_id=33982008-06-17T21:28:31ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Category</strong> set to <i>SCM</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>0.8</i></li></ul><p>As of <a class="changeset" title="Makes changes link to entries on the revision view." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1552">r1552</a>, each change is a link to the whole file.</p> Redmine - Patch #1202: Feature to view whole the file from /repositories/revision pagehttps://www.redmine.org/issues/1202?journal_id=48412008-09-18T12:10:18ZMarc Liyanage
<ul><li><strong>File</strong> <a href="/attachments/950">redmine-changeset_r1552-edited.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/950/redmine-changeset_r1552-edited.diff">redmine-changeset_r1552-edited.diff</a> added</li></ul><p>I applied <a class="changeset" title="Makes changes link to entries on the revision view." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1552">r1552</a> to the 0.7.3 sources because we really like this feature.</p>
<p>When I compare that changeset to the patch here I notice two differences:</p>
<p>1.) This patch has a without_leading_slash() call in the link construction logic, but <a class="changeset" title="Makes changes link to entries on the revision view." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1552">r1552</a> does not and indeed I had to add it to the patch I apply, <a class="changeset" title="Makes changes link to entries on the revision view." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1552">r1552</a> as applied creates broken links for me. Why was that taken out, is it no longer needed against the sources targeting 0.8?</p>
<p>2.) This patch creates "annotate" URLs but <a class="changeset" title="Makes changes link to entries on the revision view." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1552">r1552</a> does not, it creates "entry" URLs. I agree with Go MAEDA that annotate is nice and more useful. Is there a reason that was not used as suggested in this patch?</p>
<p>The patch I apply looks like the attached file.</p>