https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-01-10T20:25:25ZRedmineRedmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=440512013-01-10T20:25:25ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>Non-admin users cannot get info about groups</i> to <i>View group members by non-admin users</i></li></ul> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=997312020-11-15T03:14:48ZGo MAEDA
<ul></ul><p>+1</p>
<p>The following code allows users to see group members according to "Users visibility" setting (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Prevent users from seeing other users based on their project membership (Closed)" href="https://www.redmine.org/issues/11724">#11724</a>) of their role.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb
index fb21e2f05..68fa826c9 100644
</span><span class="gd">--- a/app/controllers/groups_controller.rb
</span><span class="gi">+++ b/app/controllers/groups_controller.rb
</span><span class="p">@@ -21,7 +21,7 @@</span> class GroupsController < ApplicationController
layout 'admin'
self.main_menu = false
- before_action :require_admin
<span class="gi">+ before_action :require_admin, :except => [:show]
</span> before_action :find_group, :except => [:index, :new, :create]
accept_api_auth :index, :show, :create, :update, :destroy, :add_users, :remove_user
@@ -50,6 +50,8 @@ class GroupsController < ApplicationController
end
def show
<span class="gi">+ return render_404 unless @group.visible?
+
</span> respond_to do |format|
format.html
format.api
</code></pre> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=997352020-11-15T13:34:25ZGo MAEDA
<ul><li><strong>File</strong> <i>0001-Allow-non-admin-users-to-see-group-members-when-the-.patch</i> added</li><li><strong>File</strong> <a href="/attachments/26246">0002-Add-link-from-group-name-to-group-page.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26246/0002-Add-link-from-group-name-to-group-page.patch">0002-Add-link-from-group-name-to-group-page.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26247">link-from-group-name-to-group-page.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26247/link-from-group-name-to-group-page.png">link-from-group-name-to-group-page.png</a> added</li><li><strong>File</strong> <a href="/attachments/26248">group-page.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26248/group-page.png">group-page.png</a> added</li></ul><p>The attached patches implement the feature.</p>
<ul>
<li>A user can see /groups/:id page that displays group members if the group is visible for the user. The visibility of the group follows "Users visibility" setting of roles</li>
<li>Adds links from group names to /groups/:id page</li>
</ul>
<p><img src="https://www.redmine.org/attachments/download/26247/link-from-group-name-to-group-page.png" style="border: 1px solid grey;width: 1024px;" alt="" /></p>
<p><img src="https://www.redmine.org/attachments/download/26248/group-page.png" style="border: 1px solid grey;width: 424px;" alt="" /></p> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1028232021-06-12T07:56:51ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/27572">0001-Allow-non-admin-users-to-see-group-members-when-the-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27572/0001-Allow-non-admin-users-to-see-group-members-when-the-.patch">0001-Allow-non-admin-users-to-see-group-members-when-the-.patch</a> added</li></ul><p>Updated the patch. Make the page layout consistent with the user profile page.</p> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1028242021-06-12T07:57:03ZGo MAEDA
<ul><li><strong>File</strong> deleted (<del><i>0001-Allow-non-admin-users-to-see-group-members-when-the-.patch</i></del>)</li></ul> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1029072021-06-22T08:29:12ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1031962021-07-11T02:24:02ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.0.0</i></li></ul><p>Setting the target version to 5.0.0.</p> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1032552021-07-19T15:15:43ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch.</p>
<p>Non-admin users can see group members by clicking a group name on the project overview page.</p> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1032672021-07-20T21:42:48ZGo MAEDA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Committed the patch.</p>
<p>Non-admin users can see group members by clicking a group name on the project overview page.</p>
</blockquote>
<p>Also, the assignee field now shows a link to the group page if the assignee is a group (<a class="changeset" title="Link from assignee to group page (#12795)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21075">r21075</a>).</p> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1039712021-08-28T07:24:58ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/35823">Defect #35823</a>: undefined method `+' for nil:NilClass</i> added</li></ul> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1089732023-01-02T18:17:25ZHolger Just
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/38144">Patch #38144</a>: Refactoring: Use Group.visible instead of manual visibility check in GroupsController</i> added</li></ul> Redmine - Feature #12795: View group members by non-admin usershttps://www.redmine.org/issues/12795?journal_id=1089752023-01-02T18:17:43ZHolger Just
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-1 priority-4 priority-default" href="/issues/37994">Patch #37994</a>: Unify link to user/group in application helper</i> added</li></ul>