https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-01-25T14:20:16ZRedmineRedmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=449562013-01-25T14:20:16ZFelix Schäfer
<ul><li><strong>File</strong> <a href="/attachments/8909">0001-Get-notified-about-other-watched-things-than-issues-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/8909/0001-Get-notified-about-other-watched-things-than-issues-.patch">0001-Get-notified-about-other-watched-things-than-issues-.patch</a> added</li></ul><p>Patch is attached.</p> Redmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=450982013-01-28T16:39:07ZJan Niggemann (redmine.org team member)jan.niggemann@redmine.org
<ul></ul>Hi Felix,<br />just to make sure I understand the scenario correctly:
<ol>
<li>User 1 sets watch=yes on something else than an issue, say, a wiki page</li>
<li>User 2 changes that wiki page</li>
<li>User 1 does not get a mail</li>
</ol>
<p>I just tested this on 2.2.1 and I got a mail...<br />Edit: "Only for things I watch or I'm involved in" being my preference, of course.</p> Redmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=450992013-01-28T18:34:26ZFelix Schäfer
<ul></ul><p>In your scenario, if user 1 has the email notification setting on "Only for things I watch or I'm involved in", he won't get an email. The german translation is a little misleading because it says "Only for issues I watch or I'm involved in", the french translation is also misleading because it says "Only for things I watch".</p> Redmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=451042013-01-28T21:10:58ZJan Niggemann (redmine.org team member)jan.niggemann@redmine.org
<ul></ul><p>Felix Schäfer wrote:</p>
<blockquote>
<p>The german translation is a little misleading because it says "Only for issues I watch or I'm involved in",</p>
</blockquote>
<p>It reads 'Aufgaben'... I agree, that should be corrected...</p>
<blockquote>
<p>the french translation is also misleading because it says "Only for things I watch".</p>
</blockquote>
<p>Just like the french version, I'll include that.</p>
<blockquote>
<p>In your scenario, if user 1 has the email notification setting on "Only for things I watch or I'm involved in", he won't get an email.</p>
</blockquote>
<p>I checked that <a class="user active" href="https://www.redmine.org/users/54972">Fyfnjkbq Rjxytd</a> this afternoon and well, I got a mail...<br />I just tested at home and, alas, no mail.<br />The difference being that <a class="user active" href="https://www.redmine.org/users/54972">Fyfnjkbq Rjxytd</a> my user is an administrator...</p>
<p>I'll re-check tomorrow <a class="user active" href="https://www.redmine.org/users/54972">Fyfnjkbq Rjxytd</a>.</p> Redmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=451162013-01-29T07:41:14ZEtienne Massip
<ul></ul><p>The current implementation states that it's only about Issues so changing it require an update of this statement, all the different case to be dealt with and some unit tests for "things" other than issues.</p> Redmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=451272013-01-29T15:29:34ZFelix Schäfer
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>The current implementation states that it's only about Issues so changing it require an update of this statement, all the different case to be dealt with and some unit tests for "things" other than issues.</p>
</blockquote>
<p>The statement is in the code, yes, but the email notifications options don't reflect that (except in the german translation).</p>
<p>I first wanted to hear the consensus about this issue before fixing everything around it. If you say this is OK for core I'll happily update the patch to correct the comment, tests and german, french and english translations. If you think this shouldn't go into Redmine, I obviously don't need to do the work :-)</p> Redmine - Patch #12983: "Only for things I watch or I'm involved in" sends notifications only for issueshttps://www.redmine.org/issues/12983?journal_id=537852013-12-12T14:53:04ZFelix Schäfer
<ul></ul><p>Any news on this?</p>