https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-08-01T07:56:24ZRedmineRedmine - Patch #14593: migrate_from_trac.rake, print out validation errors when doing savehttps://www.redmine.org/issues/14593?journal_id=509282013-08-01T07:56:24ZCraig Rodrigues
<ul></ul><p>Note, in my patch, I change this:</p>
<p>Time.fake(ticket.changetime) { i.save }</p>
<p>to:</p>
<p>unless i.save</p>
<p>In my patch for <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: migrate_from_trac.rake does not convert timestamps in Trac database version 23 (New)" href="https://www.redmine.org/issues/14567">#14567</a> , I got rid of Time.fake,<br />because I found it did not work all the time and was not necessary.</p>
<p>I am trying to separate my patches to migrate_from_trac.rake<br />into smaller pieces that can be more easily reviewed and integrated into the Redmine<br />codebase.</p> Redmine - Patch #14593: migrate_from_trac.rake, print out validation errors when doing savehttps://www.redmine.org/issues/14593?journal_id=509292013-08-01T07:56:34ZToshi MARUYAMA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-1 priority-4 priority-default" href="/issues/14567">Patch #14567</a>: migrate_from_trac.rake does not convert timestamps in Trac database version 23</i> added</li></ul> Redmine - Patch #14593: migrate_from_trac.rake, print out validation errors when doing savehttps://www.redmine.org/issues/14593?journal_id=515852013-09-04T09:49:27ZMarc Schlaich
<ul></ul><p>I would say the sane solution is to run the complete script in a database transaction so in case of an error everything is just rolled back. It should be a everything or nothing import strategy. see <a class="issue tracker-1 status-1 priority-4 priority-default" title="Defect: migrate_from_trac is not run in database transaction (New)" href="https://www.redmine.org/issues/14844">#14844</a></p> Redmine - Patch #14593: migrate_from_trac.rake, print out validation errors when doing savehttps://www.redmine.org/issues/14593?journal_id=524632013-10-13T04:28:31ZCraig Rodrigues
<ul><li><strong>File</strong> <a href="/attachments/10603">migrate_from_trac.rake.patch.2.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/10603/migrate_from_trac.rake.patch.2.txt">migrate_from_trac.rake.patch.2.txt</a> added</li></ul><p>Here is another version of the patch. This patch does not depend on <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: migrate_from_trac.rake does not convert timestamps in Trac database version 23 (New)" href="https://www.redmine.org/issues/14567">#14567</a><br />and just adds more verbose error messages around places where it tries to save to the database.</p>