https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-10-13T23:59:47ZRedmineRedmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=525192013-10-13T23:59:47ZMischa The Evil
<ul></ul><p>The affected methods are <code>MyController#reset_rss_key</code>, <code>User#rss_key</code> and <code>User.find_by_rss_key</code>.</p>
<p>Daniel Felix wrote in <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: All translations: RSS -> Atom (Closed)" href="https://www.redmine.org/issues/13460#note-8">#13460-8</a> (note-8):</p>
<blockquote>
<p>Hopefully the way I use to deprecate those methods is good enough for the implementation. :-)</p>
</blockquote>
Pretty much I think, though some of the deprecation warnings used in the patch are not correct:
<ol>
<li>the warning for <code>MyController#reset_rss_key</code> reads:<br /><pre>"My#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use #reset_atom_key instead."</pre> this should be<br /><pre>"MyController#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use MyController#reset_atom_key instead."</pre></li>
<li>the warning for <code>User#rss_key</code> reads:<br /><pre>"User.rss_key is deprecated and will be removed in Redmine 3.0. Please use User.atom_key instead."</pre> this should be<br /><pre>"User#rss_key is deprecated and will be removed in Redmine 3.0. Please use User#atom_key instead."</pre></li>
</ol>
For 1:
<ul>
<li><code>My#reset_rss_key</code> says that <code>reset_rss_key</code> is an instance method of <code>My</code> (suggesting that <code>My</code> is an existing model in the Redmine core, which isn't), whereas the change you've made is in the <code>reset_rss_key</code> instance method of <code>MyController</code></li>
<li>I think it is better to include the class name when redirecting (in text obviously :) the user to the new, replacing method</li>
</ul>
For 2:
<ul>
<li><code>User.rss_key</code> refers to a <em>class</em> method in the <code>User</code> class, while in the Redmine core <code>rss_key</code> is an <em>instance</em> method in the <code>User</code> class</li>
</ul> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=525222013-10-14T00:06:53ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/13460">Patch #13460</a>: All translations: RSS -> Atom</i> added</li></ul> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1038742021-08-22T08:52:40ZMischa The Evil
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.0.0</i></li></ul><p>Shall we finally properly deprecate this in 5.0.0 and remove it in subsequent minor 5.x.x release (e.g. 5.1.0 or 5.2.0)?</p> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1039032021-08-23T23:59:53ZGo MAEDA
<ul></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>Shall we finally properly deprecate this in 5.0.0 and remove it in subsequent minor 5.x.x release (e.g. 5.1.0 or 5.2.0)?</p>
</blockquote>
<p>I agree.</p> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1039272021-08-25T02:53:51ZMischa The Evil
<ul></ul><p>Go, do you need a new, rebased patch file or do you prefer to do the search and replace and the addition of the deprecation messages (modified according to my comments in note#1) locally yourself?</p> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1059802022-03-18T21:24:33ZMarius BĂLTEANU
<ul><li><strong>File</strong> <i>0001-Deprecate-and-rename-rss_-methods-to-atom_-methods-1.patch</i> added</li></ul><p>Updated the patch for current trunk.</p> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1059892022-03-19T07:54:28ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-Deprecate-and-rename-rss_-methods-to-atom_-methods-1.patch</i></del>)</li></ul> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1059972022-03-19T09:56:46ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul><p>Patch committed, thanks!</p> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1060052022-03-19T10:36:28ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/36806">Patch #36806</a>: Remove rss_* deprecated methods</i> added</li></ul> Redmine - Patch #15118: Deprecate and rename rss_* methods to atom_* methodshttps://www.redmine.org/issues/15118?journal_id=1060172022-03-19T12:31:04ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>