https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-07-04T08:02:49ZRedmineRedmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=37292008-07-04T08:02:49ZPaul Rivier
<ul></ul>I agree, but what would a "table" button insert ? Two '|' ? We would probably need something a bit more evolved for such a button, such as a pop-up window asking for
<ul>
<li>number of rows</li>
<li>number of columns</li>
<li>use headers ? (checkbox)</li>
</ul>
<p>Once the template syntax is inserted, it probably becomes more natural to fill the cells and tweak it by hand.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=37352008-07-04T20:58:02ZKonrad Kosmowski
<ul></ul><p>Paul Rivier wrote:</p>
<blockquote>
<p>I agree, but what would a "table" button insert ?</p>
</blockquote>
<p>It could work like in MS Word or OpenOffice.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=44742008-08-25T12:01:25ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li></ul> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=645612015-06-30T02:05:43ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/12734">Feature #12734</a>: Add table reference to textile help</i> added</li></ul> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=962322020-02-13T01:10:16ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Markup help and toolbars lacks tables</i> to <i>Toolbar button to insert a table</i></li><li><strong>Category</strong> changed from <i>Wiki</i> to <i>Text formatting</i></li><li><strong>Priority</strong> changed from <i>Low</i> to <i>Normal</i></li></ul><p>Since markup help already has information about tables (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add table reference to textile help (Closed)" href="https://www.redmine.org/issues/12734">#12734</a>), I am changing the subject of this issue.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=963242020-02-19T05:31:26ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/24853">feature-1575.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24853/feature-1575.patch">feature-1575.patch</a> added</li><li><strong>File</strong> <a href="/attachments/24855">use-table-generator.gif</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24855/use-table-generator.gif">use-table-generator.gif</a> added</li></ul><p>The attached patch adds a button to insert a table into the wiki toolbar.<br />The button create a table with rows / columns according to the selected range.</p>
<p><img src="https://www.redmine.org/attachments/download/24855/use-table-generator.gif" style="width: 70%;border: 1px solid #ccc;" alt="" /></p>
<p>Markdown:<br /><pre>
|A |B |C |D |E |
|--|--|--|--|--|
| | | | | |
| | | | | |
| | | | | |
</pre></p>
<p>Textile:<br /><pre>
|_.A|_.B|_.C|_.D|_.E|
| | | | | |
| | | | | |
| | | | | |
</pre></p>
<p>Currently no icon image is set for the button. It is necessary to create a new appropriate icon image.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=963252020-02-19T06:01:25ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=963832020-02-21T06:19:02ZHiroyuki ENDO
<ul><li><strong>File</strong> <a href="/attachments/24873">image.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24873/image.png">image.png</a> added</li></ul><p>I made a new icon image.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=963842020-02-21T06:37:04ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/24875">use-table-icon.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24875/use-table-icon.png">use-table-icon.png</a> added</li><li><strong>File</strong> <a href="/attachments/24876">0001-feature-1575-patch-with-table-icon.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24876/0001-feature-1575-patch-with-table-icon.patch">0001-feature-1575-patch-with-table-icon.patch</a> added</li></ul><p>Hiroyuki ENDO wrote:</p>
<blockquote>
<p>I made a new icon image.</p>
</blockquote>
<p>Thank you for making the icon.<br />The icon looks very nice!</p>
<p>Screenshot when <a class="attachment" href="https://www.redmine.org/attachments/24873">image.png</a> is applied:<br /><img src="https://www.redmine.org/attachments/download/24875/use-table-icon.png" alt="" /></p>
<p>Updated the patch to use <a class="attachment" href="https://www.redmine.org/attachments/24873">image.png</a> as table button icon.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=963852020-02-21T07:17:16ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/24877">0001-feature-1575-patch-with-table-icon.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24877/0001-feature-1575-patch-with-table-icon.patch">0001-feature-1575-patch-with-table-icon.patch</a> added</li></ul><p>Fixed a patch.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=964272020-02-26T00:33:31ZKevin Fischer
<ul><li><strong>File</strong> <a href="/attachments/24884">Screen Shot 2020-02-26 at 9.27.58 AM.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24884/Screen%20Shot%202020-02-26%20at%209.27.58%20AM.png">Screen Shot 2020-02-26 at 9.27.58 AM.png</a> added</li><li><strong>File</strong> <a href="/attachments/24885">Screen Shot 2020-02-26 at 9.32.36 AM.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24885/Screen%20Shot%202020-02-26%20at%209.32.36%20AM.png">Screen Shot 2020-02-26 at 9.32.36 AM.png</a> added</li></ul><p>Unfortunately the grid lines of the selection UI are not properly displayed in Firefox.</p>
<p><strong>Chrome:</strong><br /><img src="https://www.redmine.org/attachments/download/24885/Screen%20Shot%202020-02-26%20at%209.32.36%20AM.png" alt="" /></p>
<p><strong>Firefox:</strong><br /><img src="https://www.redmine.org/attachments/download/24884/Screen%20Shot%202020-02-26%20at%209.27.58%20AM.png" alt="" /></p>
<p>This seems to be a long running bug of Firefox though: <a class="external" href="https://bugzilla.mozilla.org/show_bug.cgi?id=688556">https://bugzilla.mozilla.org/show_bug.cgi?id=688556</a></p>
<p>There seem to be workarounds, like using <pre>background-clip: padding-box;</pre> on the cells... But then it looks a little bit strange on Chrome on the other hand</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=964292020-02-26T02:25:38ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/24886">0002-Firefox-support.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24886/0002-Firefox-support.patch">0002-Firefox-support.patch</a> added</li><li><strong>File</strong> <a href="/attachments/24887">0003-IE11-support.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24887/0003-IE11-support.patch">0003-IE11-support.patch</a> added</li></ul><p>Kevin Fischer wrote:</p>
<blockquote>
<p>Unfortunately the grid lines of the selection UI are not properly displayed in Firefox.</p>
</blockquote>
<p>Thanks for sharing the information!!<br />Operation verification on browsers other than Chrome was insufficient.<br />Since a problem was found not only in Firefox but also in IE11, a patch that solves the problem is attached.</p>
<p><a class="attachment" href="https://www.redmine.org/attachments/24886">0002-Firefox-support.patch</a> resolves Firefox by removing <strong>`td { position: relative; }`</strong>.<br /><a class="attachment" href="https://www.redmine.org/attachments/24887">0003-IE11-support.patch</a> avoids using repeat function that did not work in IE11.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=964692020-02-29T04:53:46ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>Setting the target version to 4.2.0.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=965082020-03-02T07:17:43ZJan from Planio www.plan.io
<ul></ul><p>I really like this patch. Great work!</p>
<p>For the icon, I think <a href="http://www.famfamfam.com/lab/icons/silk/" class="external">famfamfam</a> should be used to stay consistent with the style of other icons in Redmine.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=965382020-03-03T09:55:59ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/24932">table-icon-1.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24932/table-icon-1.png">table-icon-1.png</a> added</li><li><strong>File</strong> <a href="/attachments/24933">table-icon-2.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24933/table-icon-2.png">table-icon-2.png</a> added</li></ul><p>Jan from Planio <a class="external" href="http://www.plan.io">www.plan.io</a> wrote:</p>
<blockquote>
<p>For the icon, I think <a href="http://www.famfamfam.com/lab/icons/silk/" class="external">famfamfam</a> should be used to stay consistent with the style of other icons in Redmine.</p>
</blockquote>
<p>Thank you for the feedback. I think the suggested table icon is better than famfamfam's table icon because famfamfam's table icon looks like a document.</p>
<p><strong>The suggested icon:</strong><br /><img src="https://www.redmine.org/attachments/download/24932/table-icon-1.png" style="border: 1px solid grey;width: 816px;" alt="" /></p>
<p><strong>famfamfam's table icon:</strong><br /><img src="https://www.redmine.org/attachments/download/24933/table-icon-2.png" style="border: 1px solid grey;width: 816px;" alt="" /></p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=965572020-03-04T01:18:22ZMizuki ISHIKAWA
<ul></ul><p>I also prefer <a class="attachment" href="https://www.redmine.org/attachments/24873">image.png</a>.<br />The famfamfam's icon does not look like a table because each cell is too small to identify.</p> Redmine - Feature #1575: Toolbar button to insert a tablehttps://www.redmine.org/issues/1575?journal_id=965702020-03-04T14:01:52ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for improving Redmine.</p>