https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-08-10T13:09:46ZRedmineRedmine - Defect #17581: Drag & Drop does not work with Safari 5.1https://www.redmine.org/issues/17581?journal_id=579792014-08-10T13:09:46ZToshi MARUYAMA
<ul><li><strong>Category</strong> set to <i>Attachments</i></li><li><strong>Target version</strong> set to <i>2.4.7</i></li></ul> Redmine - Defect #17581: Drag & Drop does not work with Safari 5.1https://www.redmine.org/issues/17581?journal_id=579802014-08-10T13:09:58ZToshi MARUYAMA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/13932">Defect #13932</a>: File upload does not work with Safari</i> added</li></ul> Redmine - Defect #17581: Drag & Drop does not work with Safari 5.1https://www.redmine.org/issues/17581?journal_id=582532014-08-26T07:34:22ZEtienne Massip
<ul></ul><p>Why remove the <code>'FileReader' in window</code> test?</p> Redmine - Defect #17581: Drag & Drop does not work with Safari 5.1https://www.redmine.org/issues/17581?journal_id=583702014-09-01T08:31:27ZToshi MARUYAMA
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>Why remove the <code>'FileReader' in window</code> test?</p>
</blockquote>
<p>fred, could you give us the answer?</p> Redmine - Defect #17581: Drag & Drop does not work with Safari 5.1https://www.redmine.org/issues/17581?journal_id=584382014-09-05T20:40:28Zfred bregar
<ul></ul><p><code>FileReader</code> is not needed. (Search repo for FileReader)</p>
<p>Checking for <code>FileReader</code> was simply a hack for Safari 5.1 to return <code>false</code>. <code>FileReader</code> is for actually reading a file in a browser (like dragging a text file into the browser and creating a <code><textarea></code> tag and displaying contents of the file). Redmine is not reading the contents of the File, just uploading it.</p>
<p>a better test would be:<br /><pre><code class="js syntaxhl"><span class="k">if</span> <span class="p">(</span><span class="nx">$</span><span class="p">.</span><span class="nx">ajaxSettings</span><span class="p">.</span><span class="nx">xhr</span><span class="p">().</span><span class="nx">upload</span> <span class="o">&&</span> <span class="nx">inputEl</span><span class="p">.</span><span class="nx">files</span><span class="p">)</span>
<span class="c1">//but this instantiates a new XMLHttpRequest object and does nothing with it.</span>
</code></pre></p>
<p>but like i said (<a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: File upload does not work with Safari (Closed)" href="https://www.redmine.org/issues/13932#note-13">#13932-13</a>) the real problem is jQuery. jQuery <em>was</em> amazing, but unless you need to support IE8 and below there is really no need for it these days.</p> Redmine - Defect #17581: Drag & Drop does not work with Safari 5.1https://www.redmine.org/issues/17581?journal_id=586772014-09-14T17:32:16ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed in trunk, 2.5-stable and 2.4-stable, thanks.</p>