https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-09-12T05:10:56ZRedmineRedmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=585932014-09-12T05:10:56ZJean-Baptiste Barth
<ul></ul><p>No problem merging that as long as it has some more tests for failing strings we introduce... and for good ones too, as I can't find tests in <code>test/unit/mail_handler_test.rb</code>. Maybe it's time to refactor the logic in <code>MailHandler#dispatch</code> too. Felix: can you handle that ? Thanks!</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=586082014-09-12T07:55:31ZFelix Schäfer
<ul></ul><p>Jean-Baptiste Barth wrote:</p>
<blockquote>
<p>No problem merging that as long as it has some more tests for failing strings we introduce... and for good ones too, as I can't find tests in <code>test/unit/mail_handler_test.rb</code>.</p>
</blockquote>
<p>Sure, can you assign it back to me so that I can remember it? Thanks :-)</p>
<blockquote>
<p>Maybe it's time to refactor the logic in <code>MailHandler#dispatch</code> too.</p>
</blockquote>
<p>I'll see about that, but I guess it's out of scope for this ticket.</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=586122014-09-12T14:02:19ZJean-Baptiste Barth
<ul><li><strong>Assignee</strong> set to <i>Felix Schäfer</i></li></ul><p>Here we go!</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=588462014-09-25T17:30:07ZFelix Schäfer
<ul></ul><p>Jean-Baptiste, there's already tests for good strings of sorts with the test that try to import emails and make sure they've been imported correctly. I fear the best I can do would be to provide 1 or 2 examples of incoming emails that should fail, or even with bad and good strings pointing to different issues.</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=588472014-09-25T17:53:24ZFelix Schäfer
<ul><li><strong>File</strong> <a href="/attachments/12392">better_incoming_email_issue_id_recognition_with_tests.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/12392/better_incoming_email_issue_id_recognition_with_tests.patch">better_incoming_email_issue_id_recognition_with_tests.patch</a> added</li></ul><p>Here's a patch with 2 test-emails containing subjects with strings we don't want to match anymore pointing to the wrong issue and strings we want to match pointing to the right one.</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=597892014-11-14T19:33:23ZFrank Paaske
<ul></ul><p>Is this planned to be included in a release soon? I think this would make the email integration with OTRS much simpler!</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=597932014-11-14T20:43:36ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Improve incoming email issue subject recognition</i> to <i>MailHandler should ignore bogus issue strings [some-string#1234] in subject</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>2.6.1</i></li></ul><p>Fix committed in <a class="changeset" title="Ignore bogus issue strings like [some-string#1234] in email subjects (#17705)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13593">r13593</a> with tests edited, thanks.</p> Redmine - Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subjecthttps://www.redmine.org/issues/17705?journal_id=599512014-11-22T10:43:06ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged.</p>