https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-09-22T03:22:14ZRedmineRedmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=587792014-09-22T03:22:14ZYonghwan SO
<ul></ul><p>Oops! I read wiki <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/Contribute">Contribute</a> now. I will not make pull request on github. sorry.</p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1037882021-08-17T00:34:06ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/27902">0001-Structure-the-document-list.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27902/0001-Structure-the-document-list.patch">0001-Structure-the-document-list.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27903">0002-Structure-the-document-show-page.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27903/0002-Structure-the-document-show-page.patch">0002-Structure-the-document-show-page.patch</a> added</li></ul><p>+1<br />I'm developing a Redmine theme. Document module pages are difficult to customize.</p>
<p>I will attach a patch with a slightly increased hierarchy in consideration of customizing with the theme. I also added a class for each element.<br /><pre>
h2. Document
div#document-list
div.document-group
h3.group-name Technical documentation
div.document-item
h4.title My First Document
div.updated-on updated time
div.description Description
div.document-item
h4.title My Second Document
div.updated-on updated time
div.description Description2
div.document-group
div.document-item
...
</pre></p>
<p>I think the document list and how the document display page should be structured.<br /><a class="attachment" href="https://www.redmine.org/attachments/27905">0002-Structure-the-document-show-page.patch</a> changes the structure of the document display page as follows:<br /><pre>
h2.title My First Document
div#document-details
div.attributes
div.category-name
div.created-on
ul.document-custom-field-values
li
div.description
div.attachemnts-area
</pre></p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1037892021-08-17T01:31:54ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/27904">0001-Structure-the-document-list.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27904/0001-Structure-the-document-list.patch">0001-Structure-the-document-list.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27905">0002-Structure-the-document-show-page.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27905/0002-Structure-the-document-show-page.patch">0002-Structure-the-document-show-page.patch</a> added</li></ul><p>Fix the test code.</p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1037962021-08-17T05:59:27ZMischa The Evil
<ul></ul><p><a class="user active" href="https://www.redmine.org/users/41705">汪婷 汪</a>: This seems a good improvement to me. Maybe you can add some screenshots to show the actual result?</p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1038012021-08-17T06:51:53ZMizuki ISHIKAWA
<ul></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p><a class="user active" href="https://www.redmine.org/users/41705">汪婷 汪</a>: This seems a good improvement to me. Maybe you can add some screenshots to show the actual result?</p>
</blockquote>
<p>Thanks for your feedback.<br />This patch changes the HTML structure, not the design of the documentation pages.<br />I think that attaching a screenshot of the screen is not helpful for the review as it is the same view as before the change.</p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1038032021-08-17T07:41:33ZMischa The Evil
<ul></ul><p>Mizuki ISHIKAWA wrote:</p>
<blockquote>
<p>Mischa The Evil wrote:</p>
<blockquote>
<p><a class="user active" href="https://www.redmine.org/users/41705">汪婷 汪</a>: This seems a good improvement to me. Maybe you can add some screenshots to show the actual result?</p>
</blockquote>
<p>[...]<br />This patch changes the HTML structure, not the design of the documentation pages.<br />I think that attaching a screenshot of the screen is not helpful for the review as it is the same view as before the change.</p>
</blockquote>
<p>My bad, you're right. I got distracted and finally mislead by the combination of the words <cite>increased hierarchy</cite> along with the indentation of the HTML structure examples given in the initial post and in your note. Nevermind me asking about this...</p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1038102021-08-17T12:49:22ZGo MAEDA
<ul><li><strong>Category</strong> changed from <i>UI</i> to <i>Documents</i></li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1038582021-08-22T02:31:12ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.0.0</i></li></ul><p>Setting the target version to 5.0.0.</p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1052272022-01-16T04:25:48ZGo MAEDA
<ul></ul><p>Thank you for posting the patch. I noticed the following points:</p>
<ul>
<li>The CSS class "document-group-*" that includes the document category name does not work for Unicode characters. For example, if a document category has a name "未分類" (means "uncategorized" in Japanese), the class name will be "document-group-". If all category names are consist of Unicode characters, they will have the same class name "document-group-". How about using <code>group.id</code> instead of <code>group.to_s.parameterize</code>?</li>
<li>I think it is better to rename "document-group-*" to "document-category" (see <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/config/locales/en.yml#L1316">source:trunk/config/locales/en.yml#L1316</a>)</li>
</ul> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1054492022-01-26T01:46:21ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/28745">0001-Structure-the-document-list.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/28745/0001-Structure-the-document-list.patch">0001-Structure-the-document-list.patch</a> added</li><li><strong>File</strong> <a href="/attachments/28746">grouping_options.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/28746/grouping_options.png">grouping_options.png</a> added</li></ul><p>Updated 0001-Structure-the-document-list.patch.</p>
<p>Go MAEDA wrote:</p>
<blockquote>
<ul>
<li>The CSS class "document-group-*" that includes the document category name does not work for Unicode characters. For example, if a document category has a name "未分類" (means "uncategorized" in Japanese), the class name will be "document-group-". If all category names are consist of Unicode characters, they will have the same class name "document-group-". How about using <code>group.id</code> instead of <code>group.to_s.parameterize</code>?</li>
</ul>
</blockquote>
<p>Thank you for your feedback.<br />I tried to use group.id, but when the sort condition is title or date, it returns a String object.<br />In particular, it was difficult to convert the title group to Unicode, so I decided not to give a unique class name to the group. <br />Even without class names like <strong>document-group-{}</strong>, I think the clean structure will be enough to make CSS easier to write.</p>
<blockquote>
<ul>
<li>I think it is better to rename "document-group-*" to "document-category" (see <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/config/locales/en.yml#L1316">source:trunk/config/locales/en.yml#L1316</a>)</li>
</ul>
</blockquote>
<p>The document category is one of the grouping options. You can also group by Author, Date, and Title. Therefore, I don't think it is appropriate to change .document-group to .document-category.<br /><img src="https://www.redmine.org/attachments/download/28746/grouping_options.png" style="width: 200px;border: 1px solid #ccc;" alt="" /></p> Redmine - Patch #17924: Structured Document list for more flexible UI design with CSShttps://www.redmine.org/issues/17924?journal_id=1055702022-02-08T02:40:30ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed the patch. Thank you.</p>