https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-12-09T09:42:36ZRedmineRedmine - Defect #18605: Wrong usage of logger.info to test log levelhttps://www.redmine.org/issues/18605?journal_id=603072014-12-09T09:42:36ZJérôme BATAILLE
<ul></ul><p>Sorry I missed a closing pre Tag !</p> Redmine - Defect #18605: Wrong usage of logger.info to test log levelhttps://www.redmine.org/issues/18605?journal_id=603542014-12-12T21:07:06ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/60354/diff?detail_id=45452">diff</a>)</li></ul><p>Jérôme BATAILLE wrote:</p>
<blockquote>
<p>logger.info (instead of logger.info?) can trigger an error</p>
</blockquote>
<p>In which circumstances?</p> Redmine - Defect #18605: Wrong usage of logger.info to test log levelhttps://www.redmine.org/issues/18605?journal_id=603872014-12-14T21:21:16ZJérôme BATAILLE
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>In which circumstances?</p>
</blockquote>
<p>In fact it can't because nil is managed as the default value.</p>
<p>But logger.info always return true (<a class="external" href="http://www.ruby-doc.org/stdlib-2.0/libdoc/logger/rdoc/Logger.html#method-i-add">http://www.ruby-doc.org/stdlib-2.0/libdoc/logger/rdoc/Logger.html#method-i-add</a>), so you can't use logger.info to detect if info level is enabled.</p> Redmine - Defect #18605: Wrong usage of logger.info to test log levelhttps://www.redmine.org/issues/18605?journal_id=603892014-12-14T21:54:35ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Typo in app/controllers/timelog_controller.rb</i> to <i>Wrong usage of logger.info to test log level</i></li><li><strong>Category</strong> changed from <i>Time tracking</i> to <i>Code cleanup/refactoring</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> set to <i>3.0.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fixed in <a class="changeset" title="Use logger.info? (#18605)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13766">r13766</a> with another one, thanks.</p> Redmine - Defect #18605: Wrong usage of logger.info to test log levelhttps://www.redmine.org/issues/18605?journal_id=603902014-12-14T21:56:39ZJérôme BATAILLE
<ul></ul><p>Thanks a lot again ! :-)</p>