https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292015-01-14T07:24:37ZRedmineRedmine - Defect #18832: Activity Stream Filter missing on right hand side due to permissionhttps://www.redmine.org/issues/18832?journal_id=608312015-01-14T07:24:37ZMischa The Evil
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li></ul><p>Confirmed solely based on a quick code-review. This seems to be a remnant of the days where the use of <code>acts_as_activity_provider</code> with an <em>implicit :permission</em> option (in fact: <code>"view_#{o}".to_sym</code>) was prevailing and accepted. This has changed already a long time ago in <a class="changeset" title="Makes activity providers use visible scopes." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/5325">r5325</a> (Redmine <a class="version" href="https://www.redmine.org/versions/27">1.2.0</a>).</p>
I think that <code>Redmine::Activity::Fetcher#event_types</code> should check <code>@user.allowed_to?</code> for three cases:
<ol>
<li><code>"view_#{o}".to_sym</code> permission [This is currently the only checked case, it seems viable to retain it as a default; in my opinion this does not have to block the actual removal of the long deprecated feature of using <code>acts_as_activity_provider</code> with an implicit :permission option.]</li>
<li>a specific <code>:permission</code> that is declared as part of the <code>acts_as_activity_provider</code> call</li>
<li>a <code>visible</code> scope on the <code>#{self.name}</code> model</li>
</ol>
<p>Are there some other things to consider?</p> Redmine - Defect #18832: Activity Stream Filter missing on right hand side due to permissionhttps://www.redmine.org/issues/18832?journal_id=608322015-01-14T07:37:26ZWilliam Schey
<ul></ul><p>Not that I can think of. This would definitely fix my issue.</p>
<p>Thanks Mischa.</p> Redmine - Defect #18832: Activity Stream Filter missing on right hand side due to permissionhttps://www.redmine.org/issues/18832?journal_id=609342015-01-18T09:10:05ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> set to <i>3.0.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>This should be fixed in <a class="changeset" title="Fixed that Redmine::Activity::Fetcher should consider activity provider permission option if give..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13895">r13895</a>. If given, the permission option will be checked in order to display the item in the sidebar, instead of the default "view_*" permission.</p>