https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292015-05-19T20:48:59ZRedmineRedmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=637812015-05-19T20:48:59ZFuture Link Corporation pkgsrc team
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-2 status-5 priority-3 priority-lowest closed" href="/issues/19886">Feature #19886</a>: Raise wiki edits comments limit to 1024</i> added</li></ul> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=637842015-05-19T20:52:41ZFuture Link Corporation pkgsrc team
<ul></ul><p>Here is a patch for <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/app/views/timelog/_form.html.erb">source:/trunk/app/views/timelog/_form.html.erb</a> as well:</p>
<p><a href="#" onclick="$('#collapse-e33942a8-show, #collapse-e33942a8-hide').toggle(); $('#collapse-e33942a8').fadeToggle(150);; return false;" id="collapse-e33942a8-show" class="icon icon-collapsed collapsible">Click to expand patch...</a><a href="#" onclick="$('#collapse-e33942a8-show, #collapse-e33942a8-hide').toggle(); $('#collapse-e33942a8').fadeToggle(150);; return false;" id="collapse-e33942a8-hide" class="icon icon-expended collapsible" style="display:none;">Click to expand patch...</a><div id="collapse-e33942a8" class="collapsed-text" style="display:none;"><pre>
<code class="diff syntaxhl"><span class="gd">--- app/views/timelog/_form.html.erb.orig 2015-05-17 13:01:37.000000000 -0400
</span><span class="gi">+++ app/views/timelog/_form.html.erb 2015-05-19 13:45:35.876821092 -0400
</span><span class="p">@@ -17,7 +17,7 @@</span>
</p>
<p><%= f.text_field :spent_on, :size => 10, :required => true %><%= calendar_for('time_entry_spent_on') %></p>
<p><%= f.text_field :hours, :size => 6, :required => true %></p>
<span class="gd">- <p><%= f.text_field :comments, :size => 100, :maxlength => 255 %></p>
</span><span class="gi">+ <p><%= f.text_field :comments, :size => 100, :required => true, :maxlength => 1024 %></p>
</span> <p><%= f.select :activity_id, activity_collection_for_select_options(@time_entry), :required => true %></p>
<% @time_entry.custom_field_values.each do |value| %>
<p><%= custom_field_tag_with_label :time_entry, value %></p>
</code><br /></pre></div></p>
<p>Again, noting that we're making the field mandatory, which might not be what you want (<abbr title="point of least authority">POLA</abbr>).</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=642582015-06-18T06:02:27ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>"comments" of "time_entries" is defined as 255.<br /><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/tags/3.0.3/db/migrate/032_create_time_entries.rb#L8">source:tags/3.0.3/db/migrate/032_create_time_entries.rb#L8</a></p>
<p>I think you changed manually.</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=642732015-06-18T15:37:46ZFuture Link Corporation pkgsrc team
<ul></ul><p>Yes, you are correct. We did. Can that field be made longer by default? The length of 255 characters is rather short and doesn't allow for detailed time entries.</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=649062015-07-17T16:49:59ZToshi MARUYAMA
<ul></ul><p>See <a class="changeset" title="Raised maximum length of project names and identifiers to 255 and 100 respectively (#6446)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4402">r4402</a>.</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=649082015-07-17T17:06:11ZFuture Link Corporation pkgsrc team
<ul></ul><p>The diff you referenced doesn't apply to the time entries <code>comment</code> field.</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=649142015-07-18T02:49:28ZToshi MARUYAMA
<ul></ul>If you want to modify db definition, you need to make db migrate file.
<ul>
<li><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/db/migrate/20101114115114_change_projects_name_limit.rb">source:trunk/db/migrate/20101114115114_change_projects_name_limit.rb</a></li>
<li><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/db/migrate/20101114115359_change_projects_identifier_limit.rb">source:trunk/db/migrate/20101114115359_change_projects_identifier_limit.rb</a></li>
</ul> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=649372015-07-20T14:09:47ZFuture Link Corporation pkgsrc team
<ul></ul><p>Yes, I understand that and we've done it. The point is that the stock password length between what the view allows and what the DB allows, by default, don't match. Thus, these comments get limited unnecessarily. Same deal for <a class="issue tracker-2 status-5 priority-3 priority-lowest closed" title="Feature: Raise wiki edits comments limit to 1024 (Closed)" href="https://www.redmine.org/issues/19886">#19886</a>. Please, apply these patches in this issue and <a class="issue tracker-2 status-5 priority-3 priority-lowest closed" title="Feature: Raise wiki edits comments limit to 1024 (Closed)" href="https://www.redmine.org/issues/19886">#19886</a>.</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=649382015-07-20T14:52:38ZToshi MARUYAMA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Feature</i></li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li></ul><p>Because there is no completed patch, I change tracker.</p> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=649412015-07-20T14:55:51ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>3.2.0</i></li></ul> Redmine - Feature #19885: Raise time entries comments limit to 1024https://www.redmine.org/issues/19885?journal_id=661202015-09-21T21:00:53ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Comment field length for time entries is unnecessarily short</i> to <i>Raise time entries comments limit to 1024</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Limit raised to 1024 in <a class="changeset" title="Raises time entries comments limit to 1024 (#19885)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/14621">r14621</a>.</p>