https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292015-07-12T12:28:21ZRedmineRedmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=647962015-07-12T12:28:21ZGo MAEDA
<ul></ul><p>I tried to apply your patch but I encountered the following error.</p>
<pre>
$ patch -p1 < divgrid
patching file app/views/roles/permissions.html.erb
patching file app/views/trackers/fields.html.erb
patching file app/views/workflows/permissions.html.erb
patch: **** malformed patch at line 472: diff -ruN redmine-2.6.5/app/views/workflows/index.html.erb redmine/app/views/workflows/index.html.erb
</pre> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=647992015-07-12T14:01:10ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/13938">divgrid</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/13938/divgrid">divgrid</a> added</li></ul> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=648002015-07-12T14:07:12ZFrederico Camara
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I tried to apply your patch but I encountered the following error.</p>
<p>[...]</p>
</blockquote>
<p>Thank you for reporting.</p>
<p>I made the patchfile again, against redmine 2.6.6. It is the same code as 2.6.5.</p>
<p>In 2.6.5, I think I removed windows line feeds from the files I was patching against and it messed up the patchfile.</p>
<p>2.6.6 should be ok.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=649242015-07-19T06:35:55ZMischa The Evil
<ul><li><strong>File</strong> <a href="/attachments/13993">rm20287_2.6-stable.r14424.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/13993/rm20287_2.6-stable.r14424.patch">rm20287_2.6-stable.r14424.patch</a> added</li></ul><p>I've extracted a corrected patch file (see <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/Patch">Patch</a>), using TortoiseSVN (so it can be applied using "<code>patch -p0 < rm20287...</code>"), against <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/14424/entry/branches/2.6-stable">source:/branches/2.6-stable@14424</a>. It contains the changes included in the diff file (as posted in <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Administration: Using grids instead of tables (New)" href="https://www.redmine.org/issues/20287#note-2">#20287-2</a>) and the addition of the JS and CSS files. This way it is much easier to review the changes made.</p>
<p>FTR: I have not reviewed the diff in substance, but I like the general idea behind this enhancement.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=654922015-08-18T03:40:01ZToshi MARUYAMA
<ul><li><strong>File</strong> <a href="/attachments/14123">issue-20287-trunk-r14507.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/14123/issue-20287-trunk-r14507.diff">issue-20287-trunk-r14507.diff</a> added</li></ul><p>This is rebased note-4 patch on trunk <a class="changeset" title="Japanese translation updated by Go MAEDA (#20538)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/14507">r14507</a>.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=681582015-12-28T16:56:25ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/14909">issue-20287-redmine-3.2.0.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/14909/issue-20287-redmine-3.2.0.diff">issue-20287-redmine-3.2.0.diff</a> added</li></ul><p>This is updated to use redmine-3.2 code (stable).</p>
<p>- Resolves some html format bugs on previous patches.</p>
<p>To apply:</p>
<p>patch -p1 < issue-20287-redmine-3.2.0.diff</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=747712016-11-29T14:39:03ZYuuki NARA
<ul></ul><p>+1</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=748542016-12-05T04:32:36ZN O
<ul></ul><p>+1</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=752962016-12-25T01:11:51ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-4 priority-default" href="/issues/17125">Defect #17125</a>: workflow's status-transitions' header-column & header-row pan & scroll out of view when numerous issue-statuses</i> added</li></ul> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=773932017-03-21T12:46:15ZGreg T
<ul></ul><p>I tried to apply this to Redmine 3.3, which wasn't easy with GNU patch, but it still has a javascript error: <em>TypeError: fsClass.contains is not a function</em> (when trying to access the <em>Additional transitions allowed when the user is ...</em> elements) at<br /><pre>
if (fsClass.contains("collapsed"))
</pre></p>
<p>Can you please fix that?</p>
<p>It seems <em>contains</em> is an outdated version of the <em>includes</em> method. But even that may not be supported by browsers (e.g. IE11), so it's safer to use</p>
<pre>
if (~fsClass.indexOf("collapsed"))
</pre> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=774642017-03-23T13:02:30ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/17979">issue-20287-redmine-3.3.0.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17979/issue-20287-redmine-3.3.0.diff">issue-20287-redmine-3.3.0.diff</a> added</li></ul><p>Greg T wrote:</p>
<blockquote>
<p>I tried to apply this to Redmine 3.3, which wasn't easy with GNU patch, but it still has a javascript error: <em>TypeError: fsClass.contains is not a function</em> (when trying to access the <em>Additional transitions allowed when the user is ...</em> elements) at<br />[...]</p>
<p>Can you please fix that?</p>
<p>It seems <em>contains</em> is an outdated version of the <em>includes</em> method. But even that may not be supported by browsers (e.g. IE11), so it's safer to use</p>
<p>[...]</p>
</blockquote>
<p>Thank you, I fixed that and updated the patch to what I am using now in production.</p>
<p>To apply:</p>
<p>patch -p1 < issue-20287-redmine-3.3.0.diff</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=775282017-03-27T10:56:58ZGreg T
<ul></ul><p>Thank you. It works.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=797462017-07-04T15:32:28ZGreg T
<ul></ul><p>This great patch should have been merged by now. :(<br />Do you have an updated patch for 3.4.0?</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=797602017-07-05T11:19:41ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/18687">issue-20287-redmine-3.4.0.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18687/issue-20287-redmine-3.4.0.diff">issue-20287-redmine-3.4.0.diff</a> added</li></ul><p>Greg T wrote:</p>
<blockquote>
<p>This great patch should have been merged by now. :(<br />Do you have an updated patch for 3.4.0?</p>
</blockquote>
<p>I updated the patch to the little changes made between 3.3.0 and 3.4.0. Did a little testing and it seems alright.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=797672017-07-05T14:37:38ZGreg T
<ul></ul><p>Frederico Camara wrote:</p>
<blockquote>
<p>I updated the patch to the little changes made between 3.3.0 and 3.4.0. Did a little testing and it seems alright.</p>
</blockquote>
<p>Thank you very much.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=949572019-11-20T13:14:55ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/24343">0001-Implements-grid-as-in-divgrid-minimal.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24343/0001-Implements-grid-as-in-divgrid-minimal.patch">0001-Implements-grid-as-in-divgrid-minimal.patch</a> added</li></ul><p>Updated to Redmine 4.0</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=972082020-04-08T15:52:17ZGreg T
<ul></ul><p>Dear Frederico Camara,</p>
<p>Can you give us a patch for 4.1.1?<br />Thanks.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=972102020-04-08T18:44:56ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/25173">0001-Implements-grid-as-in-divgrid-minimal-4.1.1.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25173/0001-Implements-grid-as-in-divgrid-minimal-4.1.1.patch">0001-Implements-grid-as-in-divgrid-minimal-4.1.1.patch</a> added</li></ul><p>Greg T wrote:</p>
<blockquote>
<p>Dear Frederico Camara,</p>
<p>Can you give us a patch for 4.1.1?<br />Thanks.</p>
</blockquote>
<p>Patch for 4.1.1 (unix)</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=972632020-04-14T15:28:02ZGreg T
<ul></ul><p>Frederico Camara wrote:</p>
<blockquote>
<p>Patch for 4.1.1 (unix)</p>
</blockquote>
<p>Thanks. One problem still remained:<br />1 out of 1 hunk FAILED -- saving rejects to file app/views/workflows/_form.html.erb.rej</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=972692020-04-15T02:45:02ZFrederico Camara
<ul><li><strong>File</strong> <a href="/attachments/25186">0001-Implements-grid-as-in-divgrid-minimal-4.1.1-fix1.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25186/0001-Implements-grid-as-in-divgrid-minimal-4.1.1-fix1.patch">0001-Implements-grid-as-in-divgrid-minimal-4.1.1-fix1.patch</a> added</li></ul><p>Greg T wrote:</p>
<blockquote>
<p>Frederico Camara wrote:</p>
<blockquote>
<p>Patch for 4.1.1 (unix)</p>
</blockquote>
<p>Thanks. One problem still remained:<br />1 out of 1 hunk FAILED -- saving rejects to file app/views/workflows/_form.html.erb.rej</p>
</blockquote>
<p>How I miss git when altering patches. I may have changed the file instead of the patch by mistake.</p>
<p>New patch, disregard the other.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=988422020-08-17T08:41:30ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/25836">trunk-r19977.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25836/trunk-r19977.patch">trunk-r19977.patch</a> added</li></ul><p><a class="user active" href="https://www.redmine.org/users/333978">FREDERICO LÚCIO DE SOUZA</a> Camara</p>
<p>Thank you for continuing to update the patch. This feature will be very pleasing to anyone who needs to read large tables.</p>
<p>The patch posted on <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Administration: Using grids instead of tables (New)" href="https://www.redmine.org/issues/20287#note-20">#20287#note-20</a> caused a conflict when applied to the trunk(<a class="changeset" title="Update Rouge to 3.22.0 (#32468)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/19977">r19977</a>), so I will attach the patch that resolved it.</p>
<p>To commit this patch to Redmine, it must be available on the latest Redmine in development.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=988432020-08-17T08:53:04ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/25838">ScreenShot_2020-08-17_17.49.08.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25838/ScreenShot_2020-08-17_17.49.08.png">ScreenShot_2020-08-17_17.49.08.png</a> added</li><li><strong>File</strong> <a href="/attachments/25837">ScreenShot_2020-08-17_17.49.28.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25837/ScreenShot_2020-08-17_17.49.28.png">ScreenShot_2020-08-17_17.49.28.png</a> added</li></ul><p>I haven't read the code yet, I noticed that the layout collapses when the screen width is reduced.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=988462020-08-17T15:20:35ZFrederico Camara
<ul></ul><p>Mizuki ISHIKAWA wrote:</p>
<blockquote>
<p>I haven't read the code yet, I noticed that the layout collapses when the screen width is reduced.</p>
</blockquote>
<p>It's the css and responsive. Just add 'box-sizing: content-box;' to '.g_c' is public/stylesheets/divgrid.css.</p>
<p>I've been trying to implement this with html tables, which I think would be faster, but html tables are hard. Anything but the trivial and you start struggling with the way it's implemented.</p>
<p>To give you and idea, you can stick rows and columns using position, left and top. You have to z-index the header cells left and top, using background color to hide cells underneath (doesn't hide very well). Also you have to adjust the width of row header cells, and adjust the fieldsets the way I did with the divgrid. And then, it starts looking like divgrid.</p> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=988802020-08-21T06:07:31ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/25844"> trunk-r19977-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25844/%20trunk-r19977-v2.patch"> trunk-r19977-v2.patch</a> added</li><li><strong>File</strong> <a href="/attachments/25845">ScreenShot_2020-08-21_15.05.11.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25845/ScreenShot_2020-08-21_15.05.11.png">ScreenShot_2020-08-21_15.05.11.png</a> added</li><li><strong>File</strong> <a href="/attachments/25846">ScreenShot_2020-08-21_15.06.19.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25846/ScreenShot_2020-08-21_15.06.19.png">ScreenShot_2020-08-21_15.06.19.png</a> added</li></ul><p>Frederico Camara wrote:</p>
<blockquote>
<p>Mizuki ISHIKAWA wrote:</p>
<blockquote>
<p>I haven't read the code yet, I noticed that the layout collapses when the screen width is reduced.</p>
</blockquote>
<p>It's the css and responsive. Just add 'box-sizing: content-box;' to '.g_c' is public/stylesheets/divgrid.css.</p>
<p>I've been trying to implement this with html tables, which I think would be faster, but html tables are hard. Anything but the trivial and you start struggling with the way it's implemented.</p>
<p>To give you and idea, you can stick rows and columns using position, left and top. You have to z-index the header cells left and top, using background color to hide cells underneath (doesn't hide very well). Also you have to adjust the width of row header cells, and adjust the fieldsets the way I did with the divgrid. And then, it starts looking like divgrid.</p>
</blockquote>
<p>Thank you for your reply.</p>
I've attached a patch that includes the following changes:
<ul>
<li>Fix so that the layout does not collapse when the width is narrowed</li>
<li>Move css written in style attribute to divgrid.css</li>
<li>Add class of elements lost on change</li>
<li>and others</li>
</ul> Redmine - Patch #20287: Administration: Using grids instead of tableshttps://www.redmine.org/issues/20287?journal_id=1031872021-07-09T04:54:52ZMizuki ISHIKAWA
<ul></ul><p>I've attached a patch to <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Workflow administration screen - loss of overview when working with many statuses (New)" href="https://www.redmine.org/issues/14508#note-2">#14508#note-2</a> that fixes the table header with CSS (position: sticky).</p>