https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-02-13T02:40:27ZRedmineRedmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=692132016-02-13T02:40:27ZToshi MARUYAMA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/21677">Feature #21677</a>: Support localized decimal separator for hours in the web UI</i> added</li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=692162016-02-13T02:43:58ZToshi MARUYAMA
<ul><li><strong>Subject</strong> changed from <i>decimal separator in float custom filed doesn´t work</i> to <i>Validation error on float custom filed in case of i18n decimal separator</i></li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=692462016-02-15T13:22:28ZRafael Neves
<ul></ul><p>thanks!</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1106872023-09-05T16:28:48ZLiane Hampe
<ul><li><strong>File</strong> <a href="/attachments/30905">support-localized-decimal-separator.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/30905/support-localized-decimal-separator.patch">support-localized-decimal-separator.patch</a> added</li></ul><p>Hi,</p>
<p>I'd like to set the focus on the missing support for localized decimal separators and delimiters in custom fields of format 'float' again. That is, inserting for example</p>
<pre>
# Separator problem
42,5 --> won't currently be valid.
The user needs to type in
42.5 instead.
# Delimiter problem
10000,99 should be rendered as 10.000,00 instead.
</pre>
<p>There are several issues (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Allow both '.' and ',' decimal symbols for input of float custom fields (Closed)" href="https://www.redmine.org/issues/25012">#25012</a>, <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Dynamic decimal separator, according to country setting (Closed)" href="https://www.redmine.org/issues/36183">#36183</a>) addressing this problem and a lot of countries using the decimal comma instead of dot as you can see here: <a class="external" href="https://en.wikipedia.org/wiki/Decimal_separator">https://en.wikipedia.org/wiki/Decimal_separator</a>.</p>
<p>I provided a patch solving this issue. It also includes tests.</p>
<p>Probably, there are many Redmine users which would appreciate this improvement.</p>
<p>Would be nice seeing it in a future release! :)</p>
<p>What are your thoughts?</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1106892023-09-05T17:40:13ZRafael Neves
<ul></ul><p>Hi,</p>
<p>It would be great see that patch included in future release.</p>
<p>Nice work !</p>
<p>Best regards</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1107122023-09-07T07:00:49ZLiane Hampe
<ul></ul><p><a class="user active" href="https://www.redmine.org/users/332">Go MAEDA</a>: Please note the patch (<a class="external" href="https://www.redmine.org/issues/22024#note-4">https://www.redmine.org/issues/22024#note-4</a>) for supporting localized decimal separators and delimiters in float custom field values.</p>
<p>I would love to see it in a future release. :)</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1107622023-09-18T05:30:12ZC S
<ul></ul><p>+1<br />Relation: <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Dynamic decimal separator, according to country setting (Closed)" href="https://www.redmine.org/issues/36183">#36183</a></p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121062023-12-30T09:32:11ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/31728">22024-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/31728/22024-v2.patch">22024-v2.patch</a> added</li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>Liane Hampe wrote in <a href="#note-6">#note-6</a>:</p>
<blockquote>
<p><a class="user active" href="https://www.redmine.org/users/332">Go MAEDA</a>: Please note the patch (<a class="external" href="https://www.redmine.org/issues/22024#note-4">https://www.redmine.org/issues/22024#note-4</a>) for supporting localized decimal separators and delimiters in float custom field values.</p>
</blockquote>
<p>Thank you for posting the patch. I think the patch makes it more user-friendly for international users.</p>
<p>The patch by Liane Hampe also adds the ability to display thousand delimiters. However, I think displaying thousand delimiters should be out of the scope of this patch. This is because not all users may agree with always displaying the thousand delimiter. Additionally, at this time, entering a value with a thousand delimiter into a custom field results in a validation error. In my opinion, the feature to display thousand delimiters should be discussed in another issue.</p>
<p>I have updated the patch for the current trunk and removed the feature to display thousand delimiters.</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121142023-12-30T18:43:31ZRafael Neves
<ul></ul><p>I appreciate and agree with that. In fact, the issue is on decimal separator, despite the plus done related to thousand issue.</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121292024-01-01T06:48:38ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/36183">Feature #36183</a>: Dynamic decimal separator, according to country setting</i> added</li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121332024-01-01T08:07:21ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/6182">Defect #6182</a>: Localized decimal numbers</i> added</li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121342024-01-01T09:55:31ZMischa The Evil
<ul></ul><p>Go MAEDA wrote in <a href="#note-8">#note-8</a>:</p>
<blockquote>
<p>[...] at this time, entering a value with a thousand delimiter into a custom field results in a validation error. In my opinion, the feature to display thousand delimiters should be discussed in another issue.</p>
<p>I have updated the patch for the current trunk and removed the feature to display thousand delimiters.</p>
</blockquote>
<p>I agree with that. A separate, additional feature providing a custom field option (using <code>field_attributes</code>?) to display thousand delimiters for selected <code>Float</code> (but also <code>Integer</code>) custom fields could be nice to have in some cases when dealing with larger values, but that's not related to the decimal separator issue indeed (nor is it fully covered by the solution in the provided patch). I've opened issue <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Add an option to render values of Integer- and Float-format custom fields with thousands delimiters (New)" href="https://www.redmine.org/issues/39997">#39997</a> for that.<br />However, I think that Redmine doesn't need to provide support for entering values with thousands delimiters into a custom field. It feels like overkill to me.</p>
<p>Regarding the v2-patch: it looks good to me, but the proposed method <code>test_float_field_should_format_with_various_locale_separator_and_delimiter</code> doesn't explicitly test anything delimiter related anymore, so maybe it's better to drop the postfix from its name.</p>
<p>About the scheduling: given the potential impact of the proposed changes downstream, I agree with bringing this in a major release, but why not in 6.0.0? The current state of this patch seems pretty complete to me.<br />OTOH, it might be desirable for downstream compatibility maintenance to bring this change together in one go with the contextually-related, currently yet incomplete issues <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Support localized decimal separator for hours in the web UI (Closed)" href="https://www.redmine.org/issues/21677">#21677</a> and <a class="issue tracker-1 status-9 priority-4 priority-default" title="Defect: Time Formatting does not apply to CSV exports (Confirmed)" href="https://www.redmine.org/issues/35726">#35726</a> (with <a class="issue tracker-1 status-9 priority-4 priority-default" title="Defect: CSV and PDF export don't respect Time span format (Confirmed)" href="https://www.redmine.org/issues/31637">#31637</a>). If it is deemed a desired feature, then also <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Add an option to render values of Integer- and Float-format custom fields with thousands delimiters (New)" href="https://www.redmine.org/issues/39997">#39997</a>, would ideally be brought along with those at the same time too.</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121372024-01-01T10:31:16ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/31738">22024-v3.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/31738/22024-v3.patch">22024-v3.patch</a> added</li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>6.0.0</i></li></ul><p>Updated the patch again.<br />Estimated hours, spent time, and PDF export now also support internationalized decimal separator.</p>
<p>Mischa The Evil wrote in <a href="#note-12">#note-12</a>:</p>
<blockquote>
<p>Regarding the v2-patch: it looks good to me, but the proposed method <code>test_float_field_should_format_with_various_locale_separator_and_delimiter</code> doesn't explicitly test anything delimiter related anymore, so maybe it's better to drop the postfix from its name.</p>
</blockquote>
<p>Fixed. Thank you.</p>
<p>Setting the target version to 6.0.0.</p> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121652024-01-03T13:50:16ZHolger Just
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/39997">Feature #39997</a>: Add an option to render values of Integer- and Float-format custom fields with thousands delimiters</i> added</li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121792024-01-04T02:44:26ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/25012">Feature #25012</a>: Allow both '.' and ',' decimal symbols for input of float custom fields</i> added</li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121812024-01-04T02:55:15ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>Validation error on float custom filed in case of i18n decimal separator</i> to <i>Support locale-dependent decimal separators for float values</i></li><li><strong>Affected version</strong> deleted (<del><i>2.6.2</i></del>)</li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121832024-01-04T06:50:55ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Support locale-dependent decimal separators for float values</i> to <i>Support localized decimal separators for float values</i></li></ul> Redmine - Feature #22024: Support localized decimal separators for float valueshttps://www.redmine.org/issues/22024?journal_id=1121852024-01-04T07:07:46ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed <a class="user active" href="https://www.redmine.org/users/361769">Liane Hampe</a> 's patch with slight changes in <a class="changeset" title="Support localized decimal separators for float values (#22024). Patch by Liane Hampe (@liane_ham..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/22592">r22592</a>. Also, I added support for PDF export in <a class="changeset" title="Support localized decimal separators for float values in PDF export (#22024). Patch by Go MAEDA ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/22594">r22594</a>.<br />Thank you for your contribution.</p>