https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-03-24T23:55:59ZRedmineRedmine - Patch #22278: Revision Graph and Table should work with vertical-align: middlehttps://www.redmine.org/issues/22278?journal_id=699322016-03-24T23:55:59ZGo MAEDA
<ul><li><strong>Category</strong> changed from <i>Themes</i> to <i>UI</i></li></ul><p>Thanks for the patch. Could you show screenshots of the effect of this patch?</p> Redmine - Patch #22278: Revision Graph and Table should work with vertical-align: middlehttps://www.redmine.org/issues/22278?journal_id=699372016-03-25T12:03:56ZGregor Schmidtschmidt@nach-vorne.eu
<ul><li><strong>File</strong> <a href="/attachments/15628">theme-without-patch.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/15628/theme-without-patch.png">theme-without-patch.png</a> added</li><li><strong>File</strong> <a href="/attachments/15629">theme-with-patch.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/15629/theme-with-patch.png">theme-with-patch.png</a> added</li><li><strong>File</strong> <a href="/attachments/15630">default-with-patch.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/15630/default-with-patch.png">default-with-patch.png</a> added</li><li><strong>File</strong> <a href="/attachments/15631">planio-with-patch.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/15631/planio-with-patch.png">planio-with-patch.png</a> added</li></ul><p>Sure, here we go!</p>
<p>For "educational purpose" I've created a simple theme with the following <code>application.css</code></p>
<pre>
@import url(../../../stylesheets/application.css);
table.changesets td {
vertical-align: middle;
}
</pre>
<p>Using this theme and the current Redmine trunk, I get the following revision table</p>
<p><img src="https://www.redmine.org/attachments/download/15628/theme-without-patch.png" alt="" /></p>
<p>Using the patch, I get the following</p>
<p><img src="https://www.redmine.org/attachments/download/15629/theme-with-patch.png" alt="" /></p>
<p>while the default theme still looks as expected</p>
<p><img src="https://www.redmine.org/attachments/download/15630/default-with-patch.png" alt="" /></p>
<p>This example theme does not make a lot of sense on its own. It was just created for testing. But e.g. Planio's new design uses <code>vertical-align: middle</code> for its tables. (Planio already has the patch applied.)</p>
<p><img src="https://www.redmine.org/attachments/download/15631/planio-with-patch.png" alt="" /></p> Redmine - Patch #22278: Revision Graph and Table should work with vertical-align: middlehttps://www.redmine.org/issues/22278?journal_id=699402016-03-25T12:57:39ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.2.2</i></li></ul><p>Thanks, I understand.<br />Setting target version to 3.2.2.</p> Redmine - Patch #22278: Revision Graph and Table should work with vertical-align: middlehttps://www.redmine.org/issues/22278?journal_id=701012016-04-03T12:29:54ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Committed, thanks.</p>