https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-07-09T03:19:52ZRedmineRedmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=720892016-07-09T03:19:52ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Category</strong> set to <i>Email receiving</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> set to <i>3.2.4</i></li></ul><p>Yes, we can see that by removing <code>issue.reload</code> in <code>MailHandlerTest#test_add_issue_should_add_cc_as_watchers</code>.<br />I've committed a different fix in <a class="changeset" title="When creating issues by receiving an email, watchers created via CC in the mail don't get an emai..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/15609">r15609</a> that uses <code>#reset</code> instead of <code>#reload</code> in <code>#add_watcher</code> and <code>#remove_watcher</code> instead of forcing a reload before sending the notification.<br />Please let me know if there is anything wrong with that.</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=721172016-07-11T08:51:51ZHolger Just
<ul></ul><p>Using <code>reset</code> instead of <code>reload</code> should result in the exactly the same result since Rails will then autoload the association on next access anyway. Using <code>reset</code> will just be a bit faster if we haven't updated the association since we are saving some SQL queries. Thus, a big +1 from me. Thanks, Jean-Philippe!</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=721262016-07-11T18:10:35ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Thanks for your feedback Holger, I've merged the fix.</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=722252016-07-16T14:27:53ZVictor Campos
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>Thanks for your feedback Holger, I've merged the fix.</p>
</blockquote>
<p>Hi,<br />reset shoundn't happen after add/remove?</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=722602016-07-18T12:14:45ZHolger Just
<ul></ul><p>Victor Campos wrote:</p>
<blockquote>
<p>reset shoundn't happen after add/remove?</p>
</blockquote>
<p>The <a href="http://api.rubyonrails.org/classes/ActiveRecord/Associations/CollectionProxy.html#method-i-reset" class="external">reset</a> method just clear the cache of the association proxy but does not actually reload the association. As such, the only requirement is that the reset happens before the <code>watcher_users</code> association is accessed next time. This does not happen when adding the watcher itself. As such, resetting the association before adding the watcher is fine.</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=722622016-07-18T12:17:05ZVictor Campos
<ul></ul><p>Holger Just wrote:</p>
<blockquote>
<p>Victor Campos wrote:</p>
<blockquote>
<p>reset shoundn't happen after add/remove?</p>
</blockquote>
<p>The <a href="http://api.rubyonrails.org/classes/ActiveRecord/Associations/CollectionProxy.html#method-i-reset" class="external">reset</a> method just clear the cache of the association proxy but does not actually reload the association. As such, the only requirement is that the reset happens before the <code>watcher_users</code> association is accessed next time. This does not happen when adding the watcher itself. As such, resetting the association before adding the watcher is fine.</p>
</blockquote>
<p>Thx =)</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=775342017-03-27T12:26:33ZJoaquim Homrighausen
<ul></ul><p>Does this in any way change the handling of watchers not being added from the FROM: field of an email-imported issue?</p> Redmine - Patch #23278: When creating issues by receiving an email, watchers created via CC in the mail don't get an email notificationhttps://www.redmine.org/issues/23278?journal_id=782152017-04-26T08:06:42ZToshi MARUYAMA
<ul></ul><p>Joaquim Homrighausen wrote:</p>
<blockquote>
<p>Does this in any way change the handling of watchers not being added from the FROM: field of an email-imported issue?</p>
</blockquote>
<p>AFAIK, FROM become author.<br />If you mean CC not FROM, please create new feature issue.</p>