https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-10-08T08:30:07ZRedmineRedmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=739222016-10-08T08:30:07ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>In the comments, you say that Redmine needs to have write permission on the plugins directory. Why is that? I think it should have read permission only.</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=739312016-10-08T10:36:22ZAndrey Lobanov (RedSoft)
<ul></ul><p>I agree. Why plugins directory should have write permissions?</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=739442016-10-09T09:07:38ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Category</strong> set to <i>Plugin API</i></li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> set to <i>3.4.0</i></li></ul> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=739702016-10-10T13:01:47ZHelder Manuel Torres Vieira
<ul></ul><p>Hello,</p>
<p>Sorry, it was a mistake, i was talking about read permissions (not write).</p>
<p>Thanks</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=745492016-11-18T12:20:25ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Patch committed, thanks.</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=779192017-04-10T13:40:55ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p><code>config/routes.rb</code> must be aware of <code>plugins_path</code> setting.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: config/routes.rb
===================================================================
</span><span class="gd">--- config/routes.rb (revision 16528)
</span><span class="gi">+++ config/routes.rb (working copy)
</span><span class="p">@@ -374,7 +374,7 @@</span>
get 'robots.txt', :to => 'welcome#robots'
- Dir.glob File.expand_path("plugins/*", Rails.root) do |plugin_dir|
<span class="gi">+ Dir.glob File.expand_path("#{Redmine::Plugin.directory}/*", Rails.root) do |plugin_dir|
</span> file = File.join(plugin_dir, "config/routes.rb")
if File.exists?(file)
begin
</code></pre> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=780132017-04-15T00:12:58ZAnonymous
<ul></ul><p>I wish that functionality, would be very great for multitenancy environments.</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=791522017-06-10T12:05:40ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Fix committed, thanks.</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=791642017-06-12T09:34:14ZGo MAEDA
<ul><li><strong>Blocked by</strong> <i><a class="issue tracker-3 status-8 priority-4 priority-default" href="/issues/26139">Patch #26139</a>: Follow Gemfile's plugin loader as #24007</i> added</li></ul> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=791652017-06-12T09:35:45ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Reopening this issue because a fix for this feature has been submitted as <a class="issue tracker-3 status-8 priority-4 priority-default" title="Patch: Follow Gemfile's plugin loader as #24007 (Reopened)" href="https://www.redmine.org/issues/26139">#26139</a>.</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=791842017-06-13T04:36:54ZSho HASHIMOTO
<ul></ul><p>Is <a class="changeset" title="Plugin directory is configurable (#24007). Patch by Go MAEDA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16654">r16654</a> correct?<br />config_plugins_path.diff defines Redmine::Plugin.directory as "Absolute path to the directory where plugins are stored.".<br />File.expand_path("#{Redmine::Plugin.directory}/*", Rails.root) maybe returns "#{Rails.root}/#{Redmine::Plugin.directory}/*"</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=792562017-06-17T07:59:03ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Sho HASHIMOTO wrote:</p>
<blockquote>
<p>Is <a class="changeset" title="Plugin directory is configurable (#24007). Patch by Go MAEDA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16654">r16654</a> correct?<br />config_plugins_path.diff defines Redmine::Plugin.directory as "Absolute path to the directory where plugins are stored.".<br />File.expand_path("#{Redmine::Plugin.directory}/*", Rails.root) maybe returns "#{Rails.root}/#{Redmine::Plugin.directory}/*"</p>
</blockquote>
<p>No it does not returns that because the first argument is an absolute path. But for clarity, I've removed the second arg that is not used. Thanks for pointing this out.</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=792622017-06-17T10:41:43ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Assignee</strong> deleted (<del><i>Jean-Philippe Lang</i></del>)</li><li><strong>Target version</strong> deleted (<del><i>3.4.0</i></del>)</li></ul><p>The current implementation does not support loading plugin gemfiles (<a class="issue tracker-3 status-8 priority-4 priority-default" title="Patch: Follow Gemfile's plugin loader as #24007 (Reopened)" href="https://www.redmine.org/issues/26139">#26139</a>), I've removed the option in the configuration file for 3.4.0</p> Redmine - Patch #24007: Change plugins directory through the configuration.yml filehttps://www.redmine.org/issues/24007?journal_id=792782017-06-18T11:56:53ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-1 priority-4 priority-default" href="/issues/13927">Patch #13927</a>: Reduce coupling between plugins and the "plugins/" directory</i> added</li></ul>